Open source video conferencing app powered by LiveKit. Built with Django and React.
⚡️(frontend) optimize countdown check in IsIdleDisconnectModal.tsx
lebaudantoinee3e34dbf3147
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 22919b4e..3474d5dd 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -12,6 +12,7 @@ and this project adheres to- 🔒️(backend) enhance API input validation to strengthen security #1053- 🦺(backend) strengthen API validation for recording options #1063+- ⚡️(frontend) optimize few performance caveats #1073### Fixeddiff --git a/src/frontend/src/features/rooms/livekit/components/IsIdleDisconnectModal.tsx b/src/frontend/src/features/rooms/livekit/components/IsIdleDisconnectModal.tsxindex 60f3d2f2..758a142b 100644--- a/src/frontend/src/features/rooms/livekit/components/IsIdleDisconnectModal.tsx+++ b/src/frontend/src/features/rooms/livekit/components/IsIdleDisconnectModal.tsx@@ -13,7 +13,7 @@ import { useSettingsDialog } from '@/features/settings/hook/useSettingsDialog'import { SettingsDialogExtendedKey } from '@/features/settings/type'const IDLE_DISCONNECT_TIMEOUT_MS = 120000 // 2 minutes-const COUNTDOWN_ANNOUNCEMENT_SECONDS = [90, 60, 30]+const COUNTDOWN_ANNOUNCEMENT_SECONDS = new Set([90, 60, 30])const FINAL_COUNTDOWN_SECONDS = 10export const IsIdleDisconnectModal = () => {@@ -58,7 +58,7 @@ export const IsIdleDisconnectModal = () => {if (!connectionObserverSnap.isIdleDisconnectModalOpen) returnconst shouldAnnounce =- COUNTDOWN_ANNOUNCEMENT_SECONDS.includes(remainingSeconds) ||+ COUNTDOWN_ANNOUNCEMENT_SECONDS.has(remainingSeconds) ||remainingSeconds <= FINAL_COUNTDOWN_SECONDSif (shouldAnnounce && remainingSeconds !== lastAnnouncementRef.current) {