Skip to content

armgit / meet

Public Imported from GitHub
0

Open source video conferencing app powered by LiveKit. Built with Django and React.

πŸ”₯(backend) drop is_administrable from unregistered room payloads

briquete412dec76f12
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2c3f1786..75a0add8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,7 @@ and this project adheres to
- ⬆️(summary) update python dependencies
- πŸ”’οΈ(backend) issue room access tokens via POST rooms/{id}/join/ only
- πŸ”’οΈ(frontend) send the display name in the join request body
+- πŸ”₯(backend) drop is_administrable from unregistered room payloads
### Fixed
diff --git a/UPGRADE.md b/UPGRADE.md
index 71d274a9..f0193c9c 100644
--- a/UPGRADE.md
+++ b/UPGRADE.md
@@ -33,6 +33,7 @@ responses
participant identity each time.
- Joining again returns no `livekit` block to callers admitted through the lobby.
- Unregistered rooms are always entered directly: joining one always returns a `livekit` block.
+- Unregistered rooms are no longer described with an `is_administrable` field,
## v1.37.0
diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.py
index 75c6aa38..5641417f 100644
--- a/src/backend/core/api/viewsets.py
+++ b/src/backend/core/api/viewsets.py
@@ -325,7 +325,6 @@ class RoomViewSet( # pylint: disable=too-many-public-methods
return {
"id": None,
"slug": slug,
- "is_administrable": False,
"access_level": RoomAccessLevel.PUBLIC,
}
diff --git a/src/backend/core/tests/rooms/test_api_rooms_join.py b/src/backend/core/tests/rooms/test_api_rooms_join.py
index a52a1818..13b6bcac 100644
--- a/src/backend/core/tests/rooms/test_api_rooms_join.py
+++ b/src/backend/core/tests/rooms/test_api_rooms_join.py
@@ -217,7 +217,6 @@ def test_api_rooms_join_unregistered_allowed(mock_token, authenticated, settings
"id": None,
"slug": "unregistered-room",
"access_level": "public",
- "is_administrable": False,
"livekit": {
"url": settings.LIVEKIT_CONFIGURATION["url"],
"room": "unregistered-room",
@@ -250,7 +249,6 @@ def test_api_rooms_join_unregistered_allowed_not_normalized(mock_token, settings
"id": None,
"slug": "reunion",
"access_level": "public",
- "is_administrable": False,
"livekit": {
"url": settings.LIVEKIT_CONFIGURATION["url"],
"room": "reunion",
diff --git a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
index 3621be75..0ac7957d 100644
--- a/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
+++ b/src/backend/core/tests/rooms/test_api_rooms_retrieve.py
@@ -123,7 +123,6 @@ def test_api_rooms_retrieve_anonymous_unregistered_allowed(mock_token):
"id": None,
"slug": "unregistered-room",
"access_level": "public",
- "is_administrable": False,
}
mock_token.assert_not_called()
@@ -144,7 +143,6 @@ def test_api_rooms_retrieve_anonymous_unregistered_allowed_not_normalized(mock_t
"id": None,
"slug": "reunion",
"access_level": "public",
- "is_administrable": False,
}
mock_token.assert_not_called()
diff --git a/src/frontend/src/features/rooms/api/ApiRoom.ts b/src/frontend/src/features/rooms/api/ApiRoom.ts
index 86309a83..30174ce8 100644
--- a/src/frontend/src/features/rooms/api/ApiRoom.ts
+++ b/src/frontend/src/features/rooms/api/ApiRoom.ts
@@ -31,7 +31,6 @@ export type ApiRoom = {
name: string
slug: string
pin_code?: string
- is_administrable: boolean
access_level: ApiAccessLevel
livekit?: ApiLiveKit
configuration?: RoomConfiguration