Open source video conferencing app powered by LiveKit. Built with Django and React.
♻️(frontend) generalize transcript notification for all recording types
lebaudantoinef596aae1e82a
diff --git a/src/frontend/src/features/notifications/MainNotificationToast.tsx b/src/frontend/src/features/notifications/MainNotificationToast.tsxindex 0e4a8746..ea70afaf 100644--- a/src/frontend/src/features/notifications/MainNotificationToast.tsx+++ b/src/frontend/src/features/notifications/MainNotificationToast.tsx@@ -90,6 +90,8 @@ export const MainNotificationToast = () => {breakcase NotificationType.TranscriptionStarted:case NotificationType.TranscriptionStopped:+ case NotificationType.ScreenRecordingStarted:+ case NotificationType.ScreenRecordingStopped:toastQueue.add({participant,diff --git a/src/frontend/src/features/notifications/NotificationType.ts b/src/frontend/src/features/notifications/NotificationType.tsindex b2eb8709..5b0a75fa 100644--- a/src/frontend/src/features/notifications/NotificationType.ts+++ b/src/frontend/src/features/notifications/NotificationType.ts@@ -8,4 +8,6 @@ export enum NotificationType {ParticipantWaiting = 'participantWaiting',TranscriptionStarted = 'transcriptionStarted',TranscriptionStopped = 'transcriptionStopped',+ ScreenRecordingStarted = 'screenRecordingStarted',+ ScreenRecordingStopped = 'screenRecordingStopped',}diff --git a/src/frontend/src/features/notifications/components/ToastTranscript.tsx b/src/frontend/src/features/notifications/components/ToastAnyRecording.tsxsimilarity index 54%rename from src/frontend/src/features/notifications/components/ToastTranscript.tsxrename to src/frontend/src/features/notifications/components/ToastAnyRecording.tsxindex 93de32db..c29c7645 100644--- a/src/frontend/src/features/notifications/components/ToastTranscript.tsx+++ b/src/frontend/src/features/notifications/components/ToastAnyRecording.tsx@@ -1,20 +1,34 @@import { useToast } from '@react-aria/toast'-import { useRef } from 'react'+import { useMemo, useRef } from 'react'import { StyledToastContainer, ToastProps } from './Toast'import { HStack } from '@/styled-system/jsx'import { useTranslation } from 'react-i18next'import { NotificationType } from '../NotificationType'-export function ToastTranscript({ state, ...props }: ToastProps) {- const { t } = useTranslation('notifications', { keyPrefix: 'transcript' })+export function ToastAnyRecording({ state, ...props }: ToastProps) {+ const { t } = useTranslation('notifications')const ref = useRef(null)const { toastProps, contentProps } = useToast(props, state, ref)const participant = props.toast.content.participantconst type = props.toast.content.type- const key =- type == NotificationType.TranscriptionStarted ? 'started' : 'stopped'+ const key = useMemo(() => {+ switch (type) {+ case NotificationType.TranscriptionStarted:+ return 'transcript.started'+ case NotificationType.TranscriptionStopped:+ return 'transcript.stopped'+ case NotificationType.ScreenRecordingStarted:+ return 'screenRecording.started'+ case NotificationType.ScreenRecordingStopped:+ return 'screenRecording.stopped'+ default:+ return+ }+ }, [type])++ if (!key) returnreturn (<StyledToastContainer {...toastProps} ref={ref}>diff --git a/src/frontend/src/features/notifications/components/ToastRegion.tsx b/src/frontend/src/features/notifications/components/ToastRegion.tsxindex 208bff8f..cf0e4870 100644--- a/src/frontend/src/features/notifications/components/ToastRegion.tsx+++ b/src/frontend/src/features/notifications/components/ToastRegion.tsx@@ -9,7 +9,7 @@ import { ToastRaised } from './ToastRaised'import { ToastMuted } from './ToastMuted'import { ToastMessageReceived } from './ToastMessageReceived'import { ToastLowerHand } from './ToastLowerHand'-import { ToastTranscript } from './ToastTranscript'+import { ToastAnyRecording } from './ToastAnyRecording'interface ToastRegionProps extends AriaToastRegionProps {state: ToastState<ToastData>@@ -39,7 +39,9 @@ const renderToast = (case NotificationType.TranscriptionStarted:case NotificationType.TranscriptionStopped:- return <ToastTranscript key={toast.key} toast={toast} state={state} />+ case NotificationType.ScreenRecordingStarted:+ case NotificationType.ScreenRecordingStopped:+ return <ToastAnyRecording key={toast.key} toast={toast} state={state} />default:return <Toast key={toast.key} toast={toast} state={state} />diff --git a/src/frontend/src/locales/de/notifications.json b/src/frontend/src/locales/de/notifications.jsonindex 1dd545ba..8b4120f2 100644--- a/src/frontend/src/locales/de/notifications.json+++ b/src/frontend/src/locales/de/notifications.json@@ -25,5 +25,9 @@"transcript": {"started": "","stopped": ""+ },+ "screenRecording": {+ "started": "",+ "stopped": ""}}diff --git a/src/frontend/src/locales/en/notifications.json b/src/frontend/src/locales/en/notifications.jsonindex ffe8876f..f8d4f7aa 100644--- a/src/frontend/src/locales/en/notifications.json+++ b/src/frontend/src/locales/en/notifications.json@@ -25,5 +25,9 @@"transcript": {"started": "{{name}} started the meeting transcription.","stopped": "{{name}} stopped the meeting transcription."+ },+ "screenRecording": {+ "started": "{{name}} started the meeting recording.",+ "stopped": "{{name}} stopped the meeting recording."}}diff --git a/src/frontend/src/locales/fr/notifications.json b/src/frontend/src/locales/fr/notifications.jsonindex d9bd30c6..90b065eb 100644--- a/src/frontend/src/locales/fr/notifications.json+++ b/src/frontend/src/locales/fr/notifications.json@@ -25,5 +25,9 @@"transcript": {"started": "{{name}} a démarré la transcription de la réunion.","stopped": "{{name}} a arrêté la transcription de la réunion."+ },+ "screenRecording": {+ "started": "{{name}} a démarré l'enregistrement de la réunion.",+ "stopped": "{{name}} a arrêté l'enregistrement de la réunion."}}diff --git a/src/frontend/src/locales/nl/notifications.json b/src/frontend/src/locales/nl/notifications.jsonindex cdca57b3..2e653876 100644--- a/src/frontend/src/locales/nl/notifications.json+++ b/src/frontend/src/locales/nl/notifications.json@@ -25,5 +25,9 @@"transcript": {"started": "{{name}} is de transcriptie van de vergadering gestart.","stopped": "{{name}} heeft de transcriptie van de vergadering gestopt."+ },+ "screenRecording": {+ "started": "{{name}} is begonnen met het opnemen van de vergadering.",+ "stopped": "{{name}} is gestopt met het opnemen van de vergadering."}}