Skip to content

armgit / mem0

Public Imported from GitHub
0

The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.

Improve neo4j queries (#2654)

Tomaz Bratanic0d895b28aede
diff --git a/mem0/memory/graph_memory.py b/mem0/memory/graph_memory.py
index 685862a17..08df07244 100644
--- a/mem0/memory/graph_memory.py
+++ b/mem0/memory/graph_memory.py
@@ -92,7 +92,7 @@ class MemoryGraph:
return []
search_outputs_sequence = [
- [item["source"], item["relatationship"], item["destination"]] for item in search_output
+ [item["source"], item["relationship"], item["destination"]] for item in search_output
]
bm25 = BM25Okapi(search_outputs_sequence)
@@ -231,23 +231,17 @@ class MemoryGraph:
cypher_query = """
MATCH (n)
WHERE n.embedding IS NOT NULL AND n.user_id = $user_id
- WITH n,
- round(reduce(dot = 0.0, i IN range(0, size(n.embedding)-1) | dot + n.embedding[i] * $n_embedding[i]) /
- (sqrt(reduce(l2 = 0.0, i IN range(0, size(n.embedding)-1) | l2 + n.embedding[i] * n.embedding[i])) *
- sqrt(reduce(l2 = 0.0, i IN range(0, size($n_embedding)-1) | l2 + $n_embedding[i] * $n_embedding[i]))), 4) AS similarity
+ WITH n, round(2 * vector.similarity.cosine(n.embedding, $n_embedding) - 1, 4) AS similarity // denormalize for backward compatibility
WHERE similarity >= $threshold
- MATCH (n)-[r]->(m)
- RETURN n.name AS source, elementId(n) AS source_id, type(r) AS relatationship, elementId(r) AS relation_id, m.name AS destination, elementId(m) AS destination_id, similarity
- UNION
- MATCH (n)
- WHERE n.embedding IS NOT NULL AND n.user_id = $user_id
- WITH n,
- round(reduce(dot = 0.0, i IN range(0, size(n.embedding)-1) | dot + n.embedding[i] * $n_embedding[i]) /
- (sqrt(reduce(l2 = 0.0, i IN range(0, size(n.embedding)-1) | l2 + n.embedding[i] * n.embedding[i])) *
- sqrt(reduce(l2 = 0.0, i IN range(0, size($n_embedding)-1) | l2 + $n_embedding[i] * $n_embedding[i]))), 4) AS similarity
- WHERE similarity >= $threshold
- MATCH (m)-[r]->(n)
- RETURN m.name AS source, elementId(m) AS source_id, type(r) AS relatationship, elementId(r) AS relation_id, n.name AS destination, elementId(n) AS destination_id, similarity
+ CALL (n) {
+ MATCH (n)-[r]->(m)
+ RETURN n.name AS source, elementId(n) AS source_id, type(r) AS relationship, elementId(r) AS relation_id, m.name AS destination, elementId(m) AS destination_id
+ UNION
+ MATCH (m)-[r]->(n)
+ RETURN m.name AS source, elementId(m) AS source_id, type(r) AS relationship, elementId(r) AS relation_id, n.name AS destination, elementId(n) AS destination_id
+ }
+ WITH distinct source, source_id, relationship, relation_id, destination, destination_id, similarity //deduplicate
+ RETURN source, source_id, relationship, relation_id, destination, destination_id, similarity
ORDER BY similarity DESC
LIMIT $limit
"""
@@ -280,6 +274,7 @@ class MemoryGraph:
],
tools=_tools,
)
+
to_be_deleted = []
for item in memory_updates["tool_calls"]:
if item["name"] == "delete_graph_memory":
@@ -295,12 +290,12 @@ class MemoryGraph:
for item in to_be_deleted:
source = item["source"]
destination = item["destination"]
- relatationship = item["relationship"]
+ relationship = item["relationship"]
# Delete the specific relationship between nodes
cypher = f"""
MATCH (n {{name: $source_name, user_id: $user_id}})
- -[r:{relatationship}]->
+ -[r:{relationship}]->
(m {{name: $dest_name, user_id: $user_id}})
DELETE r
RETURN
@@ -345,8 +340,10 @@ class MemoryGraph:
WHERE elementId(source) = $source_id
MERGE (destination:{destination_type} {{name: $destination_name, user_id: $user_id}})
ON CREATE SET
- destination.created = timestamp(),
- destination.embedding = $destination_embedding
+ destination.created = timestamp()
+ WITH source, destination
+ CALL db.create.setNodeVectorProperty(destination, 'embedding', $destination_embedding)
+ WITH source, destination
MERGE (source)-[r:{relationship}]->(destination)
ON CREATE SET
r.created = timestamp()
@@ -365,8 +362,10 @@ class MemoryGraph:
WHERE elementId(destination) = $destination_id
MERGE (source:{source_type} {{name: $source_name, user_id: $user_id}})
ON CREATE SET
- source.created = timestamp(),
- source.embedding = $source_embedding
+ source.created = timestamp()
+ WITH source, destination
+ CALL db.create.setNodeVectorProperty(source, 'embedding', $source_embedding)
+ WITH source, destination
MERGE (source)-[r:{relationship}]->(destination)
ON CREATE SET
r.created = timestamp()
@@ -389,6 +388,8 @@ class MemoryGraph:
ON CREATE SET
r.created_at = timestamp(),
r.updated_at = timestamp()
+
+
RETURN source.name AS source, type(r) AS relationship, destination.name AS target
"""
params = {
@@ -399,11 +400,15 @@ class MemoryGraph:
else:
cypher = f"""
MERGE (n:{source_type} {{name: $source_name, user_id: $user_id}})
- ON CREATE SET n.created = timestamp(), n.embedding = $source_embedding
- ON MATCH SET n.embedding = $source_embedding
+ ON CREATE SET n.created = timestamp()
+ WITH n
+ CALL db.create.setNodeVectorProperty(n, 'embedding', $source_embedding)
+ WITH n
MERGE (m:{destination_type} {{name: $dest_name, user_id: $user_id}})
- ON CREATE SET m.created = timestamp(), m.embedding = $dest_embedding
- ON MATCH SET m.embedding = $dest_embedding
+ ON CREATE SET m.created = timestamp()
+ WITH n, m
+ CALL db.create.setNodeVectorProperty(m, 'embedding', $source_embedding)
+ WITH n, m
MERGE (n)-[rel:{relationship}]->(m)
ON CREATE SET rel.created = timestamp()
RETURN n.name AS source, type(rel) AS relationship, m.name AS target
@@ -433,14 +438,7 @@ class MemoryGraph:
AND source_candidate.user_id = $user_id
WITH source_candidate,
- round(
- reduce(dot = 0.0, i IN range(0, size(source_candidate.embedding)-1) |
- dot + source_candidate.embedding[i] * $source_embedding[i]) /
- (sqrt(reduce(l2 = 0.0, i IN range(0, size(source_candidate.embedding)-1) |
- l2 + source_candidate.embedding[i] * source_candidate.embedding[i])) *
- sqrt(reduce(l2 = 0.0, i IN range(0, size($source_embedding)-1) |
- l2 + $source_embedding[i] * $source_embedding[i])))
- , 4) AS source_similarity
+ round(2 * vector.similarity.cosine(source_candidate.embedding, $source_embedding) - 1, 4) AS source_similarity // denormalize for backward compatibility
WHERE source_similarity >= $threshold
WITH source_candidate, source_similarity
@@ -466,14 +464,8 @@ class MemoryGraph:
AND destination_candidate.user_id = $user_id
WITH destination_candidate,
- round(
- reduce(dot = 0.0, i IN range(0, size(destination_candidate.embedding)-1) |
- dot + destination_candidate.embedding[i] * $destination_embedding[i]) /
- (sqrt(reduce(l2 = 0.0, i IN range(0, size(destination_candidate.embedding)-1) |
- l2 + destination_candidate.embedding[i] * destination_candidate.embedding[i])) *
- sqrt(reduce(l2 = 0.0, i IN range(0, size($destination_embedding)-1) |
- l2 + $destination_embedding[i] * $destination_embedding[i])))
- , 4) AS destination_similarity
+ round(2 * vector.similarity.cosine(destination_candidate.embedding, $destination_embedding) - 1, 4) AS destination_similarity // denormalize for backward compatibility
+
WHERE destination_similarity >= $threshold
WITH destination_candidate, destination_similarity