The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.
Python agentic-memoryagentic-memory-systemagentsaiai-agentschatgptgenaillmlong-term-memorymemorymemory-managementpythonragstate-management
fix: use 'is not None' instead of truthiness for vector/payload in pgvector update (#5488)
Hrushikesh Yadav2dd2872c0834
diff --git a/mem0/vector_stores/pgvector.py b/mem0/vector_stores/pgvector.pyindex 4b1606a1d..d36cab1cc 100644--- a/mem0/vector_stores/pgvector.py+++ b/mem0/vector_stores/pgvector.py@@ -425,12 +425,12 @@ class PGVector(VectorStoreBase):"""self._ensure_collection()with self._get_cursor(commit=True) as cur:- if vector:+ if vector is not None:cur.execute(sql.SQL("UPDATE {} SET vector = %s WHERE id = %s").format(self._col()),(vector, vector_id),)- if payload:+ if payload is not None:# Handle JSON serialization based on psycopg versionif PSYCOPG_VERSION == 3:# psycopg3 uses psycopg.types.json.Jsondiff --git a/tests/vector_stores/test_pgvector.py b/tests/vector_stores/test_pgvector.pyindex 7a6e9f7c4..d3ac284bf 100644--- a/tests/vector_stores/test_pgvector.py+++ b/tests/vector_stores/test_pgvector.py@@ -2089,6 +2089,39 @@ class TestPGVector(unittest.TestCase):self.assertTrue(len(vector_update_calls) > 0)self.assertTrue(len(payload_update_calls) > 0)+ @patch('mem0.vector_stores.pgvector.PSYCOPG_VERSION', 3)+ @patch('mem0.vector_stores.pgvector.ConnectionPool')+ @patch.object(PGVector, '_get_cursor')+ def test_update_empty_payload_still_persisted(self, mock_get_cursor, mock_connection_pool):+ """Test that an empty dict payload is persisted (not skipped by truthiness)."""+ mock_pool = MagicMock()+ mock_connection_pool.return_value = mock_pool++ mock_get_cursor.return_value.__enter__.return_value = self.mock_cursor+ mock_get_cursor.return_value.__exit__.return_value = None++ self.mock_cursor.fetchall.return_value = []++ pgvector = PGVector(+ dbname="test_db",+ collection_name="test_collection",+ embedding_model_dims=3,+ user="test_user",+ password="test_pass",+ host="localhost",+ port=5432,+ diskann=False,+ hnsw=False,+ minconn=1,+ maxconn=4+ )++ pgvector.update("test-id", payload={})++ payload_update_calls = [call for call in self.mock_cursor.execute.call_args_list+ if "UPDATE" in str(call) and "SET payload" in str(call)]+ self.assertTrue(len(payload_update_calls) > 0, "Empty payload {} should still trigger UPDATE")+# Enhanced Tests for Connection String Handling@patch('mem0.vector_stores.pgvector.PSYCOPG_VERSION', 3)@patch('mem0.vector_stores.pgvector.ConnectionPool')