The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.
Python agentic-memoryagentic-memory-systemagentsaiai-agentschatgptgenaillmlong-term-memorymemorymemory-managementpythonragstate-management
[Bug fix] Fix history sequence in prompt (#1254)
Deshraj Yadav2f285ea00a5e
diff --git a/embedchain/config/llm/base.py b/embedchain/config/llm/base.pyindex ab4331e4c..3619b924d 100644--- a/embedchain/config/llm/base.py+++ b/embedchain/config/llm/base.py@@ -24,7 +24,8 @@ DEFAULT_PROMPT_WITH_HISTORY = """$context- History: $history+ History:+ $historyQuery: $querydiff --git a/embedchain/llm/base.py b/embedchain/llm/base.pyindex 1e002916f..6ae0e064d 100644--- a/embedchain/llm/base.py+++ b/embedchain/llm/base.py@@ -5,9 +5,7 @@ from typing import Any, Optionalfrom langchain.schema import BaseMessage as LCBaseMessagefrom embedchain.config import BaseLlmConfig-from embedchain.config.llm.base import (DEFAULT_PROMPT,- DEFAULT_PROMPT_WITH_HISTORY_TEMPLATE,- DOCS_SITE_PROMPT_TEMPLATE)+from embedchain.config.llm.base import DEFAULT_PROMPT, DEFAULT_PROMPT_WITH_HISTORY_TEMPLATE, DOCS_SITE_PROMPT_TEMPLATEfrom embedchain.helpers.json_serializable import JSONSerializablefrom embedchain.memory.base import ChatHistoryfrom embedchain.memory.message import ChatMessage@@ -65,6 +63,14 @@ class BaseLlm(JSONSerializable):self.memory.add(app_id=app_id, chat_message=chat_message, session_id=session_id)self.update_history(app_id=app_id, session_id=session_id)+ def _format_history(self) -> str:+ """Format history to be used in prompt++ :return: Formatted history+ :rtype: str+ """+ return "\n".join(self.history)+def generate_prompt(self, input_query: str, contexts: list[str], **kwargs: dict[str, Any]) -> str:"""Generates a prompt based on the given query and context, ready to be@@ -84,10 +90,8 @@ class BaseLlm(JSONSerializable):prompt_contains_history = self.config._validate_prompt_history(self.config.prompt)if prompt_contains_history:- # Prompt contains history- # If there is no history yet, we insert `- no history -`prompt = self.config.prompt.substitute(- context=context_string, query=input_query, history=self.history or "- no history -"+ context=context_string, query=input_query, history=self._format_history() or "No history")elif self.history and not prompt_contains_history:# History is present, but not included in the prompt.@@ -98,7 +102,7 @@ class BaseLlm(JSONSerializable):):# swap in the template with historyprompt = DEFAULT_PROMPT_WITH_HISTORY_TEMPLATE.substitute(- context=context_string, query=input_query, history=self.history+ context=context_string, query=input_query, history=self._format_history())else:# If we can't swap in the default, we still proceed but tell users that the history is ignored.diff --git a/embedchain/llm/openai.py b/embedchain/llm/openai.pyindex 639ec9195..40f750c0b 100644--- a/embedchain/llm/openai.py+++ b/embedchain/llm/openai.py@@ -35,21 +35,19 @@ class OpenAILlm(BaseLlm):if config.top_p:kwargs["model_kwargs"]["top_p"] = config.top_pif config.stream:- from langchain.callbacks.streaming_stdout import \- StreamingStdOutCallbackHandler+ from langchain.callbacks.streaming_stdout import StreamingStdOutCallbackHandlercallbacks = config.callbacks if config.callbacks else [StreamingStdOutCallbackHandler()]- chat = ChatOpenAI(**kwargs, streaming=config.stream, callbacks=callbacks, api_key=api_key)+ llm = ChatOpenAI(**kwargs, streaming=config.stream, callbacks=callbacks, api_key=api_key)else:- chat = ChatOpenAI(**kwargs, api_key=api_key)+ llm = ChatOpenAI(**kwargs, api_key=api_key)if self.functions is not None:- from langchain.chains.openai_functions import \- create_openai_fn_runnable+ from langchain.chains.openai_functions import create_openai_fn_runnablefrom langchain.prompts import ChatPromptTemplatestructured_prompt = ChatPromptTemplate.from_messages(messages)- runnable = create_openai_fn_runnable(functions=self.functions, prompt=structured_prompt, llm=chat)+ runnable = create_openai_fn_runnable(functions=self.functions, prompt=structured_prompt, llm=llm)fn_res = runnable.invoke({"input": prompt,@@ -57,4 +55,4 @@ class OpenAILlm(BaseLlm):)messages.append(AIMessage(content=json.dumps(fn_res)))- return chat(messages).content+ return llm(messages).contentdiff --git a/embedchain/memory/base.py b/embedchain/memory/base.pyindex 378ad4799..75780efb8 100644--- a/embedchain/memory/base.py+++ b/embedchain/memory/base.py@@ -92,12 +92,12 @@ class ChatHistory:"""if fetch_all:- additional_query = "ORDER BY created_at DESC"+ additional_query = "ORDER BY created_at ASC"params = (app_id,)else:additional_query = """AND session_id=?- ORDER BY created_at DESC+ ORDER BY created_at ASCLIMIT ?"""params = (app_id, session_id, num_rounds)diff --git a/pyproject.toml b/pyproject.tomlindex 2c93221cf..00142127a 100644--- a/pyproject.toml+++ b/pyproject.toml@@ -1,6 +1,6 @@[tool.poetry]name = "embedchain"-version = "0.1.76"+version = "0.1.77"description = "Simplest open source retrieval(RAG) framework"authors = ["Taranjeet Singh <[email protected]>",