Skip to content

armgit / mem0

Public Imported from GitHub
0

The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.

fix(core): don't require langchain-core for default async procedural memory (#6209)

Abhay Singh44bcfbe1f36f
diff --git a/mem0/memory/main.py b/mem0/memory/main.py
index fa3829e3d..b2d27f32c 100644
--- a/mem0/memory/main.py
+++ b/mem0/memory/main.py
@@ -3585,16 +3585,6 @@ class AsyncMemory(MemoryBase):
llm (llm, optional): LLM to use for the procedural memory creation. Defaults to None.
prompt (str, optional): Prompt to use for the procedural memory creation. Defaults to None.
"""
- try:
- from langchain_core.messages.utils import (
- convert_to_messages, # type: ignore
- )
- except Exception:
- logger.error(
- "Import error while loading langchain-core. Please install 'langchain-core' to use procedural memory."
- )
- raise
-
logger.info("Creating procedural memory")
parsed_messages = [
@@ -3605,6 +3595,19 @@ class AsyncMemory(MemoryBase):
try:
if llm is not None:
+ # langchain-core is only needed to adapt messages for a custom
+ # LangChain LLM. The default path uses self.llm and must not
+ # require the optional dependency, mirroring the sync version.
+ try:
+ from langchain_core.messages.utils import (
+ convert_to_messages, # type: ignore
+ )
+ except ImportError as e:
+ raise ImportError(
+ "langchain-core is required to pass a custom LLM to procedural memory. "
+ "Install it with 'pip install langchain-core'."
+ ) from e
+
parsed_messages = convert_to_messages(parsed_messages)
response = await asyncio.to_thread(llm.invoke, input=parsed_messages)
procedural_memory = remove_code_blocks(response.content)
diff --git a/tests/test_memory.py b/tests/test_memory.py
index 551acef5a..5874fcf3f 100644
--- a/tests/test_memory.py
+++ b/tests/test_memory.py
@@ -1,6 +1,7 @@
import json
+import sys
from datetime import datetime
-from unittest.mock import MagicMock, patch
+from unittest.mock import MagicMock, Mock, patch
import pytest
@@ -1529,3 +1530,43 @@ async def test_async_procedural_memory_langchain_strips_code_blocks(mock_llm_fac
insert_call = memory.vector_store.insert.call_args
stored_data = insert_call[1]["payloads"][0]["data"]
assert "```" not in stored_data
+
+
+@patch("mem0.memory.main.VectorStoreFactory")
+@patch("mem0.memory.main.EmbedderFactory")
+@patch("mem0.memory.main.LlmFactory")
+async def test_async_procedural_memory_default_path_without_langchain(mock_llm_factory, mock_emb, mock_vs):
+ """Async procedural memory must not require langchain-core on the default
+ (llm=None) path, which uses self.llm and never calls convert_to_messages.
+ The sync path already works without it; this keeps the async path in parity.
+ """
+ mock_vs.return_value = MagicMock()
+ mock_emb.return_value = MagicMock()
+ mock_emb.return_value.embed.return_value = [0.1] * 1536
+ mock_llm_factory.return_value = MagicMock()
+
+ from mem0.memory.main import AsyncMemory
+
+ config = MemoryConfig()
+ memory = AsyncMemory(config)
+ memory.vector_store = MagicMock()
+ memory.vector_store.insert = MagicMock()
+ memory.embedding_model.embed = Mock(return_value=[0.1] * 1536)
+ memory.llm.generate_response = Mock(return_value="- deploy with the release script")
+
+ messages = [{"role": "user", "content": "how do we deploy"}]
+
+ # Simulate langchain-core being unavailable; the default path must still work.
+ with patch.dict(
+ sys.modules,
+ {
+ "langchain_core": None,
+ "langchain_core.messages": None,
+ "langchain_core.messages.utils": None,
+ },
+ ):
+ result = await memory._create_procedural_memory(messages, metadata={"agent_id": "agent_1"})
+
+ assert result["results"][0]["event"] == "ADD"
+ memory.llm.generate_response.assert_called_once()