The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.
Python agentic-memoryagentic-memory-systemagentsaiai-agentschatgptgenaillmlong-term-memorymemorymemory-managementpythonragstate-management
fix(elasticsearch): validate filter keys and values to prevent term injection (#5980)
Hrushikesh Yadav59484f066f9b
diff --git a/mem0/vector_stores/elasticsearch.py b/mem0/vector_stores/elasticsearch.pyindex 687336ba2..96e520236 100644--- a/mem0/vector_stores/elasticsearch.py+++ b/mem0/vector_stores/elasticsearch.py@@ -1,4 +1,5 @@import logging+import refrom typing import Any, Dict, List, Optionaltry:@@ -21,6 +22,19 @@ class OutputData(BaseModel):payload: Dict+_SAFE_FILTER_KEY = re.compile(r"^[a-zA-Z_][a-zA-Z0-9_]*$")+++def _validate_filter(key: str, value: Any) -> None:+ if not isinstance(key, str) or not _SAFE_FILTER_KEY.match(key):+ raise ValueError(f"Invalid filter key: {key!r}")+ if not isinstance(value, (str, int, float, bool)):+ raise ValueError(+ f"Filter value for {key!r} must be str, int, float, or bool, "+ f"got {type(value).__name__}"+ )++class ElasticsearchDB(VectorStoreBase):def __init__(self, **kwargs):config = ElasticsearchConfig(**kwargs)@@ -154,6 +168,7 @@ class ElasticsearchDB(VectorStoreBase):if filters:filter_conditions = []for key, value in filters.items():+ _validate_filter(key, value)filter_conditions.append({"term": {f"metadata.{key}": value}})search_query["knn"]["filter"] = {"bool": {"must": filter_conditions}}@@ -192,6 +207,7 @@ class ElasticsearchDB(VectorStoreBase):if filters:filter_conditions = []for key, value in filters.items():+ _validate_filter(key, value)filter_conditions.append({"term": {f"metadata.{key}": value}})bool_query["filter"] = filter_conditions@@ -262,6 +278,7 @@ class ElasticsearchDB(VectorStoreBase):if filters:filter_conditions = []for key, value in filters.items():+ _validate_filter(key, value)filter_conditions.append({"term": {f"metadata.{key}": value}})query["query"] = {"bool": {"must": filter_conditions}}diff --git a/tests/vector_stores/test_elasticsearch.py b/tests/vector_stores/test_elasticsearch.pyindex 2d92d6da8..a537ccd6a 100644--- a/tests/vector_stores/test_elasticsearch.py+++ b/tests/vector_stores/test_elasticsearch.py@@ -10,7 +10,7 @@ except ImportError:raise ImportError("Elasticsearch requires extra dependencies. Install with `pip install elasticsearch`") from Nonefrom mem0.configs.vector_stores.elasticsearch import ElasticsearchConfig-from mem0.vector_stores.elasticsearch import ElasticsearchDB, OutputData+from mem0.vector_stores.elasticsearch import ElasticsearchDB, OutputData, _validate_filterclass TestElasticsearchDB(unittest.TestCase):@@ -360,3 +360,33 @@ class TestElasticsearchDB(unittest.TestCase):with self.assertRaises(ValueError):config = {**base_config, "headers": headers}ElasticsearchConfig(**config)++ def test_filter_rejects_dict_value(self):+ with self.assertRaises(ValueError):+ _validate_filter("user_id", {"value": "alice", "boost": 0})++ def test_filter_rejects_list_value(self):+ with self.assertRaises(ValueError):+ _validate_filter("user_id", ["alice", "bob"])++ def test_filter_rejects_invalid_key(self):+ with self.assertRaises(ValueError):+ _validate_filter("user_id; DROP", "alice")++ def test_filter_accepts_scalar_values(self):+ _validate_filter("user_id", "alice")+ _validate_filter("count", 42)+ _validate_filter("score", 0.95)+ _validate_filter("active", True)++ def test_search_with_dict_filter_raises(self):+ with self.assertRaises(ValueError):+ self.es_db.search(+ query="test",+ vectors=[0.1] * 1536,+ filters={"user_id": {"value": "*", "case_insensitive": True}},+ )++ def test_list_with_dict_filter_raises(self):+ with self.assertRaises(ValueError):+ self.es_db.list(filters={"user_id": {"$ne": ""}})