The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.
Python agentic-memoryagentic-memory-systemagentsaiai-agentschatgptgenaillmlong-term-memorymemorymemory-managementpythonragstate-management
fix(openai): make store opt-in so it stops leaking to non-OpenAI backends (#4757)
Yunsu7b395f3bf70b
diff --git a/mem0/configs/llms/openai.py b/mem0/configs/llms/openai.pyindex f6cf4365b..a65a1de83 100644--- a/mem0/configs/llms/openai.py+++ b/mem0/configs/llms/openai.py@@ -29,7 +29,7 @@ class OpenAIConfig(BaseLlmConfig):openrouter_base_url: Optional[str] = None,site_url: Optional[str] = None,app_name: Optional[str] = None,- store: bool = False,+ store: Optional[bool] = None,# Response monitoring callbackresponse_callback: Optional[Callable[[Any, dict, dict], None]] = None,):@@ -53,6 +53,11 @@ class OpenAIConfig(BaseLlmConfig):openrouter_base_url: OpenRouter base URL, defaults to Nonesite_url: Site URL for OpenRouter, defaults to Noneapp_name: Application name for OpenRouter, defaults to None+ store: Whether to store the conversation on OpenAI's server. Opt-in;+ defaults to None (not sent). Set to True or False only if you+ want the value forwarded to the OpenAI API. Leaving it None+ avoids leaking the field into OpenAI-compatible backends that+ reject unknown fields (Gemini, Groq, vLLM, etc.).response_callback: Optional callback for monitoring LLM responses."""# Initialize base parametersdiff --git a/mem0/llms/openai.py b/mem0/llms/openai.pyindex fa011d9cb..b0b39fc87 100644--- a/mem0/llms/openai.py+++ b/mem0/llms/openai.py@@ -126,11 +126,12 @@ class OpenAILLM(LLMBase):params.update(**openrouter_params)else:- openai_specific_generation_params = ["store"]- for param in openai_specific_generation_params:- if hasattr(self.config, param):- params[param] = getattr(self.config, param)-+ # Only send OpenAI-specific parameters when the user has explicitly+ # configured them. OpenAI-compatible backends (Gemini, Groq, vLLM, etc.)+ # reject unknown fields, so `store` must be opt-in, not opt-out.+ if self.config.store is not None:+ params["store"] = self.config.store+if response_format:params["response_format"] = response_formatif tools: # TODO: Remove tools if no issues found with new memory addition logicdiff --git a/tests/llms/test_openai.py b/tests/llms/test_openai.pyindex 971244ea8..8059a2554 100644--- a/tests/llms/test_openai.py+++ b/tests/llms/test_openai.py@@ -55,7 +55,7 @@ def test_generate_response_without_tools(mock_openai_client):response = llm.generate_response(messages)mock_openai_client.chat.completions.create.assert_called_once_with(- model="gpt-4.1-nano-2025-04-14", messages=messages, temperature=0.7, max_tokens=100, top_p=1.0, store=False+ model="gpt-4.1-nano-2025-04-14", messages=messages, temperature=0.7, max_tokens=100, top_p=1.0)assert response == "I'm doing well, thank you for asking!"@@ -97,7 +97,7 @@ def test_generate_response_with_tools(mock_openai_client):response = llm.generate_response(messages, tools=tools)mock_openai_client.chat.completions.create.assert_called_once_with(- model="gpt-4.1-nano-2025-04-14", messages=messages, temperature=0.7, max_tokens=100, top_p=1.0, tools=tools, tool_choice="auto", store=False+ model="gpt-4.1-nano-2025-04-14", messages=messages, temperature=0.7, max_tokens=100, top_p=1.0, tools=tools, tool_choice="auto")assert response["content"] == "I've added the memory for you."@@ -231,6 +231,60 @@ def test_reasoning_effort_config_values():assert config.reasoning_effort is None+def test_store_not_sent_by_default(mock_openai_client):+ """`store` must NOT be injected into requests when the user has not+ explicitly configured it. Regression test for issue #4709, where+ `store=False` was unconditionally sent and rejected by OpenAI-compatible+ backends such as Google Gemini."""+ config = OpenAIConfig(model="gpt-4.1-nano-2025-04-14", temperature=0.1)+ assert config.store is None # new opt-in default+ llm = OpenAILLM(config)+ messages = [{"role": "user", "content": "Hello"}]++ mock_response = Mock()+ mock_response.choices = [Mock(message=Mock(content="Response"))]+ mock_openai_client.chat.completions.create.return_value = mock_response++ llm.generate_response(messages)++ call_kwargs = mock_openai_client.chat.completions.create.call_args.kwargs+ assert "store" not in call_kwargs+++def test_store_sent_when_explicitly_true(mock_openai_client):+ """When the user explicitly sets `store=True`, the field must be forwarded."""+ config = OpenAIConfig(model="gpt-4.1-nano-2025-04-14", store=True)+ llm = OpenAILLM(config)+ messages = [{"role": "user", "content": "Hello"}]++ mock_response = Mock()+ mock_response.choices = [Mock(message=Mock(content="Response"))]+ mock_openai_client.chat.completions.create.return_value = mock_response++ llm.generate_response(messages)++ call_kwargs = mock_openai_client.chat.completions.create.call_args.kwargs+ assert call_kwargs["store"] is True+++def test_store_sent_when_explicitly_false(mock_openai_client):+ """When the user explicitly sets `store=False`, the field must still be+ forwarded — explicit opt-out is a valid configuration for users who rely on+ it for OpenAI's zero-data-retention behavior."""+ config = OpenAIConfig(model="gpt-4.1-nano-2025-04-14", store=False)+ llm = OpenAILLM(config)+ messages = [{"role": "user", "content": "Hello"}]++ mock_response = Mock()+ mock_response.choices = [Mock(message=Mock(content="Response"))]+ mock_openai_client.chat.completions.create.return_value = mock_response++ llm.generate_response(messages)++ call_kwargs = mock_openai_client.chat.completions.create.call_args.kwargs+ assert call_kwargs["store"] is False++def test_callback_with_tools(mock_openai_client):mock_callback = Mock()config = OpenAIConfig(model="gpt-4.1-nano-2025-04-14", response_callback=mock_callback)