Skip to content

armgit / mem0

Public Imported from GitHub
0

The Memory Layer for AI Agents - Drop-in memory infrastructure for AI agents and apps. Context that persists. Built for production.

fix(oss): OllamaLLM now respects configured url instead of always falling back to localhost (#4320)

Kartikb4b73deada1b
diff --git a/mem0-ts/src/oss/src/config/manager.ts b/mem0-ts/src/oss/src/config/manager.ts
index c7c5a0c94..1ef692ed4 100644
--- a/mem0-ts/src/oss/src/config/manager.ts
+++ b/mem0-ts/src/oss/src/config/manager.ts
@@ -93,6 +93,7 @@ export class ConfigManager {
return {
baseURL: userConf?.baseURL || defaultConf.baseURL,
+ url: userConf?.url,
apiKey:
userConf?.apiKey !== undefined
? userConf.apiKey
diff --git a/mem0-ts/src/oss/src/embeddings/ollama.ts b/mem0-ts/src/oss/src/embeddings/ollama.ts
index 1bafbeaa9..348f6cf98 100644
--- a/mem0-ts/src/oss/src/embeddings/ollama.ts
+++ b/mem0-ts/src/oss/src/embeddings/ollama.ts
@@ -12,7 +12,7 @@ export class OllamaEmbedder implements Embedder {
constructor(config: EmbeddingConfig) {
this.ollama = new Ollama({
- host: config.url || "http://localhost:11434",
+ host: config.url || config.baseURL || "http://localhost:11434",
});
this.model = config.model || "nomic-embed-text:latest";
this.embeddingDims = config.embeddingDims || 768;
diff --git a/mem0-ts/src/oss/src/llms/ollama.ts b/mem0-ts/src/oss/src/llms/ollama.ts
index 11f543ed0..987262731 100644
--- a/mem0-ts/src/oss/src/llms/ollama.ts
+++ b/mem0-ts/src/oss/src/llms/ollama.ts
@@ -11,7 +11,7 @@ export class OllamaLLM implements LLM {
constructor(config: LLMConfig) {
this.ollama = new Ollama({
- host: config.config?.url || "http://localhost:11434",
+ host: config.url || config.baseURL || "http://localhost:11434",
});
this.model = config.model || "llama3.1:8b";
this.ensureModelExists().catch((err) => {
diff --git a/mem0-ts/src/oss/src/types/index.ts b/mem0-ts/src/oss/src/types/index.ts
index 147c46517..58bfb544d 100644
--- a/mem0-ts/src/oss/src/types/index.ts
+++ b/mem0-ts/src/oss/src/types/index.ts
@@ -43,6 +43,7 @@ export interface HistoryStoreConfig {
export interface LLMConfig {
provider?: string;
baseURL?: string;
+ url?: string;
config?: Record<string, any>;
apiKey?: string;
model?: string | any;
@@ -143,6 +144,7 @@ export const MemoryConfigSchema = z.object({
model: z.union([z.string(), z.any()]).optional(),
modelProperties: z.record(z.string(), z.any()).optional(),
baseURL: z.string().optional(),
+ url: z.string().optional(),
}),
}),
historyDbPath: z.string().optional(),
diff --git a/mem0-ts/src/oss/tests/config-manager.test.ts b/mem0-ts/src/oss/tests/config-manager.test.ts
index 9d5fb8406..1adba20a7 100644
--- a/mem0-ts/src/oss/tests/config-manager.test.ts
+++ b/mem0-ts/src/oss/tests/config-manager.test.ts
@@ -85,4 +85,80 @@ describe("ConfigManager", () => {
expect(config.vectorStore.config.dimension).toBe(768);
});
});
+
+ describe("mergeConfig - LLM url passthrough for Ollama", () => {
+ const baseEmbedder = {
+ provider: "openai",
+ config: { apiKey: "test-key" },
+ };
+ const baseVectorStore = {
+ provider: "memory",
+ config: { collectionName: "test" },
+ };
+
+ it("should preserve url in LLM config when provided", () => {
+ const config = ConfigManager.mergeConfig({
+ embedder: baseEmbedder,
+ vectorStore: baseVectorStore,
+ llm: {
+ provider: "ollama",
+ config: { model: "llama3.2:3b", url: "http://10.0.0.100:11434" },
+ },
+ });
+
+ expect(config.llm.config.url).toBe("http://10.0.0.100:11434");
+ });
+
+ it("should prefer baseURL over url when both are provided", () => {
+ const config = ConfigManager.mergeConfig({
+ embedder: baseEmbedder,
+ vectorStore: baseVectorStore,
+ llm: {
+ provider: "ollama",
+ config: {
+ model: "llama3.2:3b",
+ baseURL: "http://custom:11434",
+ url: "http://fallback:11434",
+ },
+ },
+ });
+
+ expect(config.llm.config.baseURL).toBe("http://custom:11434");
+ expect(config.llm.config.url).toBe("http://fallback:11434");
+ });
+
+ it("should use default baseURL when no url or baseURL provided", () => {
+ const config = ConfigManager.mergeConfig({
+ embedder: baseEmbedder,
+ vectorStore: baseVectorStore,
+ llm: {
+ provider: "ollama",
+ config: { model: "llama3.2:3b" },
+ },
+ });
+
+ expect(config.llm.config.url).toBeUndefined();
+ expect(config.llm.config.baseURL).toBe("https://api.openai.com/v1");
+ });
+
+ it("should preserve url in embedder config (existing behavior)", () => {
+ const config = ConfigManager.mergeConfig({
+ embedder: {
+ provider: "ollama",
+ config: {
+ model: "nomic-embed-text",
+ url: "http://10.0.0.100:11434",
+ },
+ },
+ vectorStore: baseVectorStore,
+ llm: {
+ provider: "ollama",
+ config: { model: "llama3.2:3b", url: "http://10.0.0.100:11434" },
+ },
+ });
+
+ expect(config.embedder.config.url).toBe("http://10.0.0.100:11434");
+ expect(config.llm.config.url).toBe("http://10.0.0.100:11434");
+ });
+ });
});