Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

5.4 KB
Raw Blame
package test

import (
	"context"
	"testing"

	"github.com/stretchr/testify/require"
	"google.golang.org/grpc/codes"
	"google.golang.org/grpc/status"
	"google.golang.org/protobuf/types/known/fieldmaskpb"

	apipb "github.com/usememos/memos/proto/gen/api"
	"github.com/usememos/memos/store"
)

func TestMoveMemoPreservesIndependentConversation(t *testing.T) {
	ctx := context.Background()
	ts := NewTestService(t)
	defer ts.Cleanup()
	author, err := ts.CreateRegularUser(ctx, "move-author")
	require.NoError(t, err)
	commenter, err := ts.CreateRegularUser(ctx, "move-commenter")
	require.NoError(t, err)
	reader, err := ts.CreateRegularUser(ctx, "move-reader")
	require.NoError(t, err)
	authorCtx := ts.CreateUserContext(ctx, author.ID)
	commenterCtx := ts.CreateUserContext(ctx, commenter.ID)
	readerCtx := ts.CreateUserContext(ctx, reader.ID)
	source, err := ts.Store.CreateSpace(ctx, &store.Space{UID: "move-source", Title: "Source"}, author.ID)
	require.NoError(t, err)
	target, err := ts.Store.CreateSpace(ctx, &store.Space{UID: "move-target", Title: "Target"}, author.ID)
	require.NoError(t, err)
	for _, member := range []*store.SpaceMember{
		{SpaceID: source.ID, UserID: commenter.ID, Role: store.SpaceMemberRoleUser},
		{SpaceID: target.ID, UserID: reader.ID, Role: store.SpaceMemberRoleUser},
	} {
		_, err := ts.InviteAndAcceptSpaceMember(ctx, member, author.ID)
		require.NoError(t, err)
	}
	sourceName, targetName := "spaces/"+source.UID, "spaces/"+target.UID
	reference, err := ts.Service.CreateMemo(authorCtx, &apipb.CreateMemoRequest{Memo: &apipb.Memo{
		Content: "source reference", Space: &sourceName, Visibility: apipb.Visibility_SPACE,
	}})
	require.NoError(t, err)
	attachment, err := ts.Service.CreateAttachment(authorCtx, &apipb.CreateAttachmentRequest{
		Attachment: &apipb.Attachment{Filename: "proposal.txt", Type: "text/plain", Content: []byte("proposal attachment")},
	})
	require.NoError(t, err)
	original, err := ts.Service.CreateMemo(authorCtx, &apipb.CreateMemoRequest{Memo: &apipb.Memo{
		Content: "original memo", Space: &sourceName, Visibility: apipb.Visibility_SPACE,
		Attachments: []*apipb.Attachment{attachment},
		Relations:   []*apipb.MemoRelation{{Type: apipb.MemoRelation_REFERENCE, RelatedMemo: &apipb.MemoRelation_MemoRef{Name: reference.Name}}},
	}})
	require.NoError(t, err)
	comment, err := ts.Service.CreateMemoComment(commenterCtx, &apipb.CreateMemoCommentRequest{
		Parent: original.Name, Comment: &apipb.Memo{Content: "source comment", Space: &sourceName, Visibility: apipb.Visibility_SPACE},
	})
	require.NoError(t, err)
	reaction, err := ts.Service.UpsertMemoReaction(commenterCtx, &apipb.UpsertMemoReactionRequest{
		Parent: original.Name, Reaction: &apipb.Reaction{ReactionType: "πŸ‘"},
	})
	require.NoError(t, err)

	moved, err := ts.Service.UpdateMemo(authorCtx, &apipb.UpdateMemoRequest{
		Memo:       &apipb.Memo{Name: original.Name, Space: &targetName, Visibility: apipb.Visibility_SPACE},
		UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"space", "visibility"}},
	})
	require.NoError(t, err)
	require.Equal(t, original.Name, moved.Name)
	require.Equal(t, original.Creator, moved.Creator)
	require.Equal(t, original.CreateTime, moved.CreateTime)
	require.Equal(t, original.UpdateTime, moved.UpdateTime)
	require.Equal(t, original.Content, moved.Content)
	require.Len(t, moved.Attachments, 1)
	require.Equal(t, original.Attachments, moved.Attachments)
	require.Len(t, moved.Relations, 2, "the author in both Spaces retains references and comments")
	require.Len(t, moved.Reactions, 1)
	require.Equal(t, reaction.Name, moved.Reactions[0].Name)

	_, err = ts.Service.GetMemo(commenterCtx, &apipb.GetMemoRequest{Name: original.Name})
	require.Equal(t, codes.PermissionDenied, status.Code(err))
	readableComment, err := ts.Service.GetMemo(commenterCtx, &apipb.GetMemoRequest{Name: comment.Name})
	require.NoError(t, err)
	require.Equal(t, original.Name, readableComment.GetParent(), "parent identity survives lost parent access")
	require.Equal(t, sourceName, readableComment.GetSpace())
	require.Equal(t, comment.Visibility, readableComment.Visibility)
	require.Equal(t, comment.Content, readableComment.Content)
	require.Empty(t, readableComment.Relations, "the inaccessible parent must not appear in relation previews")

	for _, viewer := range []context.Context{authorCtx, readerCtx} {
		comments, err := ts.Service.ListMemoComments(viewer, &apipb.ListMemoCommentsRequest{Parent: original.Name})
		require.NoError(t, err)
		if viewer == authorCtx {
			require.Len(t, comments.Comments, 1)
		} else {
			require.Empty(t, comments.Comments)
		}
	}
	destinationMemo, err := ts.Service.GetMemo(readerCtx, &apipb.GetMemoRequest{Name: original.Name})
	require.NoError(t, err)
	require.Empty(t, destinationMemo.Relations)
	require.Len(t, destinationMemo.Reactions, 1, "existing reactions are visible to new readers")
	_, err = ts.Service.GetMemo(readerCtx, &apipb.GetMemoRequest{Name: comment.Name})
	require.Equal(t, codes.PermissionDenied, status.Code(err))
	_, err = ts.Service.DeleteMemoReaction(readerCtx, &apipb.DeleteMemoReactionRequest{Name: reaction.Name})
	require.Equal(t, codes.PermissionDenied, status.Code(err))
	_, err = ts.Service.DeleteMemoReaction(commenterCtx, &apipb.DeleteMemoReactionRequest{Name: reaction.Name})
	require.NoError(t, err, "the creator can withdraw a reaction without parent access")
	reactions, err := ts.Service.ListMemoReactions(readerCtx, &apipb.ListMemoReactionsRequest{Parent: original.Name})
	require.NoError(t, err)
	require.Empty(t, reactions.Reactions)
}