Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

11.5 KB
Raw Blame
package test

import (
	"context"
	"fmt"
	"sync"
	"testing"

	"github.com/stretchr/testify/require"
	"google.golang.org/protobuf/types/known/fieldmaskpb"

	apipb "github.com/usememos/memos/proto/gen/api"
	storepb "github.com/usememos/memos/proto/gen/store"
	"github.com/usememos/memos/server/api"
	"github.com/usememos/memos/store"
)

func TestCreateUserRegistration(t *testing.T) {
	ctx := context.Background()

	t.Run("CreateUser success when registration enabled", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// User registration is enabled by default, no need to set it explicitly

		// Create user without authentication - should succeed
		_, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "password123",
			},
		})
		require.NoError(t, err)
	})

	t.Run("CreateUser blocked when registration disabled", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// Create a host user first so we're not in first-user setup mode
		_, err := ts.CreateHostUser(ctx, "admin")
		require.NoError(t, err)

		// Disable user registration
		_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
			Key: storepb.InstanceSettingKey_GENERAL,
			Value: &storepb.InstanceSetting_GeneralSetting{
				GeneralSetting: &storepb.InstanceGeneralSetting{
					DisallowUserRegistration: true,
				},
			},
		})
		require.NoError(t, err)

		// Try to create user without authentication - should fail
		_, err = ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "password123",
			},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "not allowed")
	})

	t.Run("CreateUser succeeds for superuser even when registration disabled", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// Create host user
		hostUser, err := ts.CreateHostUser(ctx, "admin")
		require.NoError(t, err)
		hostCtx := ts.CreateUserContext(ctx, hostUser.ID)

		// Disable user registration
		_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
			Key: storepb.InstanceSettingKey_GENERAL,
			Value: &storepb.InstanceSetting_GeneralSetting{
				GeneralSetting: &storepb.InstanceGeneralSetting{
					DisallowUserRegistration: true,
				},
			},
		})
		require.NoError(t, err)

		// Host user can create users even when registration is disabled - should succeed
		_, err = ts.Service.CreateUser(hostCtx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "password123",
			},
		})
		require.NoError(t, err)
	})

	t.Run("CreateUser regular user cannot create users when registration disabled", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// Create regular user
		regularUser, err := ts.CreateRegularUser(ctx, "regularuser")
		require.NoError(t, err)
		regularUserCtx := ts.CreateUserContext(ctx, regularUser.ID)

		// Disable user registration
		_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
			Key: storepb.InstanceSettingKey_GENERAL,
			Value: &storepb.InstanceSetting_GeneralSetting{
				GeneralSetting: &storepb.InstanceGeneralSetting{
					DisallowUserRegistration: true,
				},
			},
		})
		require.NoError(t, err)

		// Regular user tries to create user when registration is disabled - should fail
		_, err = ts.Service.CreateUser(regularUserCtx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "password123",
			},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "not allowed")
	})

	t.Run("CreateUser host can assign roles", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// Create host user
		hostUser, err := ts.CreateHostUser(ctx, "admin")
		require.NoError(t, err)
		hostCtx := ts.CreateUserContext(ctx, hostUser.ID)

		// Host user can create user with specific role - should succeed
		createdUser, err := ts.Service.CreateUser(hostCtx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newadmin",
				Email:    "[email protected]",
				Password: "password123",
				Role:     apipb.User_ADMIN,
			},
		})
		require.NoError(t, err)
		require.Equal(t, "users/newadmin", createdUser.Name)
		require.NotNil(t, createdUser)
		require.Equal(t, apipb.User_ADMIN, createdUser.Role)
	})

	t.Run("CreateUser unauthenticated user can only create regular user", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		// Create a host user first so we're not in first-user setup mode
		_, err := ts.CreateHostUser(ctx, "admin")
		require.NoError(t, err)

		// User registration is enabled by default

		// Unauthenticated user tries to create admin user - role should be ignored
		createdUser, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "wannabeadmin",
				Email:    "[email protected]",
				Password: "password123",
				Role:     apipb.User_ADMIN, // This should be ignored
			},
		})
		require.NoError(t, err)
		require.NotNil(t, createdUser)
		require.Equal(t, "users/wannabeadmin", createdUser.Name)
		require.Equal(t, apipb.User_USER, createdUser.Role, "Unauthenticated users can only create USER role")
	})

	t.Run("CreateUser blocked when password auth disabled for self signup", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		_, err := ts.CreateHostUser(ctx, "admin")
		require.NoError(t, err)

		_, err = ts.Store.UpsertInstanceSetting(ctx, &storepb.InstanceSetting{
			Key: storepb.InstanceSettingKey_GENERAL,
			Value: &storepb.InstanceSetting_GeneralSetting{
				GeneralSetting: &storepb.InstanceGeneralSetting{
					DisallowPasswordAuth: true,
				},
			},
		})
		require.NoError(t, err)

		_, err = ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "password123",
			},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "password signup is not allowed")
	})

	t.Run("CreateUser rejects empty password", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		_, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "newuser",
				Email:    "[email protected]",
				Password: "",
			},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "password must not be empty")
	})

	t.Run("CreateUser rejects invalid writable usernames", func(t *testing.T) {
		for _, username := range []string{"[email protected]", "legacy_user"} {
			t.Run(username, func(t *testing.T) {
				ts := NewTestService(t)
				defer ts.Cleanup()

				_, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
					User: &apipb.User{
						Username: username,
						Email:    "[email protected]",
						Password: "password123",
					},
				})
				require.Error(t, err)
				require.Contains(t, err.Error(), "invalid username")
			})
		}
	})

	t.Run("CreateUser validate only rejects invalid writable username", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		_, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "[email protected]",
				Email:    "[email protected]",
				Password: "password123",
			},
			ValidateOnly: true,
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "invalid username")
	})

	t.Run("CreateUser requires user_id to match username", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		_, err := ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
			User: &apipb.User{
				Username: "alice",
				Email:    "[email protected]",
				Password: "password123",
			},
			UserId: "bob",
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "user_id must match user.username")
	})

	t.Run("UpdateUser rejects empty password", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		user, err := ts.CreateRegularUser(ctx, "alice")
		require.NoError(t, err)

		authCtx := ts.CreateUserContext(ctx, user.ID)
		_, err = ts.Service.UpdateUser(authCtx, &apipb.UpdateUserRequest{
			User: &apipb.User{
				Name:     api.BuildUserName(user.Username),
				Password: "",
			},
			UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"password"}},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "password must not be empty")
	})

	t.Run("UpdateUser rejects missing user message", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		user, err := ts.CreateRegularUser(ctx, "missing-message")
		require.NoError(t, err)

		authCtx := ts.CreateUserContext(ctx, user.ID)
		_, err = ts.Service.UpdateUser(authCtx, &apipb.UpdateUserRequest{
			UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"display_name"}},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "user is required")
	})

	t.Run("CreateUser concurrent first setup creates one admin", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		const workers = 12
		var wg sync.WaitGroup
		for i := range workers {
			wg.Go(func() {
				_, _ = ts.Service.CreateUser(ctx, &apipb.CreateUserRequest{
					User: &apipb.User{
						Username: fmt.Sprintf("setup-user-%d", i),
						Email:    "[email protected]",
						Password: "password123",
					},
				})
			})
		}
		wg.Wait()

		users, err := ts.Store.ListUsers(ctx, &store.FindUser{})
		require.NoError(t, err)
		adminCount := 0
		for _, user := range users {
			if user.Role == store.RoleAdmin {
				adminCount++
			}
		}
		require.Equal(t, 1, adminCount)
	})

	t.Run("UpdateUser state requires admin", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		user, err := ts.CreateRegularUser(ctx, "state-user")
		require.NoError(t, err)
		userCtx := ts.CreateUserContext(ctx, user.ID)
		_, err = ts.Service.UpdateUser(userCtx, &apipb.UpdateUserRequest{
			User: &apipb.User{
				Name:  api.BuildUserName(user.Username),
				State: apipb.State_ARCHIVED,
			},
			UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"state"}},
		})
		require.Error(t, err)
		require.Contains(t, err.Error(), "permission denied")

		admin, err := ts.CreateHostUser(ctx, "state-admin")
		require.NoError(t, err)
		adminCtx := ts.CreateUserContext(ctx, admin.ID)
		updated, err := ts.Service.UpdateUser(adminCtx, &apipb.UpdateUserRequest{
			User: &apipb.User{
				Name:  api.BuildUserName(user.Username),
				State: apipb.State_ARCHIVED,
			},
			UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"state"}},
		})
		require.NoError(t, err)
		require.Equal(t, apipb.State_ARCHIVED, updated.State)
	})

	t.Run("archived user context is rejected", func(t *testing.T) {
		ts := NewTestService(t)
		defer ts.Cleanup()

		user, err := ts.CreateRegularUser(ctx, "archived-access-user")
		require.NoError(t, err)
		userCtx := ts.CreateUserContext(ctx, user.ID)
		archived := store.Archived
		_, err = ts.Store.UpdateUser(ctx, &store.UpdateUser{
			ID:        user.ID,
			RowStatus: &archived,
		})
		require.NoError(t, err)

		_, err = ts.Service.GetCurrentUser(userCtx, &apipb.GetCurrentUserRequest{})
		require.Error(t, err)

		_, err = ts.Service.CreateMemo(userCtx, &apipb.CreateMemoRequest{
			Memo: &apipb.Memo{
				Content: "should not be created",
			},
		})
		require.Error(t, err)

		_, err = ts.Service.UpdateUser(userCtx, &apipb.UpdateUserRequest{
			User: &apipb.User{
				Name:  api.BuildUserName(user.Username),
				State: apipb.State_NORMAL,
			},
			UpdateMask: &fieldmaskpb.FieldMask{Paths: []string{"state"}},
		})
		require.Error(t, err)
	})
}