Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

chore: remove redundant tests

Steven00f21b86e211
diff --git a/store/db/mysql/memo_filter_test.go b/store/db/mysql/memo_filter_test.go
deleted file mode 100644
index 748a426fe..000000000
--- a/store/db/mysql/memo_filter_test.go
+++ /dev/null
@@ -1,162 +0,0 @@
-package mysql
-
-import (
- "context"
- "testing"
- "time"
-
- "github.com/stretchr/testify/require"
-
- "github.com/usememos/memos/plugin/filter"
-)
-
-func TestConvertExprToSQL(t *testing.T) {
- tests := []struct {
- filter string
- want string
- args []any
- }{
- {
- filter: `tag in ["tag1", "tag2"]`,
- want: "((JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?) OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR (JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?) OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?))",
- args: []any{`"tag1"`, `%"tag1/%`, `"tag2"`, `%"tag2/%`},
- },
- {
- filter: `!(tag in ["tag1", "tag2"])`,
- want: "NOT (((JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?) OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR (JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?) OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?)))",
- args: []any{`"tag1"`, `%"tag1/%`, `"tag2"`, `%"tag2/%`},
- },
- {
- filter: `content.contains("memos")`,
- want: "`memo`.`content` LIKE ?",
- args: []any{"%memos%"},
- },
- {
- filter: `visibility in ["PUBLIC"]`,
- want: "`memo`.`visibility` IN (?)",
- args: []any{"PUBLIC"},
- },
- {
- filter: `visibility in ["PUBLIC", "PRIVATE"]`,
- want: "`memo`.`visibility` IN (?,?)",
- args: []any{"PUBLIC", "PRIVATE"},
- },
- {
- filter: `tag in ['tag1'] || content.contains('hello')`,
- want: "((JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?) OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR `memo`.`content` LIKE ?)",
- args: []any{`"tag1"`, `%"tag1/%`, "%hello%"},
- },
- {
- filter: `1`,
- want: "",
- args: []any{},
- },
- {
- filter: `pinned`,
- want: "`memo`.`pinned` IS TRUE",
- args: []any{},
- },
- {
- filter: `has_task_list`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_task_list == true`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_task_list != false`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) != CAST('false' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_task_list == false`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('false' AS JSON)",
- args: []any{},
- },
- {
- filter: `!has_task_list`,
- want: "NOT (COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('true' AS JSON))",
- args: []any{},
- },
- {
- filter: `has_task_list && pinned`,
- want: "(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('true' AS JSON) AND `memo`.`pinned` IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_task_list && content.contains("todo")`,
- want: "(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList'), CAST('false' AS JSON)) = CAST('true' AS JSON) AND `memo`.`content` LIKE ?)",
- args: []any{"%todo%"},
- },
- {
- filter: `created_ts > now() - 60 * 60 * 24`,
- want: "UNIX_TIMESTAMP(`memo`.`created_ts`) > ?",
- args: []any{time.Now().Unix() - 60*60*24},
- },
- {
- filter: `size(tags) == 0`,
- want: "JSON_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) = ?",
- args: []any{int64(0)},
- },
- {
- filter: `size(tags) > 0`,
- want: "JSON_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) > ?",
- args: []any{int64(0)},
- },
- {
- filter: `"work" in tags`,
- want: "JSON_CONTAINS(JSON_EXTRACT(`memo`.`payload`, '$.tags'), ?)",
- args: []any{`"work"`},
- },
- {
- filter: `size(tags) == 2`,
- want: "JSON_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) = ?",
- args: []any{int64(2)},
- },
- {
- filter: `has_link == true`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasLink'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_code == false`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasCode'), CAST('false' AS JSON)) = CAST('false' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_incomplete_tasks != false`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasIncompleteTasks'), CAST('false' AS JSON)) != CAST('false' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_link`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasLink'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_code`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasCode'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- {
- filter: `has_incomplete_tasks`,
- want: "COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.property.hasIncompleteTasks'), CAST('false' AS JSON)) = CAST('true' AS JSON)",
- args: []any{},
- },
- }
-
- engine, err := filter.DefaultEngine()
- require.NoError(t, err)
-
- for _, tt := range tests {
- stmt, err := engine.CompileToStatement(context.Background(), tt.filter, filter.RenderOptions{
- Dialect: filter.DialectMySQL,
- })
- require.NoError(t, err)
- require.Equal(t, tt.want, stmt.SQL)
- require.Equal(t, tt.args, stmt.Args)
- }
-}
diff --git a/store/db/postgres/memo_filter_test.go b/store/db/postgres/memo_filter_test.go
deleted file mode 100644
index b6ac67309..000000000
--- a/store/db/postgres/memo_filter_test.go
+++ /dev/null
@@ -1,160 +0,0 @@
-package postgres
-
-import (
- "context"
- "testing"
- "time"
-
- "github.com/stretchr/testify/require"
-
- "github.com/usememos/memos/plugin/filter"
-)
-
-func TestConvertExprToSQL(t *testing.T) {
- tests := []struct {
- filter string
- want string
- args []any
- }{
- {
- filter: `tag in ["tag1", "tag2"]`,
- want: "((memo.payload->'tags' @> jsonb_build_array($1::json) OR (memo.payload->'tags')::text LIKE $2) OR (memo.payload->'tags' @> jsonb_build_array($3::json) OR (memo.payload->'tags')::text LIKE $4))",
- args: []any{`"tag1"`, `%"tag1/%`, `"tag2"`, `%"tag2/%`},
- },
- {
- filter: `!(tag in ["tag1", "tag2"])`,
- want: "NOT (((memo.payload->'tags' @> jsonb_build_array($1::json) OR (memo.payload->'tags')::text LIKE $2) OR (memo.payload->'tags' @> jsonb_build_array($3::json) OR (memo.payload->'tags')::text LIKE $4)))",
- args: []any{`"tag1"`, `%"tag1/%`, `"tag2"`, `%"tag2/%`},
- },
- {
- filter: `content.contains("memos")`,
- want: "memo.content ILIKE $1",
- args: []any{"%memos%"},
- },
- {
- filter: `visibility in ["PUBLIC"]`,
- want: "memo.visibility IN ($1)",
- args: []any{"PUBLIC"},
- },
- {
- filter: `visibility in ["PUBLIC", "PRIVATE"]`,
- want: "memo.visibility IN ($1,$2)",
- args: []any{"PUBLIC", "PRIVATE"},
- },
- {
- filter: `tag in ['tag1'] || content.contains('hello')`,
- want: "((memo.payload->'tags' @> jsonb_build_array($1::json) OR (memo.payload->'tags')::text LIKE $2) OR memo.content ILIKE $3)",
- args: []any{`"tag1"`, `%"tag1/%`, "%hello%"},
- },
- {
- filter: `1`,
- want: "",
- args: []any{},
- },
- {
- filter: `pinned`,
- want: "memo.pinned IS TRUE",
- args: []any{},
- },
- {
- filter: `has_task_list`,
- want: "(memo.payload->'property'->>'hasTaskList')::boolean IS TRUE",
- args: []any{},
- },
- {
- filter: `has_task_list == true`,
- want: "(memo.payload->'property'->>'hasTaskList')::boolean = $1",
- args: []any{true},
- },
- {
- filter: `has_task_list != false`,
- want: "(memo.payload->'property'->>'hasTaskList')::boolean != $1",
- args: []any{false},
- },
- {
- filter: `has_task_list == false`,
- want: "(memo.payload->'property'->>'hasTaskList')::boolean = $1",
- args: []any{false},
- },
- {
- filter: `!has_task_list`,
- want: "NOT ((memo.payload->'property'->>'hasTaskList')::boolean IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_task_list && pinned`,
- want: "((memo.payload->'property'->>'hasTaskList')::boolean IS TRUE AND memo.pinned IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_task_list && content.contains("todo")`,
- want: "((memo.payload->'property'->>'hasTaskList')::boolean IS TRUE AND memo.content ILIKE $1)",
- args: []any{"%todo%"},
- },
- {
- filter: `created_ts > now() - 60 * 60 * 24`,
- want: "memo.created_ts > $1",
- args: []any{time.Now().Unix() - 60*60*24},
- },
- {
- filter: `size(tags) == 0`,
- want: "jsonb_array_length(COALESCE(memo.payload->'tags', '[]'::jsonb)) = $1",
- args: []any{int64(0)},
- },
- {
- filter: `size(tags) > 0`,
- want: "jsonb_array_length(COALESCE(memo.payload->'tags', '[]'::jsonb)) > $1",
- args: []any{int64(0)},
- },
- {
- filter: `"work" in tags`,
- want: "memo.payload->'tags' @> jsonb_build_array($1::json)",
- args: []any{`"work"`},
- },
- {
- filter: `size(tags) == 2`,
- want: "jsonb_array_length(COALESCE(memo.payload->'tags', '[]'::jsonb)) = $1",
- args: []any{int64(2)},
- },
- {
- filter: `has_link == true`,
- want: "(memo.payload->'property'->>'hasLink')::boolean = $1",
- args: []any{true},
- },
- {
- filter: `has_code == false`,
- want: "(memo.payload->'property'->>'hasCode')::boolean = $1",
- args: []any{false},
- },
- {
- filter: `has_incomplete_tasks != false`,
- want: "(memo.payload->'property'->>'hasIncompleteTasks')::boolean != $1",
- args: []any{false},
- },
- {
- filter: `has_link`,
- want: "(memo.payload->'property'->>'hasLink')::boolean IS TRUE",
- args: []any{},
- },
- {
- filter: `has_code`,
- want: "(memo.payload->'property'->>'hasCode')::boolean IS TRUE",
- args: []any{},
- },
- {
- filter: `has_incomplete_tasks`,
- want: "(memo.payload->'property'->>'hasIncompleteTasks')::boolean IS TRUE",
- args: []any{},
- },
- }
-
- engine, err := filter.DefaultEngine()
- require.NoError(t, err)
-
- for _, tt := range tests {
- stmt, err := engine.CompileToStatement(context.Background(), tt.filter, filter.RenderOptions{Dialect: filter.DialectPostgres})
- require.NoError(t, err)
- require.Equal(t, tt.want, stmt.SQL)
- require.Equal(t, tt.args, stmt.Args)
- }
-}
diff --git a/store/db/sqlite/memo_filter_test.go b/store/db/sqlite/memo_filter_test.go
deleted file mode 100644
index 70581b938..000000000
--- a/store/db/sqlite/memo_filter_test.go
+++ /dev/null
@@ -1,165 +0,0 @@
-package sqlite
-
-import (
- "context"
- "testing"
- "time"
-
- "github.com/stretchr/testify/require"
-
- "github.com/usememos/memos/plugin/filter"
-)
-
-func TestConvertExprToSQL(t *testing.T) {
- tests := []struct {
- filter string
- want string
- args []any
- }{
- {
- filter: `tag in ["tag1", "tag2"]`,
- want: "((JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ? OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR (JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ? OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?))",
- args: []any{`%"tag1"%`, `%"tag1/%`, `%"tag2"%`, `%"tag2/%`},
- },
- {
- filter: `!(tag in ["tag1", "tag2"])`,
- want: "NOT (((JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ? OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR (JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ? OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?)))",
- args: []any{`%"tag1"%`, `%"tag1/%`, `%"tag2"%`, `%"tag2/%`},
- },
- {
- filter: `content.contains("memos")`,
- want: "`memo`.`content` LIKE ?",
- args: []any{"%memos%"},
- },
- {
- filter: `visibility in ["PUBLIC"]`,
- want: "`memo`.`visibility` IN (?)",
- args: []any{"PUBLIC"},
- },
- {
- filter: `visibility in ["PUBLIC", "PRIVATE"]`,
- want: "`memo`.`visibility` IN (?,?)",
- args: []any{"PUBLIC", "PRIVATE"},
- },
- {
- filter: `tag in ['tag1'] || content.contains('hello')`,
- want: "((JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ? OR JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?) OR `memo`.`content` LIKE ?)",
- args: []any{`%"tag1"%`, `%"tag1/%`, "%hello%"},
- },
- {
- filter: `1`,
- want: "",
- args: []any{},
- },
- {
- filter: `pinned`,
- want: "`memo`.`pinned` IS TRUE",
- args: []any{},
- },
- {
- filter: `has_task_list`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_code`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasCode') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_task_list == true`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') = 1",
- args: []any{},
- },
- {
- filter: `has_task_list != false`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') != 0",
- args: []any{},
- },
- {
- filter: `has_task_list == false`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') = 0",
- args: []any{},
- },
- {
- filter: `!has_task_list`,
- want: "NOT (JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_task_list && pinned`,
- want: "(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') IS TRUE AND `memo`.`pinned` IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_task_list && content.contains("todo")`,
- want: "(JSON_EXTRACT(`memo`.`payload`, '$.property.hasTaskList') IS TRUE AND `memo`.`content` LIKE ?)",
- args: []any{"%todo%"},
- },
- {
- filter: `created_ts > now() - 60 * 60 * 24`,
- want: "`memo`.`created_ts` > ?",
- args: []any{time.Now().Unix() - 60*60*24},
- },
- {
- filter: `size(tags) == 0`,
- want: "JSON_ARRAY_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) = ?",
- args: []any{int64(0)},
- },
- {
- filter: `size(tags) > 0`,
- want: "JSON_ARRAY_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) > ?",
- args: []any{int64(0)},
- },
- {
- filter: `"work" in tags`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.tags') LIKE ?",
- args: []any{`%"work"%`},
- },
- {
- filter: `size(tags) == 2`,
- want: "JSON_ARRAY_LENGTH(COALESCE(JSON_EXTRACT(`memo`.`payload`, '$.tags'), JSON_ARRAY())) = ?",
- args: []any{int64(2)},
- },
- {
- filter: `has_link == true`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasLink') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_code == false`,
- want: "NOT(JSON_EXTRACT(`memo`.`payload`, '$.property.hasCode') IS TRUE)",
- args: []any{},
- },
- {
- filter: `has_incomplete_tasks != false`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasIncompleteTasks') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_link`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasLink') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_code`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasCode') IS TRUE",
- args: []any{},
- },
- {
- filter: `has_incomplete_tasks`,
- want: "JSON_EXTRACT(`memo`.`payload`, '$.property.hasIncompleteTasks') IS TRUE",
- args: []any{},
- },
- }
-
- engine, err := filter.DefaultEngine()
- require.NoError(t, err)
-
- for _, tt := range tests {
- stmt, err := engine.CompileToStatement(context.Background(), tt.filter, filter.RenderOptions{Dialect: filter.DialectSQLite})
- require.NoError(t, err)
- require.Equal(t, tt.want, stmt.SQL)
- require.Equal(t, tt.args, stmt.Args)
- }
-}