Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

fix: validate username before create token (#2439)

Athurg Gooth064c930aede8
diff --git a/api/v2/user_service.go b/api/v2/user_service.go
index 9d2cda269..a3b8ca8f9 100644
--- a/api/v2/user_service.go
+++ b/api/v2/user_service.go
@@ -231,7 +231,22 @@ func (s *UserService) CreateUserAccessToken(ctx context.Context, request *apiv2p
if request.ExpiresAt != nil {
expiresAt = request.ExpiresAt.AsTime()
}
- accessToken, err := auth.GenerateAccessToken(user.Username, user.ID, expiresAt, []byte(s.Secret))
+
+ // Create access token for other users need to be verified.
+ if user.Username != request.Username {
+ // Normal users can only create access tokens for others.
+ if user.Role == store.RoleUser {
+ return nil, status.Errorf(codes.PermissionDenied, "permission denied")
+ }
+
+ // The request user must be exist.
+ requestUser, err := s.Store.GetUser(ctx, &store.FindUser{Username: &request.Username})
+ if requestUser == nil || err != nil {
+ return nil, status.Errorf(codes.NotFound, "fail to find user %s", request.Username)
+ }
+ }
+
+ accessToken, err := auth.GenerateAccessToken(request.Username, user.ID, expiresAt, []byte(s.Secret))
if err != nil {
return nil, status.Errorf(codes.Internal, "failed to generate access token: %v", err)
}