Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

feat: add notice when sharing private links (#2809)

Brilliant Hanabi1bad0543d005
diff --git a/web/src/components/ShareMemoDialog.tsx b/web/src/components/ShareMemoDialog.tsx
index 45a267087..834b3061b 100644
--- a/web/src/components/ShareMemoDialog.tsx
+++ b/web/src/components/ShareMemoDialog.tsx
@@ -7,7 +7,7 @@ import { downloadFileFromUrl } from "@/helpers/utils";
import useLoading from "@/hooks/useLoading";
import toImage from "@/labs/html2image";
import { useUserStore, extractUsernameFromName } from "@/store/v1";
-import { Memo } from "@/types/proto/api/v2/memo_service";
+import { Memo, Visibility } from "@/types/proto/api/v2/memo_service";
import { useTranslate } from "@/utils/i18n";
import { generateDialog } from "./Dialog";
import Icon from "./Icon";
@@ -68,7 +68,11 @@ const ShareMemoDialog: React.FC<Props> = (props: Props) => {
const handleCopyLinkBtnClick = () => {
copy(`${window.location.origin}/m/${memo.name}`);
- toast.success(t("message.succeed-copy-link"));
+ if (memo.visibility !== Visibility.PUBLIC) {
+ toast.success(t("message.succeed-copy-link-not-public"));
+ } else {
+ toast.success(t("message.succeed-copy-link"));
+ }
};
if (loadingState.isLoading) {
diff --git a/web/src/locales/en.json b/web/src/locales/en.json
index d9af7ccde..6ffe04465 100644
--- a/web/src/locales/en.json
+++ b/web/src/locales/en.json
@@ -352,6 +352,7 @@
"private-only": "This memo is set to private.",
"copied": "Copied",
"succeed-copy-content": "Content copied successfully.",
+ "succeed-copy-link-not-public": "Content copied successfully. This memo is not accessible without logging in.",
"succeed-copy-code": "Code copied successfully.",
"succeed-copy-link": "Link copied successfully.",
"change-resource-filename": "Change resource filename",
diff --git a/web/src/locales/zh-Hans.json b/web/src/locales/zh-Hans.json
index 3b1a984a0..a21b0da11 100644
--- a/web/src/locales/zh-Hans.json
+++ b/web/src/locales/zh-Hans.json
@@ -175,6 +175,7 @@
"succeed-copy-code": "复制代码到剪贴板成功。",
"succeed-copy-content": "复制内容到剪贴板成功。",
"succeed-copy-link": "复制链接到剪贴板成功。",
+ "succeed-copy-link-not-public": "复制链接到剪贴板成功,请注意本条备忘录在未登录情况下不可访问。",
"succeed-copy-resource-link": "复制资源链接到剪贴板成功。",
"succeed-update-additional-script": "更新附加脚本成功。",
"succeed-update-additional-style": "更新附加样式成功。",
diff --git a/web/src/locales/zh-Hant.json b/web/src/locales/zh-Hant.json
index 3d966c66e..e6afe2b81 100644
--- a/web/src/locales/zh-Hant.json
+++ b/web/src/locales/zh-Hant.json
@@ -177,6 +177,7 @@
"succeed-copy-code": "複製程式碼到剪貼簿成功。",
"succeed-copy-content": "複製內容到剪貼簿成功。",
"succeed-copy-link": "複製連結到剪貼簿成功。",
+ "succeed-copy-link-not-public": "複製連結到剪貼簿成功,請注意本條備忘錄在未登入情況下無法瀏覽。",
"succeed-copy-resource-link": "複製資源連結到剪貼簿成功。",
"succeed-update-additional-script": "更新附加腳本成功。",
"succeed-update-additional-style": "更新附加樣式成功。",