Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

fix: add mime type check for file types (#4981)

Sara Vieira1f1add1a4800
diff --git a/web/package.json b/web/package.json
index 6ee56ddf5..9a25625e1 100644
--- a/web/package.json
+++ b/web/package.json
@@ -40,6 +40,7 @@
"lodash-es": "^4.17.21",
"lucide-react": "^0.486.0",
"mermaid": "^11.9.0",
+ "mime": "^4.0.7",
"mobx": "^6.13.7",
"mobx-react-lite": "^4.1.0",
"react": "^18.3.1",
diff --git a/web/pnpm-lock.yaml b/web/pnpm-lock.yaml
index 66a67551a..0b16255b8 100644
--- a/web/pnpm-lock.yaml
+++ b/web/pnpm-lock.yaml
@@ -104,6 +104,9 @@ importers:
mermaid:
specifier: ^11.9.0
version: 11.9.0
+ mime:
+ specifier: ^4.0.7
+ version: 4.0.7
mobx:
specifier: ^6.13.7
version: 6.13.7
@@ -2723,6 +2726,11 @@ packages:
resolution: {integrity: sha512-PXwfBhYu0hBCPw8Dn0E+WDYb7af3dSLVWKi3HGv84IdF4TyFoC0ysxFd0Goxw7nSv4T/PzEJQxsYsEiFCKo2BA==}
engines: {node: '>=8.6'}
+ resolution: {integrity: sha512-2OfDPL+e03E0LrXaGYOtTFIYhiuzep94NSsuhrNULq+stylcJedcHdzHtz0atMUuGwJfFYs0YL5xeC/Ca2x0eQ==}
+ engines: {node: '>=16'}
+ hasBin: true
+
resolution: {integrity: sha512-J7p63hRiAjw1NDEww1W7i37+ByIrOWO5XQQAzZ3VOcL0PNybwpfmV/N05zFAzwQ9USyEcX6t3UO+K5aqBQOIHw==}
@@ -6210,6 +6218,8 @@ snapshots:
braces: 3.0.3
picomatch: 2.3.1
+
dependencies:
brace-expansion: 1.1.12
diff --git a/web/src/components/MemoEditor/ActionButton/UploadAttachmentButton.tsx b/web/src/components/MemoEditor/ActionButton/UploadAttachmentButton.tsx
index 175666e84..bbb59d2ca 100644
--- a/web/src/components/MemoEditor/ActionButton/UploadAttachmentButton.tsx
+++ b/web/src/components/MemoEditor/ActionButton/UploadAttachmentButton.tsx
@@ -1,5 +1,6 @@
import { t } from "i18next";
import { LoaderIcon, PaperclipIcon } from "lucide-react";
+import mime from "mime";
import { observer } from "mobx-react-lite";
import { useContext, useRef, useState } from "react";
import toast from "react-hot-toast";
@@ -51,7 +52,7 @@ const UploadAttachmentButton = observer((props: Props) => {
attachment: Attachment.fromPartial({
filename,
size,
- type,
+ type: type || mime.getType(filename) || "",
content: buffer,
}),
attachmentId: "",