Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.
Go dockerfossgomarkdownmemomicroblognote-takingnotesopen-sourceown-your-datareactself-hostedsqlitetimeline
fix: role error in api/v2 when the first user registers (#2875)
Wen Sun3158c4b8b58b
diff --git a/api/v2/auth_service.go b/api/v2/auth_service.goindex 35cd01c93..25a43a4ac 100644--- a/api/v2/auth_service.go+++ b/api/v2/auth_service.go@@ -179,7 +179,7 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpRequesif err != nil {return nil, status.Errorf(codes.Internal, fmt.Sprintf("failed to get workspace setting, err: %s", err))}- if workspaceGeneralSetting.DisallowSignup {+ if workspaceGeneralSetting.DisallowSignup || workspaceGeneralSetting.DisallowPasswordLogin {return nil, status.Errorf(codes.PermissionDenied, "sign up is not allowed")}@@ -193,13 +193,17 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpRequesNickname: request.Username,PasswordHash: string(passwordHash),}- existingUsers, err := s.Store.ListUsers(ctx, &store.FindUser{})++ hostUserType := store.RoleHost+ existedHostUsers, err := s.Store.ListUsers(ctx, &store.FindUser{+ Role: &hostUserType,+ })if err != nil {return nil, status.Errorf(codes.Internal, fmt.Sprintf("failed to list users, err: %s", err))}- // The first user to sign up is an admin by default.- if len(existingUsers) == 0 {- create.Role = store.RoleAdmin+ if len(existedHostUsers) == 0 {+ // Change the default role to host if there is no host user.+ create.Role = store.RoleHost} else {create.Role = store.RoleUser}