Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

fix: fix deleting tag from tag lists (#3311)

Nabiel Omar Syarif56ceba2decd9
diff --git a/server/router/api/v1/tag_service.go b/server/router/api/v1/tag_service.go
index 38013af0a..2fb163bad 100644
--- a/server/router/api/v1/tag_service.go
+++ b/server/router/api/v1/tag_service.go
@@ -137,13 +137,7 @@ func (s *APIV1Service) RenameTag(ctx context.Context, request *v1pb.RenameTagReq
}
func (s *APIV1Service) DeleteTag(ctx context.Context, request *v1pb.DeleteTagRequest) (*emptypb.Empty, error) {
- userID, err := ExtractUserIDFromName(request.Tag.Creator)
- if err != nil {
- return nil, status.Errorf(codes.InvalidArgument, "invalid user name: %v", err)
- }
- user, err := s.Store.GetUser(ctx, &store.FindUser{
- ID: &userID,
- })
+ user, err := getCurrentUser(ctx, s.Store)
if err != nil {
return nil, status.Errorf(codes.Internal, "failed to get user: %v", err)
}
diff --git a/web/src/components/HomeSidebar/TagsSection.tsx b/web/src/components/HomeSidebar/TagsSection.tsx
index f4315b198..c59b5bfec 100644
--- a/web/src/components/HomeSidebar/TagsSection.tsx
+++ b/web/src/components/HomeSidebar/TagsSection.tsx
@@ -130,6 +130,7 @@ const TagItemContainer: React.FC<TagItemContainerProps> = (props: TagItemContain
dialogName: "delete-tag-dialog",
onConfirm: async () => {
await tagStore.deleteTag(tag.text);
+ tagStore.fetchTags({ skipCache: true });
},
});
};