Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.
Go dockerfossgomarkdownmemomicroblognote-takingnotesopen-sourceown-your-datareactself-hostedsqlitetimeline
fix(security): validate attachment filenames (#5218)
Florian Dewald5f57f48673e2
diff --git a/server/router/api/v1/attachment_service.go b/server/router/api/v1/attachment_service.goindex 64f342904..80c32c76b 100644--- a/server/router/api/v1/attachment_service.go+++ b/server/router/api/v1/attachment_service.go@@ -64,6 +64,9 @@ func (s *APIV1Service) CreateAttachment(ctx context.Context, request *v1pb.Creatif request.Attachment.Filename == "" {return nil, status.Errorf(codes.InvalidArgument, "filename is required")}+ if !validateFilename(request.Attachment.Filename) {+ return nil, status.Errorf(codes.InvalidArgument, "filename contains invalid characters or format")+ }if request.Attachment.Type == "" {return nil, status.Errorf(codes.InvalidArgument, "type is required")}@@ -325,6 +328,9 @@ func (s *APIV1Service) UpdateAttachment(ctx context.Context, request *v1pb.Updat}for _, field := range request.UpdateMask.Paths {if field == "filename" {+ if !validateFilename(request.Attachment.Filename) {+ return nil, status.Errorf(codes.InvalidArgument, "filename contains invalid characters or format")+ }update.Filename = &request.Attachment.Filename}}@@ -701,3 +707,18 @@ func setResponseHeaders(ctx context.Context, headers map[string]string) error {}return grpc.SetHeader(ctx, metadata.Pairs(pairs...))}++func validateFilename(filename string) bool {+ // Reject path traversal attempts and make sure no additional directories are created+ if !filepath.IsLocal(filename) || strings.ContainsAny(filename, "/\\") {+ return false+ }++ // Reject filenames starting or ending with spaces or periods+ if strings.HasPrefix(filename, " ") || strings.HasSuffix(filename, " ") ||+ strings.HasPrefix(filename, ".") || strings.HasSuffix(filename, ".") {+ return false+ }++ return true+}