Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

fix: empty filter value (#529)

Zeng19987c78fb064f33
diff --git a/web/src/components/CreateShortcutDialog.tsx b/web/src/components/CreateShortcutDialog.tsx
index 18fc699ca..21223258a 100644
--- a/web/src/components/CreateShortcutDialog.tsx
+++ b/web/src/components/CreateShortcutDialog.tsx
@@ -48,7 +48,12 @@ const CreateShortcutDialog: React.FC<Props> = (props: Props) => {
toastHelper.error(t("shortcut-list.title-required"));
return;
}
-
+ for (const filter of filters) {
+ if (!filter.value.value) {
+ toastHelper.error(t("shortcut-list.value-required"));
+ return;
+ }
+ }
try {
if (shortcutId) {
await shortcutService.patchShortcut({
diff --git a/web/src/locales/en.json b/web/src/locales/en.json
index 5908405e1..ae75bea28 100644
--- a/web/src/locales/en.json
+++ b/web/src/locales/en.json
@@ -104,7 +104,8 @@
"edit-shortcut": "Edit Shortcut",
"eligible-memo": "eligible memo",
"fill-previous": "Please fill in previous filter value",
- "title-required": "Title is required"
+ "title-required": "Title is required",
+ "value-required": "Filter value is required"
},
"filter": {
"new-filter": "New Filter",
diff --git a/web/src/locales/vi.json b/web/src/locales/vi.json
index d752a028d..e99fbc653 100644
--- a/web/src/locales/vi.json
+++ b/web/src/locales/vi.json
@@ -104,7 +104,8 @@
"edit-shortcut": "Chỉnh sửa lối tắt",
"eligible-memo": "memo đạt chuẩn",
"fill-previous": "Vui lòng nhập vào giá trị của bộ lọc trước đó",
- "title-required": "Tiêu đề là bắt buộc"
+ "title-required": "Tiêu đề là bắt buộc",
+ "value-required": "Giá trị bộ lọc là bắt buộc"
},
"filter": {
"new-filter": "Bộ lọc mới",
diff --git a/web/src/locales/zh.json b/web/src/locales/zh.json
index 70db4451f..55a10c4cf 100644
--- a/web/src/locales/zh.json
+++ b/web/src/locales/zh.json
@@ -104,7 +104,8 @@
"edit-shortcut": "编辑捷径",
"eligible-memo": "符合条件的 Memo",
"fill-previous": "请填写之前的过滤值",
- "title-required": "标题是必填项。"
+ "title-required": "标题是必填项。",
+ "value-required": "过滤值是必填项"
},
"filter": {
"new-filter": "新建过滤器",