Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

test: close SSE response body explicitly

boojack8479e1d5a33b
diff --git a/server/router/api/v1/test/sse_handler_test.go b/server/router/api/v1/test/sse_handler_test.go
index 2a755e1ed..6c79d34a4 100644
--- a/server/router/api/v1/test/sse_handler_test.go
+++ b/server/router/api/v1/test/sse_handler_test.go
@@ -86,9 +86,12 @@ func TestSSEHandler_Authentication(t *testing.T) {
require.NoError(t, err)
req.Header.Set("Authorization", "Bearer "+token)
- resp, err := server.Client().Do(req)
- require.NoError(t, err)
- defer resp.Body.Close()
+ resp, err := server.Client().Do(req) //nolint:bodyclose // Body is closed after verifying the SSE stream disconnects.
+ if err != nil {
+ t.Fatal(err)
+ }
+ body := resp.Body
+ defer body.Close()
require.Equal(t, http.StatusOK, resp.StatusCode)
require.Equal(t, "text/event-stream", resp.Header.Get("Content-Type"))
@@ -96,7 +99,7 @@ func TestSSEHandler_Authentication(t *testing.T) {
done := make(chan error, 1)
go func() {
- _, err := io.ReadAll(resp.Body)
+ _, err := io.ReadAll(body)
done <- err
}()