Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

fix: add nil check for AnyResponse in WrapUnary method to prevent caching issues

Stevenb32cba35c646
diff --git a/server/router/api/v1/connect_interceptors.go b/server/router/api/v1/connect_interceptors.go
index e4c263929..dab7150d9 100644
--- a/server/router/api/v1/connect_interceptors.go
+++ b/server/router/api/v1/connect_interceptors.go
@@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"log/slog"
+ "reflect"
"runtime/debug"
"connectrpc.com/connect"
@@ -56,7 +57,7 @@ func (*MetadataInterceptor) WrapUnary(next connect.UnaryFunc) connect.UnaryFunc
// Prevent browser caching of API responses to avoid stale data issues
// See: https://github.com/usememos/memos/issues/5470
- if resp != nil && resp.Header() != nil {
+ if !isNilAnyResponse(resp) && resp.Header() != nil {
resp.Header().Set("Cache-Control", "no-cache, no-store, must-revalidate")
resp.Header().Set("Pragma", "no-cache")
resp.Header().Set("Expires", "0")
@@ -66,6 +67,14 @@ func (*MetadataInterceptor) WrapUnary(next connect.UnaryFunc) connect.UnaryFunc
}
}
+func isNilAnyResponse(resp connect.AnyResponse) bool {
+ if resp == nil {
+ return true
+ }
+ val := reflect.ValueOf(resp)
+ return val.Kind() == reflect.Ptr && val.IsNil()
+}
+
func (*MetadataInterceptor) WrapStreamingClient(next connect.StreamingClientFunc) connect.StreamingClientFunc {
return next
}