Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

refactor: enhance hyperlink handling in markdown shortcuts (#4238)

Chris Currybc0bac94ed70
diff --git a/web/src/components/MemoEditor/handlers.ts b/web/src/components/MemoEditor/handlers.ts
index 6988fad2f..2e0c2bb20 100644
--- a/web/src/components/MemoEditor/handlers.ts
+++ b/web/src/components/MemoEditor/handlers.ts
@@ -19,13 +19,22 @@ export const hyperlinkHighlightedText = (editor: EditorRefActions, url?: string)
const cursorPosition = editor.getCursorPosition();
const selectedContent = editor.getSelectedContent();
const blankURL = "url";
- url = url ?? blankURL;
- editor.insertText(`[${selectedContent}](${url})`);
+ // If the selected content looks like a URL and no URL is provided,
+ // create a link with empty text and the URL
+ const urlRegex = /^(https?:\/\/[^\s]+)$/;
+ if (!url && urlRegex.test(selectedContent.trim())) {
+ editor.insertText(`[](${selectedContent})`);
+ editor.setCursorPosition(cursorPosition + 1, cursorPosition + 1);
+ } else {
+ url = url ?? blankURL;
+
+ editor.insertText(`[${selectedContent}](${url})`);
- if (url === blankURL) {
- const newCursorStart = cursorPosition + selectedContent.length + 3;
- editor.setCursorPosition(newCursorStart, newCursorStart + url.length);
+ if (url === blankURL) {
+ const newCursorStart = cursorPosition + selectedContent.length + 3;
+ editor.setCursorPosition(newCursorStart, newCursorStart + url.length);
+ }
}
};