Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.
Go dockerfossgomarkdownmemomicroblognote-takingnotesopen-sourceown-your-datareactself-hostedsqlitetimeline
fix: add user authentication checks
Johnnyefe6013c3660
diff --git a/server/router/api/v1/attachment_service.go b/server/router/api/v1/attachment_service.goindex b774680c8..2a99b8351 100644--- a/server/router/api/v1/attachment_service.go+++ b/server/router/api/v1/attachment_service.go@@ -53,6 +53,9 @@ func (s *APIV1Service) CreateAttachment(ctx context.Context, request *v1pb.Creatif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Validate required fieldsif request.Attachment == nil {@@ -124,6 +127,9 @@ func (s *APIV1Service) ListAttachments(ctx context.Context, request *v1pb.ListAtif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Set default page sizepageSize := int(request.PageSize)@@ -364,6 +370,9 @@ func (s *APIV1Service) DeleteAttachment(ctx context.Context, request *v1pb.Deletif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }attachment, err := s.Store.GetAttachment(ctx, &store.FindAttachment{UID: &attachmentUID,CreatorID: &user.ID,diff --git a/server/router/api/v1/memo_service.go b/server/router/api/v1/memo_service.goindex 244059e60..aa111338f 100644--- a/server/router/api/v1/memo_service.go+++ b/server/router/api/v1/memo_service.go@@ -29,6 +29,9 @@ func (s *APIV1Service) CreateMemo(ctx context.Context, request *v1pb.CreateMemoRif err != nil {return nil, status.Errorf(codes.Internal, "failed to get user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }create := &store.Memo{UID: shortuuid.New(),@@ -318,6 +321,9 @@ func (s *APIV1Service) UpdateMemo(ctx context.Context, request *v1pb.UpdateMemoRif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Only the creator or admin can update the memo.if memo.CreatorID != user.ID && !isSuperUser(user) {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -453,6 +459,9 @@ func (s *APIV1Service) DeleteMemo(ctx context.Context, request *v1pb.DeleteMemoRif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Only the creator or admin can update the memo.if memo.CreatorID != user.ID && !isSuperUser(user) {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -689,6 +698,9 @@ func (s *APIV1Service) RenameMemoTag(ctx context.Context, request *v1pb.RenameMeif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }memoFind := &store.FindMemo{CreatorID: &user.ID,@@ -739,6 +751,9 @@ func (s *APIV1Service) DeleteMemoTag(ctx context.Context, request *v1pb.DeleteMeif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }memoFind := &store.FindMemo{CreatorID: &user.ID,diff --git a/server/router/api/v1/reaction_service.go b/server/router/api/v1/reaction_service.goindex 561d776ad..7dd007d8f 100644--- a/server/router/api/v1/reaction_service.go+++ b/server/router/api/v1/reaction_service.go@@ -37,6 +37,9 @@ func (s *APIV1Service) UpsertMemoReaction(ctx context.Context, request *v1pb.Upsif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user")}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }reaction, err := s.Store.UpsertReaction(ctx, &store.Reaction{CreatorID: user.ID,ContentID: request.Reaction.ContentId,diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.goindex 207427611..b1f0a96ec 100644--- a/server/router/api/v1/user_service.go+++ b/server/router/api/v1/user_service.go@@ -36,6 +36,9 @@ func (s *APIV1Service) ListUsers(ctx context.Context, request *v1pb.ListUsersReqif err != nil {return nil, status.Errorf(codes.Internal, "failed to get user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if currentUser.Role != store.RoleHost && currentUser.Role != store.RoleAdmin {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}@@ -322,6 +325,9 @@ func (s *APIV1Service) GetUserSetting(ctx context.Context, request *v1pb.GetUserif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Only allow user to get their own settingsif currentUser.ID != userID {@@ -356,6 +362,9 @@ func (s *APIV1Service) UpdateUserSetting(ctx context.Context, request *v1pb.Updaif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Only allow user to update their own settingsif currentUser.ID != userID {@@ -442,6 +451,9 @@ func (s *APIV1Service) ListUserSettings(ctx context.Context, request *v1pb.ListUif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }// Only allow user to list their own settingsif currentUser.ID != userID {@@ -500,7 +512,7 @@ func (s *APIV1Service) ListUserAccessTokens(ctx context.Context, request *v1pb.Lreturn nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}if currentUser == nil {- return nil, status.Errorf(codes.PermissionDenied, "permission denied")+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")}if currentUser.ID != userID {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -562,7 +574,7 @@ func (s *APIV1Service) CreateUserAccessToken(ctx context.Context, request *v1pb.return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}if currentUser == nil {- return nil, status.Errorf(codes.PermissionDenied, "permission denied")+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")}if currentUser.ID != userID {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -630,7 +642,7 @@ func (s *APIV1Service) DeleteUserAccessToken(ctx context.Context, request *v1pb.return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}if currentUser == nil {- return nil, status.Errorf(codes.PermissionDenied, "permission denied")+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")}if currentUser.ID != userID {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -673,7 +685,7 @@ func (s *APIV1Service) ListUserSessions(ctx context.Context, request *v1pb.ListUreturn nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}if currentUser == nil {- return nil, status.Errorf(codes.PermissionDenied, "permission denied")+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")}if currentUser.ID != userID {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -736,7 +748,7 @@ func (s *APIV1Service) RevokeUserSession(ctx context.Context, request *v1pb.Revoreturn nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}if currentUser == nil {- return nil, status.Errorf(codes.PermissionDenied, "permission denied")+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")}if currentUser.ID != userID {return nil, status.Errorf(codes.PermissionDenied, "permission denied")@@ -796,6 +808,9 @@ func (s *APIV1Service) ListUserWebhooks(ctx context.Context, request *v1pb.ListUif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if currentUser.ID != userID && currentUser.Role != store.RoleHost && currentUser.Role != store.RoleAdmin {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}@@ -825,6 +840,9 @@ func (s *APIV1Service) CreateUserWebhook(ctx context.Context, request *v1pb.Creaif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if currentUser.ID != userID && currentUser.Role != store.RoleHost && currentUser.Role != store.RoleAdmin {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}@@ -862,6 +880,9 @@ func (s *APIV1Service) UpdateUserWebhook(ctx context.Context, request *v1pb.Updaif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if currentUser.ID != userID && currentUser.Role != store.RoleHost && currentUser.Role != store.RoleAdmin {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}@@ -931,6 +952,9 @@ func (s *APIV1Service) DeleteUserWebhook(ctx context.Context, request *v1pb.Deleif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if currentUser == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if currentUser.ID != userID && currentUser.Role != store.RoleHost && currentUser.Role != store.RoleAdmin {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}diff --git a/server/router/api/v1/workspace_service.go b/server/router/api/v1/workspace_service.goindex 2279245ca..0af794c62 100644--- a/server/router/api/v1/workspace_service.go+++ b/server/router/api/v1/workspace_service.go@@ -83,6 +83,9 @@ func (s *APIV1Service) UpdateWorkspaceSetting(ctx context.Context, request *v1pbif err != nil {return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)}+ if user == nil {+ return nil, status.Errorf(codes.Unauthenticated, "user not authenticated")+ }if user.Role != store.RoleHost {return nil, status.Errorf(codes.PermissionDenied, "permission denied")}