Skip to content

armgit / memos

Public Imported from GitHub
0

Memos is an open-source, self-hosted note-taking app that brings your everyday thoughts together in a personal timeline. Your data stays yours, and you choose what to keep private or share.

feat: remove RSS titles (#4140)

JP Hastings-Edreifcc4abf5b8be
diff --git a/server/router/rss/rss.go b/server/router/rss/rss.go
index 1959e27a3..4098702e3 100644
--- a/server/router/rss/rss.go
+++ b/server/router/rss/rss.go
@@ -5,13 +5,11 @@ import (
"fmt"
"net/http"
"strconv"
- "strings"
"time"
"github.com/gorilla/feeds"
"github.com/labstack/echo/v4"
"github.com/usememos/gomark"
- "github.com/usememos/gomark/ast"
"github.com/usememos/gomark/renderer"
storepb "github.com/usememos/memos/proto/gen/store"
@@ -20,8 +18,7 @@ import (
)
const (
- maxRSSItemCount = 100
- maxRSSItemTitleLength = 128
+ maxRSSItemCount = 100
)
type RSSService struct {
@@ -112,7 +109,6 @@ func (s *RSSService) generateRSSFromMemoList(ctx context.Context, memoList []*st
return "", err
}
feed.Items[i] = &feeds.Item{
- Title: getRSSItemTitle(memo.Content),
Link: &feeds.Link{Href: baseURL + "/m/" + memo.UID},
Description: description,
Created: time.Unix(memo.CreatedTs, 0),
@@ -144,22 +140,6 @@ func (s *RSSService) generateRSSFromMemoList(ctx context.Context, memoList []*st
return rss, nil
}
-func getRSSItemTitle(content string) string {
- nodes, _ := gomark.Parse(content)
- if len(nodes) > 0 {
- firstNode := nodes[0]
- title := renderer.NewStringRenderer().Render([]ast.Node{firstNode})
- return title
- }
-
- title := strings.Split(content, "\n")[0]
- var titleLengthLimit = min(len(title), maxRSSItemTitleLength)
- if titleLengthLimit < len(title) {
- title = title[:titleLengthLimit] + "..."
- }
- return title
-}
-
func getRSSItemDescription(content string) (string, error) {
nodes, err := gomark.Parse(content)
if err != nil {