Skip to content

The complete open source platform to run your entire marketplace. Storefront, vendor panel, admin console, and integrations in one enterprise-grade platform you own.

fix(core): restore role_id in seller member query defaults (#1592)

Viktor Holik12104fcf321f
diff --git a/integration-tests/http/seller/vendor/seller.spec.ts b/integration-tests/http/seller/vendor/seller.spec.ts
index b5a7be8a2..1d802efa7 100644
--- a/integration-tests/http/seller/vendor/seller.spec.ts
+++ b/integration-tests/http/seller/vendor/seller.spec.ts
@@ -940,6 +940,18 @@ medusaIntegrationTestRunner({
expect(sm.member).toBeDefined()
})
+ it("should return role_id for each member by default", async () => {
+ const response = await api.get(
+ `/vendor/sellers/${sellerA.id}/members`,
+ headersA
+ )
+
+ expect(response.status).toEqual(200)
+ for (const sm of response.data.seller_members) {
+ expect(sm.role_id).toEqual(SellerRole.SELLER_ADMINISTRATION)
+ }
+ })
+
it("should have owner member with is_owner true", async () => {
const response = await api.get(
`/vendor/sellers/${sellerA.id}/members`,
diff --git a/packages/core/src/api/admin/sellers/query-config.ts b/packages/core/src/api/admin/sellers/query-config.ts
index e87eb9d1f..31366e24a 100644
--- a/packages/core/src/api/admin/sellers/query-config.ts
+++ b/packages/core/src/api/admin/sellers/query-config.ts
@@ -57,6 +57,7 @@ export const adminMembersQueryConfig = {
return ([
"id",
"is_owner",
+ "role_id",
"member.*",
"created_at",
])
diff --git a/packages/core/src/api/vendor/members/middlewares.ts b/packages/core/src/api/vendor/members/middlewares.ts
index 16d9967bd..600739487 100644
--- a/packages/core/src/api/vendor/members/middlewares.ts
+++ b/packages/core/src/api/vendor/members/middlewares.ts
@@ -13,6 +13,7 @@ const retrieveVendorMemberMeQueryConfig = {
return ([
"id",
"is_owner",
+ "role_id",
"member.*",
"seller.*",
"seller.address.*",
diff --git a/packages/core/src/api/vendor/sellers/query-config.ts b/packages/core/src/api/vendor/sellers/query-config.ts
index 1a0aacb66..2988e8821 100644
--- a/packages/core/src/api/vendor/sellers/query-config.ts
+++ b/packages/core/src/api/vendor/sellers/query-config.ts
@@ -4,6 +4,7 @@ export const listVendorSellersQueryConfig = {
return ([
"id",
"seller.*",
+ "role_id",
])
},
defaultLimit: 50,
@@ -43,6 +44,7 @@ export const listVendorMembersQueryConfig = {
return ([
"id",
"is_owner",
+ "role_id",
"member.*",
"created_at",
])
@@ -56,6 +58,7 @@ export const retrieveVendorMemberQueryConfig = {
return ([
"id",
"is_owner",
+ "role_id",
"member.*",
"created_at",
])