Skip to content

The complete open source platform to run your entire marketplace. Storefront, vendor panel, admin console, and integrations in one enterprise-grade platform you own.

fix(cart): return line-item offer and seller on store cart routes (#1712)

Viktor Holika212b32c89b6
diff --git a/integration-tests/http/offer/cart/cart.spec.ts b/integration-tests/http/offer/cart/cart.spec.ts
index 4bdb3b42d..a69da7a92 100644
--- a/integration-tests/http/offer/cart/cart.spec.ts
+++ b/integration-tests/http/offer/cart/cart.spec.ts
@@ -424,6 +424,50 @@ medusaIntegrationTestRunner({
)
})
+ it("should return each line's offer and seller on GET /store/carts/:id when requested", async () => {
+ const first: SellerSeed = await seedSellerOffer({
+ email: "[email protected]",
+ name: "Cart Seller A",
+ stocked: 10,
+ offerPrice: 3000,
+ })
+ const second: SellerSeed = await seedSellerOffer({
+ email: "[email protected]",
+ name: "Cart Seller B",
+ stocked: 10,
+ offerPrice: 3200,
+ })
+
+ const cart = await createCart()
+
+ for (const seed of [first, second]) {
+ await api.post(
+ `/store/carts/${cart.id}/line-items`,
+ { offer_id: seed.offer.id, quantity: 1 },
+ storeHeaders
+ )
+ }
+
+ const response = await api.get(
+ `/store/carts/${cart.id}?fields=*items,*items.offer,*items.offer.seller`,
+ storeHeaders
+ )
+
+ expect(response.status).toEqual(200)
+
+ const sellerByOffer = Object.fromEntries(
+ response.data.cart.items.map((item: any) => [
+ item.offer?.id,
+ item.offer?.seller?.id,
+ ])
+ )
+
+ expect(sellerByOffer).toEqual({
+ [first.offer.id]: first.sellerId,
+ [second.offer.id]: second.sellerId,
+ })
+ })
+
// SPEC-007: decorateLineItemWithOfferStep is removed.
// Offer SKU is now read on demand from
// `cart.items[*].offer.sku` via Query.
diff --git a/packages/core/src/api/store/carts/middlewares.ts b/packages/core/src/api/store/carts/middlewares.ts
index e317509f8..3d94315b2 100644
--- a/packages/core/src/api/store/carts/middlewares.ts
+++ b/packages/core/src/api/store/carts/middlewares.ts
@@ -47,7 +47,22 @@ const dropEmptyCurrencyCode = (
next()
}
+// Medusa's store cart query config silently drops requested fields outside its
+// allowlist, so line-item offers (and their seller) never reach the storefront.
+const allowLineItemOffers = (
+ req: MedusaRequest,
+ _res: MedusaResponse,
+ next: MedusaNextFunction
+) => {
+ req.allowed.push("items.offer", "items.offer.seller")
+ next()
+}
+
export const storeCartsMiddlewares: MiddlewareRoute[] = [
+ {
+ matcher: "/store/carts*",
+ middlewares: [allowLineItemOffers],
+ },
{
method: ["POST"],
matcher: "/store/carts",