Skip to content

The complete open source platform to run your entire marketplace. Storefront, vendor panel, admin console, and integrations in one enterprise-grade platform you own.

fix(product): enforce single category per product on assignment (#1185)

Viktor Holikbce7e2a86624
diff --git a/integration-tests/http/product-categories/vendor/product-categories.spec.ts b/integration-tests/http/product-categories/vendor/product-categories.spec.ts
index 05e7eede9..7d70be64e 100644
--- a/integration-tests/http/product-categories/vendor/product-categories.spec.ts
+++ b/integration-tests/http/product-categories/vendor/product-categories.spec.ts
@@ -209,6 +209,44 @@ medusaIntegrationTestRunner({
expect(response.data.product_category).toBeDefined()
})
+ it("should keep a product in exactly one category when reassigned", async () => {
+ const [categoryA, categoryB] = await productModuleService.createProductCategories([
+ { name: "Category A", is_active: true },
+ { name: "Category B", is_active: true },
+ ])
+
+ const productResponse = await api.post(
+ `/vendor/products`,
+ {
+ title: "Single Category Product",
+ options: [{ title: "Default", values: ["Default"] }],
+ },
+ sellerHeaders
+ )
+
+ const productId = productResponse.data.product.id
+
+ await api.post(
+ `/vendor/product-categories/${categoryA.id}/products`,
+ { add: [productId] },
+ sellerHeaders
+ )
+
+ await api.post(
+ `/vendor/product-categories/${categoryB.id}/products`,
+ { add: [productId] },
+ sellerHeaders
+ )
+
+ const [product] = await productModuleService.listProducts(
+ { id: [productId] },
+ { relations: ["categories"] }
+ )
+
+ expect(product.categories).toHaveLength(1)
+ expect(product.categories?.[0].id).toEqual(categoryB.id)
+ })
+
it("should not allow seller to add another seller's product to category", async () => {
const [category] = await productModuleService.createProductCategories([
{ name: "Category for Auth Test", is_active: true },
diff --git a/packages/core/src/api/admin/product-categories/[id]/products/route.ts b/packages/core/src/api/admin/product-categories/[id]/products/route.ts
index e14f3c193..186b6a87b 100644
--- a/packages/core/src/api/admin/product-categories/[id]/products/route.ts
+++ b/packages/core/src/api/admin/product-categories/[id]/products/route.ts
@@ -2,9 +2,8 @@ import {
AuthenticatedMedusaRequest,
MedusaResponse,
} from "@medusajs/framework/http"
-import { batchLinkProductsToCategoryWorkflow } from "@medusajs/medusa/core-flows"
-
import { AdminBatchLinkProductsToCategoryType } from "../../validators"
+import { assignProductsToCategoryWorkflow } from "../../../../../workflows/product/workflows/assign-products-to-category"
export const POST = async (
req: AuthenticatedMedusaRequest<AdminBatchLinkProductsToCategoryType>,
@@ -12,7 +11,7 @@ export const POST = async (
) => {
const { add, remove } = req.validatedBody
- await batchLinkProductsToCategoryWorkflow(req.scope).run({
+ await assignProductsToCategoryWorkflow(req.scope).run({
input: {
id: req.params.id,
add,
diff --git a/packages/core/src/api/vendor/product-categories/[id]/products/route.ts b/packages/core/src/api/vendor/product-categories/[id]/products/route.ts
index 7736def86..618ba225d 100644
--- a/packages/core/src/api/vendor/product-categories/[id]/products/route.ts
+++ b/packages/core/src/api/vendor/product-categories/[id]/products/route.ts
@@ -6,11 +6,11 @@ import {
ContainerRegistrationKeys,
MedusaError,
} from "@medusajs/framework/utils"
-import { batchLinkProductsToCategoryWorkflow } from "@medusajs/medusa/core-flows"
import { HttpTypes } from "@mercurjs/types"
import { ensureSellerOwnsProduct } from "../../../products/helpers"
import { VendorBatchLinkProductsToCategoryType } from "../../validators"
+import { assignProductsToCategoryWorkflow } from "../../../../../workflows/product/workflows/assign-products-to-category"
export const POST = async (
req: AuthenticatedMedusaRequest<VendorBatchLinkProductsToCategoryType>,
@@ -38,7 +38,7 @@ export const POST = async (
const productIds = [...(add ?? []), ...(remove ?? [])]
await ensureSellerOwnsProduct(req.scope, sellerId, productIds)
- await batchLinkProductsToCategoryWorkflow(req.scope).run({
+ await assignProductsToCategoryWorkflow(req.scope).run({
input: {
id: req.params.id,
add,
diff --git a/packages/core/src/workflows/product/workflows/assign-products-to-category.ts b/packages/core/src/workflows/product/workflows/assign-products-to-category.ts
new file mode 100644
index 000000000..71f9bacfe
--- /dev/null
+++ b/packages/core/src/workflows/product/workflows/assign-products-to-category.ts
@@ -0,0 +1,39 @@
+import {
+ createWorkflow,
+ transform,
+ when,
+ WorkflowData,
+} from "@medusajs/framework/workflows-sdk"
+import { updateProductsWorkflow } from "@medusajs/medusa/core-flows"
+
+export type AssignProductsToCategoryWorkflowInput = {
+ id: string
+ add?: string[]
+ remove?: string[]
+}
+
+export const assignProductsToCategoryWorkflowId =
+ "mercur-assign-products-to-category"
+
+/**
+ * Assigns products to a single category. Adding a product replaces any
+ * category it already belongs to, keeping every product in exactly one
+ * category at a time.
+ */
+export const assignProductsToCategoryWorkflow = createWorkflow(
+ assignProductsToCategoryWorkflowId,
+ (
+ input: WorkflowData<AssignProductsToCategoryWorkflowInput>
+ ): WorkflowData<void> => {
+ const products = transform({ input }, ({ input }) => [
+ ...(input.add ?? []).map((id) => ({ id, category_ids: [input.id] })),
+ ...(input.remove ?? []).map((id) => ({ id, category_ids: [] as string[] })),
+ ])
+
+ when({ products }, ({ products }) => products.length > 0).then(() => {
+ updateProductsWorkflow.runAsStep({
+ input: transform({ products }, ({ products }) => ({ products })),
+ })
+ })
+ }
+)
diff --git a/packages/core/src/workflows/product/workflows/index.ts b/packages/core/src/workflows/product/workflows/index.ts
index 86b0ca0b4..d99a68688 100644
--- a/packages/core/src/workflows/product/workflows/index.ts
+++ b/packages/core/src/workflows/product/workflows/index.ts
@@ -1,3 +1,4 @@
+export * from "./assign-products-to-category"
export * from "./link-sellers-to-product-category"
export * from "./link-sellers-to-product"
export * from "./create-products"