The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Remove duplicated custom viz e2e helper (#76637)
Nemanja Glumac00050453bb06
diff --git a/e2e/test/scenarios/visualizations-charts/custom-viz.cy.spec.ts b/e2e/test/scenarios/visualizations-charts/custom-viz.cy.spec.tsindex 57edba0b7d8..b75b370005e 100644--- a/e2e/test/scenarios/visualizations-charts/custom-viz.cy.spec.ts+++ b/e2e/test/scenarios/visualizations-charts/custom-viz.cy.spec.ts@@ -1267,21 +1267,6 @@ describe("admin > custom visualizations", () => {});it("renders the custom-viz icon across app surfaces when navigating through the UI", () => {- // Some routes (/search, dashboard edit mode) collapse the nav sidebar.- // Call this before any nav-sidebar interaction so we open it only when- // it's actually hidden — `H.openNavigationSidebar` toggles, so calling- // it unconditionally would close an already-open sidebar.- const ensureNavigationSidebarOpen = () => {- cy.get("body").then(($body) => {- const visible = $body.find(- '[data-testid="main-navbar-root"]:visible',- ).length;- if (!visible) {- H.openNavigationSidebar();- }- });- };-H.interceptPluginBundle();cy.visit("/collection/root");@@ -1332,7 +1317,7 @@ describe("admin > custom visualizations", () => {.should("exist");cy.log('Navigate → home via the nav-sidebar "Home" link');- ensureNavigationSidebarOpen();+ H.openNavigationSidebar();H.navigationSidebar().findByText("Home").click();cy.log("Home recently-viewed section");@@ -1344,7 +1329,7 @@ describe("admin > custom visualizations", () => {.should("exist");cy.log("Navigate → dashboard via bookmark link in the nav sidebar");- ensureNavigationSidebarOpen();+ H.openNavigationSidebar();H.navigationSidebar().findByRole("link", { name: new RegExp(DASHBOARD_NAME) }).click();@@ -1362,7 +1347,7 @@ describe("admin > custom visualizations", () => {cy.findByRole("button", { name: /Cancel/i }).click();cy.log("Navigate → document via bookmark link");- ensureNavigationSidebarOpen();+ H.openNavigationSidebar();H.navigationSidebar().findByRole("link", { name: new RegExp(DOC_NAME) }).click();