The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GDGT-1386 Auto-populate table name based on transform name (#66813)
Kamil Mielnik0168438c2526
diff --git a/e2e/test/scenarios/data-studio/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms.cy.spec.tsindex c35c4174915..e23251abb2e 100644--- a/e2e/test/scenarios/data-studio/transforms.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/transforms.cy.spec.ts@@ -65,8 +65,16 @@ describe("scenarios > admin > transforms", () => {});getQueryEditor().button("Save").click();H.modal().within(() => {- cy.findByLabelText("Name").clear().type("MBQL transform");- cy.findByLabelText("Table name").type(TARGET_TABLE);+ cy.findByLabelText("Name").clear().type("MBQL");++ cy.log("should auto-populate table name based on transform name...");+ cy.findByLabelText("Table name").should("have.value", "mbql");+ cy.findByLabelText("Table name").clear().type(TARGET_TABLE);++ cy.log("...unless user has manually modified the table name");+ cy.findByLabelText("Name").type(" transform");+ cy.findByLabelText("Table name").should("have.value", TARGET_TABLE);+cy.button("Save").click();cy.wait("@createTransform");});@@ -445,7 +453,7 @@ LIMITgetQueryEditor().button("Save").click();H.modal().within(() => {cy.findByLabelText("Name").clear().type("MBQL transform");- cy.findByLabelText("Table name").type(SOURCE_TABLE);+ cy.findByLabelText("Table name").clear().type(SOURCE_TABLE);cy.button("Save").click();cy.wait("@createTransform");});@@ -467,7 +475,7 @@ LIMITgetQueryEditor().button("Save").click();H.modal().within(() => {cy.findByLabelText("Name").clear().type("MBQL transform");- cy.findByLabelText("Table name").type(TARGET_TABLE);+ cy.findByLabelText("Table name").clear().type(TARGET_TABLE);cy.findByLabelText("Schema").clear().type(CUSTOM_SCHEMA);});H.popover().findByText("Create new schema").click();@@ -505,7 +513,7 @@ LIMITH.assertQueryBuilderRowCount(3);});- it("should be able to create a new table in an existing when saving a transform", () => {+ it("should be able to create a new table in an existing transform when saving a transform", () => {visitTransformListPage();cy.button("Create a transform").click();H.popover().findByText("Query builder").click();@@ -517,7 +525,7 @@ LIMITgetQueryEditor().button("Save").click();H.modal().within(() => {cy.findByLabelText("Name").clear().type("MBQL transform");- cy.findByLabelText("Table name").type(TARGET_TABLE);+ cy.findByLabelText("Table name").clear().type(TARGET_TABLE);cy.button("Save").click();cy.wait("@createTransform");});diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/RunStatus/RunStatus.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/RunStatus/RunStatus.tsxindex a7f39fe9e57..e15cd5a68ad 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/RunStatus/RunStatus.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/RunStatus/RunStatus.tsx@@ -4,10 +4,9 @@ import { useSetting } from "metabase/common/hooks";import { Box, Group, Icon } from "metabase/ui";import type { TransformRun } from "metabase-types/api";+import { parseTimestampWithTimezone } from "../../utils";import { RunInfo } from "../RunInfo";-import { parseTimestampWithTimezone } from "./../../utils";-type RunStatusSectionProps = {run: TransformRun | null;neverRunMessage: string;diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsxindex 68cee1087b4..25c64bb9f2b 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/CreateTransformModal.tsx@@ -19,6 +19,7 @@ import {FormTextInput,} from "metabase/forms";import * as Errors from "metabase/lib/errors";+import { slugify } from "metabase/lib/formatting/url";import { Box, Button, Group, Modal, Stack } from "metabase/ui";import { useCreateTransformMutation } from "metabase-enterprise/api";import { IncrementalTransformSettings } from "metabase-enterprise/transforms/components/IncrementalTransform/IncrementalTransformSettings";@@ -29,8 +30,9 @@ import type {} from "metabase-types/api";import { trackTransformCreated } from "../../../analytics";+import { SchemaFormSelect } from "../../../components/SchemaFormSelect";-import { SchemaFormSelect } from "./../../../components/SchemaFormSelect";+import { TargetNameInput } from "./TargetNameInput";function getValidationSchema() {return Yup.object({@@ -162,11 +164,7 @@ function CreateTransformForm({data={schemas}/>)}- <FormTextInput- name="targetName"- label={t`Table name`}- placeholder={t`descriptive_name`}- />+ <TargetNameInput /><IncrementalTransformSettings source={source} /><Group><Box flex={1}>@@ -187,9 +185,13 @@ function getInitialValues(): NewTransformValues {return {name: "",- targetName: "",targetSchema: schemas?.[0] || null,...defaultValues,+ targetName: defaultValues.targetName+ ? defaultValues.targetName+ : defaultValues.name+ ? slugify(defaultValues.name)+ : "",checkpointFilter: null,checkpointFilterUniqueKey: null,incremental: false,diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/TargetNameInput.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/TargetNameInput.tsxnew file mode 100644index 00000000000..5e487fda5d1--- /dev/null+++ b/enterprise/frontend/src/metabase-enterprise/transforms/pages/NewTransformPage/CreateTransformModal/TargetNameInput.tsx@@ -0,0 +1,33 @@+import { useField } from "formik";+import { useEffect, useRef } from "react";+import { t } from "ttag";++import { FormTextInput } from "metabase/forms";+import { slugify } from "metabase/lib/formatting/url";++export const TargetNameInput = () => {+ const isDirtyRef = useRef(false);++ const [{ value: name }] = useField<string>("name");+ const [, , { setValue: setTargetName }] = useField<string>("targetName");++ useEffect(() => {+ if (!isDirtyRef.current) {+ const slugified = slugify(name);+ setTargetName(slugified);+ }+ }, [name, setTargetName]);++ const handleTargetNameChange = () => {+ isDirtyRef.current = true;+ };++ return (+ <FormTextInput+ name="targetName"+ label={t`Table name`}+ placeholder={t`descriptive_name`}+ onChange={handleTargetNameChange}+ />+ );+};diff --git a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/utils.ts b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/utils.tsindex d4b612ef02d..86a96400cd5 100644--- a/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/utils.ts+++ b/frontend/src/metabase/actions/containers/ActionCreator/ActionContext/utils.ts@@ -1,6 +1,6 @@import type { WritebackQueryAction } from "metabase-types/api";-import { getDefaultFormSettings } from "./../../../utils";+import { getDefaultFormSettings } from "../../../utils";export function createEmptyWritebackAction(): Partial<WritebackQueryAction> {return {diff --git a/frontend/src/metabase/dashboard/actions/utils.unit.spec.ts b/frontend/src/metabase/dashboard/actions/utils.unit.spec.tsindex b7cee592302..039b08e8b18 100644--- a/frontend/src/metabase/dashboard/actions/utils.unit.spec.ts+++ b/frontend/src/metabase/dashboard/actions/utils.unit.spec.ts@@ -7,7 +7,8 @@ import {createMockTextDashboardCard,} from "metabase-types/api/mocks";-import { createMockCard } from "./../../../metabase-types/api/mocks/card";+import { createMockCard } from "../../../metabase-types/api/mocks/card";+import {getDashCardMoveToTabUndoMessage,hasDashboardChanged,