The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix Waterfall charts with manual y-axis range in Safari (#83901)
Kevin Kelleher02c5c72535a1
diff --git a/frontend/src/metabase/visualizations/visualizations/CartesianChart/CartesianChart.tsx b/frontend/src/metabase/visualizations/visualizations/CartesianChart/CartesianChart.tsxindex 71c1263a9f8..2656b398b0a 100644--- a/frontend/src/metabase/visualizations/visualizations/CartesianChart/CartesianChart.tsx+++ b/frontend/src/metabase/visualizations/visualizations/CartesianChart/CartesianChart.tsx@@ -127,21 +127,25 @@ function CartesianChartInner(props: VisualizationProps) {);const hasLegend = !hideLegend && legendItems.length > 0;- const handleInit = useCallback((chart: EChartsType) => {- chartRef.current = chart;- setChartInstance(chart);+ const handleInit = useCallback(+ (chart: EChartsType) => {+ chartRef.current = chart;+ setChartInstance(chart);- // HACK: clip paths cause glitches in Safari on multiseries line charts on dashboards (metabase#51383)- if (isWebkit()) {- chartRef.current.on("finished", () => {- const svg = containerRef.current?.querySelector("svg");- if (svg) {- const clipPaths = svg.querySelectorAll('defs > clipPath[id^="zr"]');- clipPaths.forEach((cp) => cp.setAttribute("id", ""));- }- });- }- }, []);+ // HACK: clip paths cause glitches in Safari on multiseries line charts on dashboards (metabase#51383)+ // Waterfall renders a custom series that relies on clipping, so skip this hack in that case (metabase#82032)+ if (isWebkit() && card.display !== "waterfall") {+ chartRef.current.on("finished", () => {+ const svg = containerRef.current?.querySelector("svg");+ if (svg) {+ const clipPaths = svg.querySelectorAll('defs > clipPath[id^="zr"]');+ clipPaths.forEach((cp) => cp.setAttribute("id", ""));+ }+ });+ }+ },+ [card.display],+ );const handleToggleSeriesVisibility = useCallback((event: MouseEvent, seriesIndex: number) => {