Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

add tracking for stack series (#72986)

Nick Fitzpatrick030b4882245d
diff --git a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
index 2510a4dc8b9..e63576b276f 100644
--- a/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/metrics-explorer.cy.spec.ts
@@ -1540,6 +1540,10 @@ describe("scenarios > metrics > explorer", () => {
H.MetricsViewer.assertVizType("Line");
cy.findByTestId("chart-layout-picker").should("be.visible");
cy.findByLabelText("Stack layout").click();
+ H.expectUnstructuredSnowplowEvent({
+ event: "stack_series_enabled",
+ triggered_from: "metrics_viewer",
+ });
cy.log("should split the chart into separate panels");
H.splitPanelAxisLines().should("have.length", 2);
diff --git a/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js b/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js
index 0965bc15ca2..26f73424d15 100644
--- a/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-charts/line_chart.cy.spec.js
@@ -740,90 +740,107 @@ describe("scenarios > visualizations > line chart", () => {
});
});
- it("should split series into panels and render each series in its own panel", () => {
- H.visitQuestionAdhoc({
- dataset_query: {
- type: "query",
- query: {
- "source-table": ORDERS_ID,
- aggregation: [
- ["sum", ["field", ORDERS.TOTAL, null]],
- ["avg", ["field", ORDERS.QUANTITY, null]],
- ],
- breakout: [
- ["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }],
- ],
- },
- database: SAMPLE_DB_ID,
- },
- display: "line",
+ describe("with tracking", () => {
+ beforeEach(() => {
+ cy.signInAsAdmin();
+ H.resetSnowplow();
+ H.enableTracking();
});
- cy.findAllByTestId("legend-item").should("have.length", 2);
-
- H.openVizSettingsSidebar();
- H.leftSidebar().within(() => {
- cy.findByText("Display").click();
- cy.findByText("Stack series").click();
+ afterEach(() => {
+ H.expectNoBadSnowplowEvents();
});
- H.echartsContainer().within(() => {
- cy.findByText("60,000").should("be.visible");
- cy.findByText("8").should("be.visible");
- });
+ it("should split series into panels and render each series in its own panel", () => {
+ H.visitQuestionAdhoc({
+ dataset_query: {
+ type: "query",
+ query: {
+ "source-table": ORDERS_ID,
+ aggregation: [
+ ["sum", ["field", ORDERS.TOTAL, null]],
+ ["avg", ["field", ORDERS.QUANTITY, null]],
+ ],
+ breakout: [
+ ["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }],
+ ],
+ },
+ database: SAMPLE_DB_ID,
+ },
+ display: "line",
+ });
- H.splitPanelAxisLines().should("have.length", 2);
+ cy.findAllByTestId("legend-item").should("have.length", 2);
- H.cartesianChartCircleWithColor("#88BF4D");
- H.cartesianChartCircleWithColor("#A989C5");
+ H.openVizSettingsSidebar();
+ H.leftSidebar().within(() => {
+ cy.findByText("Display").click();
+ cy.findByText("Stack series").click();
+ });
- // Change series color while split panels are active
- H.leftSidebar().findByText("Data").click();
- H.openSeriesSettings("Sum of Total");
+ H.expectUnstructuredSnowplowEvent({
+ event: "stack_series_enabled",
+ triggered_from: "viz_settings",
+ });
- H.popover().within(() => {
- cy.findByTestId("color-selector-button").button().click();
- });
+ H.echartsContainer().within(() => {
+ cy.findByText("60,000").should("be.visible");
+ cy.findByText("8").should("be.visible");
+ });
+
+ H.splitPanelAxisLines().should("have.length", 2);
- H.popover()
- .should("have.length", 2)
- .last()
- .within(() => {
- cy.findByLabelText("#EF8C8C").realClick();
+ H.cartesianChartCircleWithColor("#88BF4D");
+ H.cartesianChartCircleWithColor("#A989C5");
+
+ // Change series color while split panels are active
+ H.leftSidebar().findByText("Data").click();
+ H.openSeriesSettings("Sum of Total");
+
+ H.popover().within(() => {
+ cy.findByTestId("color-selector-button").button().click();
});
- H.popover().within(() => {
- cy.icon("bar").click();
- });
+ H.popover()
+ .should("have.length", 2)
+ .last()
+ .within(() => {
+ cy.findByLabelText("#EF8C8C").realClick();
+ });
- H.popover().within(() => {
- cy.findByText("Formatting").click();
- cy.findByPlaceholderText("$").type("$").blur();
- });
+ H.popover().within(() => {
+ cy.icon("bar").click();
+ });
- H.leftSidebar().within(() => {
- cy.button("Done").click();
- });
+ H.popover().within(() => {
+ cy.findByText("Formatting").click();
+ cy.findByPlaceholderText("$").type("$").blur();
+ });
- H.echartsContainer().findByText("$60,000").should("be.visible");
+ H.leftSidebar().within(() => {
+ cy.button("Done").click();
+ });
- // Tooltip
- H.cartesianChartCircle().first().trigger("mousemove");
- H.assertEChartsTooltip({
- rows: [
- { name: "Sum of Total", value: "$52.76" },
- { name: "Average of Quantity", value: "2" },
- ],
- blurAfter: true,
- });
+ H.echartsContainer().findByText("$60,000").should("be.visible");
- // Brush
- cy.findByTestId("query-visualization-root")
- .trigger("mousedown", 180, 200)
- .trigger("mousemove", 180, 200)
- .trigger("mouseup", 400, 200);
+ // Tooltip
+ H.cartesianChartCircle().first().trigger("mousemove");
+ H.assertEChartsTooltip({
+ rows: [
+ { name: "Sum of Total", value: "$52.76" },
+ { name: "Average of Quantity", value: "2" },
+ ],
+ blurAfter: true,
+ });
- H.chartPathWithFillColor("#EF8C8C").should("be.visible");
- H.cartesianChartCircleWithColor("#A989C5");
+ // Brush
+ cy.findByTestId("query-visualization-root")
+ .trigger("mousedown", 180, 200)
+ .trigger("mousemove", 180, 200)
+ .trigger("mouseup", 400, 200);
+
+ H.chartPathWithFillColor("#EF8C8C").should("be.visible");
+ H.cartesianChartCircleWithColor("#A989C5");
+ });
});
});
diff --git a/frontend/src/metabase/metrics-viewer/analytics.ts b/frontend/src/metabase/metrics-viewer/analytics.ts
index 270b575b4e6..81953f1d3f3 100644
--- a/frontend/src/metabase/metrics-viewer/analytics.ts
+++ b/frontend/src/metabase/metrics-viewer/analytics.ts
@@ -64,3 +64,10 @@ export const trackMetricsViewerDimensionTabRemoved = () => {
event: "metrics_viewer_dimension_tab_removed",
});
};
+
+export const trackStackedSeriesEnabled = () => {
+ trackSimpleEvent({
+ event: "stack_series_enabled",
+ triggered_from: "metrics_viewer",
+ });
+};
diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/ChartLayoutPicker/ChartLayoutPicker.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/ChartLayoutPicker/ChartLayoutPicker.tsx
index dc7a4e987e4..e78c42b699d 100644
--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/ChartLayoutPicker/ChartLayoutPicker.tsx
+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/ChartLayoutPicker/ChartLayoutPicker.tsx
@@ -1,5 +1,6 @@
import { t } from "ttag";
+import { trackStackedSeriesEnabled } from "metabase/metrics-viewer/analytics";
import { ActionIcon, Flex, Icon, Tooltip } from "metabase/ui";
import S from "./ChartLayoutPicker.module.css";
@@ -41,7 +42,10 @@ export function ChartLayoutPicker({
w="2rem"
variant={isStacked ? "filled" : "subtle"}
bg={isStacked ? "background-primary" : undefined}
- onClick={() => onToggle(true)}
+ onClick={() => {
+ onToggle(true);
+ trackStackedSeriesEnabled();
+ }}
aria-label={t`Stack layout`}
className={isStacked ? S.selected : undefined}
>
diff --git a/frontend/src/metabase/visualizations/analytics.ts b/frontend/src/metabase/visualizations/analytics.ts
index 1f023b14406..512349c381e 100644
--- a/frontend/src/metabase/visualizations/analytics.ts
+++ b/frontend/src/metabase/visualizations/analytics.ts
@@ -22,3 +22,10 @@ export const trackClickActionPerformed = (action: RegularClickAction) => {
});
}
};
+
+export const trackStackedSeriesEnabled = () => {
+ trackSimpleEvent({
+ event: "stack_series_enabled",
+ triggered_from: "viz_settings",
+ });
+};
diff --git a/frontend/src/metabase/visualizations/lib/settings/graph.ts b/frontend/src/metabase/visualizations/lib/settings/graph.ts
index 171e74f5b1b..b6c2f815609 100644
--- a/frontend/src/metabase/visualizations/lib/settings/graph.ts
+++ b/frontend/src/metabase/visualizations/lib/settings/graph.ts
@@ -6,6 +6,7 @@ import {
getMaxDimensionsSupported,
getMaxMetricsSupported,
} from "metabase/visualizations";
+import { trackStackedSeriesEnabled } from "metabase/visualizations/analytics";
import {
ChartSettingEnumToggle,
type ChartSettingEnumToggleProps,
@@ -403,6 +404,11 @@ export const SPLIT_PANELS_SETTINGS: VisualizationSettingsDefinitions = {
return visibleDisplays.length <= 1;
},
readDependencies: ["graph.metrics", "graph.dimensions", "series"],
+ onUpdate: (value) => {
+ if (value === true) {
+ trackStackedSeriesEnabled();
+ }
+ },
},
};