Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

deleted database handling for transforms (#74829)

Nicola Mometto04bfeb20f60b
diff --git a/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts b/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts
index feb0352f728..a40471eeeb0 100644
--- a/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts
+++ b/e2e/test/scenarios/admin/database-routing/database-routing-admin.cy.spec.ts
@@ -179,7 +179,7 @@ describe("admin > database > database routing", () => {
cy.findByTestId("database-name-confirmation-input").type(
"Destination DB 1 Updated",
);
- cy.button("Delete").click();
+ cy.button("Delete this DB connection").click();
cy.wait("@deleteDatabase");
});
dbRoutingSection()
diff --git a/e2e/test/scenarios/admin/databases.cy.spec.js b/e2e/test/scenarios/admin/databases.cy.spec.js
index e0228f5a548..d83e142b1e6 100644
--- a/e2e/test/scenarios/admin/databases.cy.spec.js
+++ b/e2e/test/scenarios/admin/databases.cy.spec.js
@@ -866,7 +866,7 @@ describe("scenarios > admin > databases > sample database", () => {
});
H.modal().within(() => {
- cy.button("Delete this content and the DB connection")
+ cy.button("Delete this DB connection")
.as("deleteButton")
.should("be.disabled");
cy.findByLabelText(/Delete [0-9]* saved questions?/)
@@ -886,7 +886,7 @@ describe("scenarios > admin > databases > sample database", () => {
.click()
.should("be.checked");
cy.findByText(
- "This will delete every saved question, model, metric, and segment you’ve made that uses this data, and can’t be undone!",
+ "This will delete every saved question, model, metric, and segment you’ve made that uses this data, and can’t be undone. Transforms that use this database won’t be deleted, but they will stop working.",
);
cy.get("@deleteButton").should("be.disabled");
@@ -942,7 +942,7 @@ describe("scenarios > admin > databases > sample database", () => {
cy.findByTestId("database-name-confirmation-input").type(
"Sample Database",
);
- cy.findByText("Delete this content and the DB connection").click();
+ cy.findByText("Delete this DB connection").click();
cy.wait("@deleteDatabase");
});
diff --git a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
index fe1cd63ec07..17e62c66c20 100644
--- a/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
+++ b/e2e/test/scenarios/data-studio/transforms/transforms.cy.spec.ts
@@ -1820,6 +1820,66 @@ LIMIT
});
});
+ describe("disconnected database", () => {
+ it("should warn about transforms when deleting a database and show disconnected banner on transform pages", () => {
+ cy.log("create a transform");
+ createMbqlTransform({ visitTransform: false });
+
+ cy.log("go to admin and delete the writable database");
+ cy.intercept("GET", "/api/database/*/usage_info").as("usageInfo");
+ cy.intercept("DELETE", "/api/database/*").as("deleteDb");
+ cy.visit(`/admin/databases/${WRITABLE_DB_ID}`);
+ cy.button("Remove this database").click();
+ cy.wait("@usageInfo");
+
+ cy.log(
+ "verify the delete modal warns about transforms that will stop working",
+ );
+ H.modal().within(() => {
+ cy.findByLabelText(/1 transform will stop working/)
+ .should("not.be.checked")
+ .click()
+ .should("be.checked");
+ cy.findByTestId("database-name-confirmation-input").type(DB_NAME);
+ cy.findByText("Delete this DB connection").click();
+ cy.wait("@deleteDb");
+ });
+
+ cy.log(
+ "visit the transform query page and verify the disconnected banner",
+ );
+ cy.visit("/data-studio/transforms/1");
+ verifyDisconnectedDatabaseBanner();
+
+ cy.log("edit definition button should not be visible");
+ H.DataStudio.Transforms.editDefinitionButton().should("not.exist");
+
+ cy.log(
+ "visit the run page and verify the disconnected banner is visible",
+ );
+ H.DataStudio.Transforms.runTab().click();
+ verifyDisconnectedDatabaseBanner();
+
+ cy.log(
+ "visit the settings page and verify the disconnected banner is visible",
+ );
+ H.DataStudio.Transforms.settingsTab().click();
+ verifyDisconnectedDatabaseBanner();
+
+ cy.log(
+ "visit the inspect page and verify the disconnected banner is visible",
+ );
+ H.DataStudio.Transforms.inspectTab().click();
+ verifyDisconnectedDatabaseBanner();
+
+ cy.log(
+ "visit the dependencies page and verify the disconnected banner is visible",
+ );
+ H.DataStudio.Transforms.dependenciesTab().click();
+ verifyDisconnectedDatabaseBanner();
+ });
+ });
+
describe("cancelation", () => {
function createSlowTransform(seconds: number = 100) {
H.createTransform(
@@ -3805,6 +3865,16 @@ describe("scenarios > admin > transforms", () => {
});
});
+function verifyDisconnectedDatabaseBanner() {
+ return cy
+ .findByRole("alert")
+ .should("be.visible")
+ .and(
+ "contain.text",
+ "The database this transform depends on has been disconnected",
+ );
+}
+
function getTransformsNavLink() {
return H.DataStudio.nav().findByRole("link", { name: "Transforms" });
}
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/events.clj b/enterprise/backend/src/metabase_enterprise/dependencies/events.clj
index 98a90d90b9b..4225d2fea0d 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/events.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/events.clj
@@ -1,12 +1,13 @@
(ns metabase-enterprise.dependencies.events
(:require
[metabase-enterprise.dependencies.findings :as deps.findings]
+ [metabase-enterprise.dependencies.models.analysis-finding :as deps.analysis-finding]
[metabase-enterprise.dependencies.models.dependency :as models.dependency]
[metabase-enterprise.dependencies.models.dependency-status :as deps.dependency-status]
[metabase-enterprise.dependencies.task.backfill :as task.backfill]
[metabase-enterprise.dependencies.task.entity-check :as task.entity-check]
[metabase.events.core :as events]
- [metabase.premium-features.core :as premium-features]
+ [metabase.premium-features.core :as premium-features :refer [defenterprise]]
[metabase.util.log :as log]
[methodical.core :as methodical]
[toucan2.core :as t2]))
@@ -339,3 +340,16 @@
(when (premium-features/has-feature? :dependencies)
(when (deps.findings/mark-immediate-dependents-stale! :table (:table_id object))
(task.entity-check/trigger-entity-check-job!))))
+
+;; ### Database Deletion (orphans transforms)
+;; Transforms whose `source_database_id` matches the database being deleted survive the delete
+;; but their existing `analysis_finding` rows still say "OK". Mark them stale here so the entity-check
+;; job re-runs and surfaces them on `/data-studio/dependency-diagnostics/broken`.
+(defenterprise mark-transforms-stale-on-database-delete!
+ "Enterprise implementation: mark all transforms whose source database is being deleted as stale
+ for dependency re-analysis. See the OSS declaration in `metabase.warehouses.models.database`."
+ :feature :dependencies
+ [db-id]
+ (when-let [transform-ids (not-empty (t2/select-pks-set :model/Transform :source_database_id db-id))]
+ (deps.analysis-finding/mark-stale! :transform transform-ids)
+ (task.entity-check/trigger-entity-check-job!)))
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/findings.clj b/enterprise/backend/src/metabase_enterprise/dependencies/findings.clj
index c0282ae94e9..9652bcce07e 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/findings.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/findings.clj
@@ -29,6 +29,21 @@
[toucan-instance]
(some-> toucan-instance :definition lib/database-id))
+(defmulti ^:private pre-analysis-errors
+ "Return a (possibly empty) sequence of errors detected without running the full analyzer. When
+ non-empty, the entity is recorded broken with these errors and the regular analysis is skipped.
+ Use this for structural failures e.g. an orphan Transform whose source database has been deleted."
+ {:arglists '([toucan-instance])}
+ t2/model)
+
+(defmethod pre-analysis-errors :default [_] nil)
+
+(defmethod pre-analysis-errors :model/Transform
+ [{db-id :source_database_id id :id}]
+ (when (nil? db-id)
+ [(-> (lib/validation-exception-error "Source database for this transform has been deleted.")
+ (assoc :source-entity-type :transform :source-entity-id id))]))
+
(defn upsert-analysis!
"Given a Toucan entity, run its analysis and write the results into `:model/AnalysisFinding`.
@@ -37,15 +52,19 @@
(when-not (lib-be/metadata-provider-cache)
(throw (ex-info "FIXME: deps.findings/upsert-analysis! ran without reusing `MetadataProvider`s"
{:instance toucan-instance})))
- (when-let [db-id (instance-db-id toucan-instance)]
- (let [mp (lib-be/application-database-metadata-provider db-id)
- model (t2/model toucan-instance)
- results (try (deps.analysis/check-entity mp (deps.dependency-types/model->dependency-type model) (:id toucan-instance))
- (catch Exception e
- (log/error e "Error analyzing entity")
- [(lib/validation-exception-error (.getMessage e))]))
- success (empty? results)]
- (deps.analysis-finding/upsert-analysis! (deps.dependency-types/model->dependency-type model) (:id toucan-instance) success results))))
+ (let [model (t2/model toucan-instance)
+ entity-type (deps.dependency-types/model->dependency-type model)
+ instance-id (:id toucan-instance)]
+ (if-let [errors (seq (pre-analysis-errors toucan-instance))]
+ (deps.analysis-finding/upsert-analysis! entity-type instance-id false errors)
+ (when-let [db-id (instance-db-id toucan-instance)]
+ (let [mp (lib-be/application-database-metadata-provider db-id)
+ results (try (deps.analysis/check-entity mp entity-type instance-id)
+ (catch Exception e
+ (log/error e "Error analyzing entity")
+ [(lib/validation-exception-error (.getMessage e))]))
+ success (empty? results)]
+ (deps.analysis-finding/upsert-analysis! entity-type instance-id success results))))))
(defn analyze-instances!
"Given a series of toucan entities, upsert analyses for all of them and catch errors."
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
index 3fefd1545e4..a9a759b83f9 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/events_test.clj
@@ -334,6 +334,49 @@
:to_entity_id (mt/id :orders)}]
(t2/select :model/Dependency :from_entity_id transform-id :from_entity_type :transform)))))))))
+(deftest ^:sequential database-delete-marks-source-transforms-stale-test
+ (testing "deleting a database marks its source transforms' analysis findings stale so they surface on /dependency-diagnostics/broken (GDGT-2447)"
+ (run-with-dependencies-setup!
+ (fn [_mp]
+ (mt/with-temp [:model/Database {db-id :id} {}
+ :model/Transform {transform-id :id}
+ {:source {:type :query
+ :query {:database db-id
+ :type :native
+ :native {:query "SELECT 1"}}}
+ :target {:schema "public" :name "out" :type :table}}
+ :model/AnalysisFinding _ {:analyzed_entity_type :transform
+ :analyzed_entity_id transform-id
+ :result true
+ :stale false
+ :analysis_version models.analysis-finding/*current-analysis-finding-version*
+ :analyzed_at :%now}]
+ (is (false? (t2/select-one-fn :stale :model/AnalysisFinding
+ :analyzed_entity_type :transform
+ :analyzed_entity_id transform-id))
+ "baseline: existing finding is fresh")
+ (t2/delete! :model/Database db-id)
+ (is (nil? (t2/select-one :model/Database db-id))
+ "the Database row is actually gone")
+ (is (true? (t2/select-one-fn :stale :model/AnalysisFinding
+ :analyzed_entity_type :transform
+ :analyzed_entity_id transform-id))
+ "after db-delete the transform's finding is marked stale")
+ (testing "and re-running the entity-check job flips :result false so the transform shows on broken-diagnostics"
+ (#'task.entity-check/check-entities!)
+ (let [{:keys [stale result]} (t2/select-one :model/AnalysisFinding
+ :analyzed_entity_type :transform
+ :analyzed_entity_id transform-id)]
+ (is (false? stale))
+ (is (false? result)))
+ (testing "an analysis_finding_error row points the transform at itself so the diagnostics page (`/graph/breaking`) surfaces it"
+ (is (=? {:source_entity_type :transform
+ :source_entity_id transform-id
+ :error_type :validation-exception-error}
+ (t2/select-one :model/AnalysisFindingError
+ :analyzed_entity_type :transform
+ :analyzed_entity_id transform-id))))))))))
+
(deftest ^:sequential transform-run-updates-dependencies-test
(testing "transform run events trigger dependency calculations"
(run-with-dependencies-setup!
diff --git a/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj b/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj
index 212ab8a4c3a..e55590d16d9 100644
--- a/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj
@@ -2272,6 +2272,47 @@
(is (= #{transform-eid python-transform-eid}
(ids-by-model "Transform" (extract/extract {}))))))))))
+(deftest transform-with-null-source-database-extract-test
+ (testing "A transform whose source database has been deleted serializes as a tombstone (GDGT-2447)"
+ (mt/with-premium-features #{:transforms-basic}
+ (mt/with-empty-h2-app-db!
+ (ts/with-temp-dpc [:model/Database {db-id :id} {:name "Soon-to-be-deleted DB"}
+ :model/Transform {transform-id :id transform-eid :entity_id}
+ {:name "Orphan Transform"
+ :entity_id "orphanXxxxxxxxxxxxxxx"
+ :source {:type "query"
+ :query {:database db-id
+ :type "native"
+ :native {:query "SELECT 1"}}}
+ :target {:database db-id
+ :type "table"
+ :schema "public"
+ :name "orphan_target"}}]
+ ;; Delete the database — ON DELETE SET NULL nulls source_database_id and target_db_id.
+ (t2/delete! :model/Database db-id)
+ (let [reloaded (t2/hydrate (t2/select-one :model/Transform :id transform-id) :tags)
+ ser (serdes/extract-one "Transform" {} reloaded)]
+ (is (nil? (:source_database_id reloaded))
+ "Database deletion should have nulled the column")
+ (testing "exported entity carries a nil source_database_id"
+ (is (=? {:serdes/meta [{:model "Transform" :id transform-eid}]
+ :name "Orphan Transform"}
+ ser))
+ (is (nil? (:source_database_id ser))))
+ (testing "exported source is marked :serdes/unresolved with the dead :database ref nulled"
+ ;; The :database slot is nulled because the numeric id refers to a now-deleted database —
+ ;; keeping it would make the destination instance's before-insert hook bind
+ ;; source_database_id to a stale id and crash the FK.
+ (is (true? (get-in ser [:source :serdes/unresolved])))
+ (is (nil? (get-in ser [:source :query :database]))))
+ (testing "the native SQL body is preserved verbatim as a breadcrumb"
+ ;; `lib-be/normalize-query` rewrites the raw query to MBQL5 (`:stages [...]`) at read time,
+ ;; so the native text now lives under `:stages [0] :native`.
+ (is (= "SELECT 1" (get-in ser [:source :query :stages 0 :native]))))
+ (testing "Transform/dependencies does not emit a Database dep when source_database_id is nil"
+ (is (not-any? #(some (fn [{:keys [model]}] (= "Database" model)) %)
+ (serdes/dependencies (assoc reloaded :tags [])))))))))))
+
(deftest table-with-transform-id-dependency-test
(testing "Table created by a Transform declares the Transform as a serdes dependency (GDGT-2444)"
(mt/with-premium-features #{:transforms-basic}
diff --git a/enterprise/backend/test/metabase_enterprise/serialization/v2/load_test.clj b/enterprise/backend/test/metabase_enterprise/serialization/v2/load_test.clj
index 7677f6445bd..9d4bfe34b25 100644
--- a/enterprise/backend/test/metabase_enterprise/serialization/v2/load_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/serialization/v2/load_test.clj
@@ -2160,6 +2160,55 @@
(is (some? transform))
(is (= (:id db) (:source_database_id transform)))))))))))
+(deftest transform-with-deleted-source-database-load-test
+ (testing "An orphaned transform (source database was deleted before export) round-trips through serdes as a tombstone (GDGT-2447)"
+ (mt/with-premium-features #{:transforms-basic}
+ (let [serialized (atom nil)]
+ (ts/with-dbs [source-db dest-db]
+ (ts/with-db source-db
+ (t2/delete! :model/TransformTag)
+ (let [db (ts/create! :model/Database :name "soon-to-be-deleted")
+ table (ts/create! :model/Table :name "customers" :db_id (:id db))
+ coll (ts/create! :model/Collection :name "Transform Collection" :namespace :transforms)
+ _ (ts/create! :model/Transform
+ :name "Orphan Transform"
+ :description "Transform whose source DB will be deleted"
+ :collection_id (:id coll)
+ :source {:query (mbql5-query (:id db) (:id table))
+ :type "query"}
+ :target {:database (:id db)
+ :type "table"
+ :schema "public"
+ :name "orphan_target"})]
+ ;; Deleting the database cascade-SET-NULLs source_database_id (FK action)
+ ;; AND cascade-deletes the Table (Field FKs) — the transform survives as a tombstone.
+ (t2/delete! :model/Database :name "soon-to-be-deleted")
+ (reset! serialized (into [] (serdes.extract/extract {})))))
+ (let [minimal (mapv (fn [entity]
+ (if (= "Transform" (-> entity :serdes/meta last :model))
+ (select-keys entity [:serdes/meta :entity_id :name
+ :source :target])
+ entity))
+ @serialized)]
+ (testing "the extracted transform carries the :serdes/unresolved flag and verbatim body"
+ (let [extracted (first (filter #(= "Transform" (-> % :serdes/meta last :model)) minimal))]
+ (is (some? extracted))
+ (is (true? (get-in extracted [:source :serdes/unresolved])))
+ ;; native query text is preserved verbatim
+ (is (some? (get-in extracted [:source :query])))))
+ (ts/with-db dest-db
+ (t2/delete! :model/TransformTag)
+ (serdes.load/load-metabase! (ingestion-in-memory minimal))
+ (let [transform (t2/select-one :model/Transform :name "Orphan Transform")]
+ (testing "transform round-trips and ends up as a tombstone in the destination instance"
+ (is (some? transform))
+ (is (nil? (:source_database_id transform))
+ "source_database_id should be nil — there's no DB to bind to")
+ (is (not (contains? (:source transform) :serdes/unresolved))
+ "the :serdes/unresolved marker should have been stripped on import")
+ (is (some? (get-in transform [:source :query]))
+ "the query body should be preserved as a breadcrumb"))))))))))
+
(deftest table-created-by-transform-load-test
(testing "Table created by a Transform can be imported via serialization (GDGT-2444)"
(mt/with-premium-features #{:transforms-basic}
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyDiagnostics/constants.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyDiagnostics/constants.ts
index 05445a6b52f..5fe7d18f895 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyDiagnostics/constants.ts
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyDiagnostics/constants.ts
@@ -7,6 +7,7 @@ export const BROKEN_GROUP_TYPES: DependencyGroupType[] = [
"table",
"question",
"model",
+ "transform",
];
export const BROKEN_DEPENDENTS_GROUP_TYPES: DependencyGroupType[] = [
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyDiagnosticsPage/DependencyDiagnosticsPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyDiagnosticsPage/DependencyDiagnosticsPage.unit.spec.tsx
index 97c8d6eb0a7..3a727530262 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyDiagnosticsPage/DependencyDiagnosticsPage.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyDiagnosticsPage/DependencyDiagnosticsPage.unit.spec.tsx
@@ -151,7 +151,7 @@ describe("DependencyDiagnosticsPage", () => {
const { history } = setup({
mode: "broken",
nodes: CARD_NODES,
- urlParams: { groupTypes: ["table", "question"] },
+ urlParams: { groupTypes: ["table", "question", "transform"] },
});
await waitForListToLoad();
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/TransformInspectPage.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/TransformInspectPage.tsx
index 96c5f0c78e8..1327650bf36 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/TransformInspectPage.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms-inspector/pages/TransformInspectPage/TransformInspectPage.tsx
@@ -1,11 +1,15 @@
import type { Location } from "history";
+import { match } from "ts-pattern";
import { t } from "ttag";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
import { PageContainer } from "metabase/data-studio/common/components/PageContainer";
+import { TransformDisconnectedDatabaseBanner } from "metabase/transforms/components/TransformDisconnectedDatabaseBanner";
import { TransformHeader } from "metabase/transforms/components/TransformHeader";
+import { useTransformPermissions } from "metabase/transforms/hooks/use-transform-permissions";
import { useTransformWithPolling } from "metabase/transforms/hooks/use-transform-with-polling";
import { RunSection } from "metabase/transforms/pages/TransformRunPage/RunSection";
+import { isMissingSourceDatabase } from "metabase/transforms/utils";
import { Alert, Center, Icon, Text } from "metabase/ui";
import * as Urls from "metabase/urls";
@@ -22,8 +26,16 @@ export const TransformInspectPage = ({
location,
}: TransformInspectPageProps) => {
const transformId = Urls.extractEntityId(params.transformId);
+ const {
+ transform,
+ isLoading: isLoadingTransform,
+ error: transformError,
+ } = useTransformWithPolling(transformId);
+ const { readOnly, isLoadingDatabases, databasesError } =
+ useTransformPermissions({ transform });
- const { transform, isLoading, error } = useTransformWithPolling(transformId);
+ const isLoading = isLoadingTransform || isLoadingDatabases;
+ const error = transformError || databasesError;
if (isLoading || error || !transform) {
return (
@@ -36,20 +48,32 @@ export const TransformInspectPage = ({
return (
<PageContainer data-testid="transform-inspect-content">
<TransformHeader transform={transform} />
- {transform.last_run?.status !== "succeeded" ? (
- <>
- <Alert color="core-brand" icon={<Icon name="info" />}>
- <Text>{t`To inspect the transform you need to run it first.`}</Text>
- </Alert>
- <RunSection transform={transform} noTitle={true} />
- </>
- ) : (
- <InspectorContent
- transform={transform}
- params={params}
- location={location}
- />
- )}
+ {match({
+ hasSucceeded: transform.last_run?.status === "succeeded",
+ isMissingSourceDatabase: isMissingSourceDatabase(transform),
+ })
+ .with({ isMissingSourceDatabase: true }, () => (
+ <TransformDisconnectedDatabaseBanner transform={transform} />
+ ))
+ .with({ hasSucceeded: false }, () => (
+ <>
+ <Alert color="core-brand" icon={<Icon name="info" />}>
+ <Text>{t`To inspect the transform you need to run it first.`}</Text>
+ </Alert>
+ <RunSection
+ transform={transform}
+ noTitle={true}
+ readOnly={readOnly}
+ />
+ </>
+ ))
+ .otherwise(() => (
+ <InspectorContent
+ transform={transform}
+ params={params}
+ location={location}
+ />
+ ))}
</PageContainer>
);
};
diff --git a/frontend/src/metabase-types/api/database.ts b/frontend/src/metabase-types/api/database.ts
index d4bdcbde8d4..b9dd5ed8fcb 100644
--- a/frontend/src/metabase-types/api/database.ts
+++ b/frontend/src/metabase-types/api/database.ts
@@ -122,6 +122,7 @@ export interface DatabaseUsageInfo {
dataset: number;
metric: number;
segment: number;
+ transform: number;
}
export interface GetDatabaseRequest {
diff --git a/frontend/src/metabase-types/api/transform.ts b/frontend/src/metabase-types/api/transform.ts
index 39b1eba57a1..88b0c62d52b 100644
--- a/frontend/src/metabase-types/api/transform.ts
+++ b/frontend/src/metabase-types/api/transform.ts
@@ -36,6 +36,11 @@ export type Transform = {
created_at: string;
updated_at: string;
source_readable: boolean;
+ can_read?: boolean;
+ can_write?: boolean;
+ can_execute?: boolean;
+
+ source_database_id?: DatabaseId | null;
// true when transform was deleted but still referenced by runs
deleted?: boolean;
diff --git a/frontend/src/metabase/admin/databases/components/ContentRemovalConfirmation/ContentRemovalConfirmation.tsx b/frontend/src/metabase/admin/databases/components/ContentRemovalConfirmation/ContentRemovalConfirmation.tsx
index 102a110c401..5914983ac3c 100644
--- a/frontend/src/metabase/admin/databases/components/ContentRemovalConfirmation/ContentRemovalConfirmation.tsx
+++ b/frontend/src/metabase/admin/databases/components/ContentRemovalConfirmation/ContentRemovalConfirmation.tsx
@@ -13,13 +13,14 @@ const ContentRemovalConfirmation = ({
usageInfo,
onChange,
}: ContentRemovalConfirmationProps) => {
- const { question, dataset, metric, segment } = usageInfo;
+ const { question, dataset, metric, segment, transform } = usageInfo;
const [confirmations, setConfirmations] = useState({
question: question === 0,
dataset: dataset === 0,
metric: metric === 0,
segment: segment === 0,
+ transform: transform === 0,
});
const handleChange = (e: React.ChangeEvent<HTMLInputElement>) => {
@@ -82,6 +83,18 @@ const ContentRemovalConfirmation = ({
onChange={handleChange}
/>
)}
+ {transform > 0 && (
+ <Checkbox
+ label={ngettext(
+ msgid`${transform} transform will stop working`,
+ `${transform} transforms will stop working`,
+ transform,
+ )}
+ name="transform"
+ checked={confirmations["transform"]}
+ onChange={handleChange}
+ />
+ )}
</Stack>
);
};
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseConnectionInfoSection/DatabaseConnectionInfoSection.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseConnectionInfoSection/DatabaseConnectionInfoSection.unit.spec.tsx
index ea784fa59ae..5677db6f09e 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseConnectionInfoSection/DatabaseConnectionInfoSection.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseConnectionInfoSection/DatabaseConnectionInfoSection.unit.spec.tsx
@@ -37,6 +37,7 @@ function setup({
dataset: 0,
metric: 0,
segment: 0,
+ transform: 0,
});
mockEndpointsCb?.(database);
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx
index 1f44a631fcd..a561a78672e 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx
@@ -77,7 +77,7 @@ export const DatabaseDangerZoneSection = ({
<DeleteDatabaseModal
opened={isDeleteDbModalOpen}
title={t`Delete the ${database.name} database?`}
- defaultDatabaseRemovalMessage={t`This will delete every saved question, model, metric, and segment you’ve made that uses this data, and can’t be undone!`}
+ defaultDatabaseRemovalMessage={t`This will delete every saved question, model, metric, and segment you’ve made that uses this data, and can’t be undone. Transforms that use this database won’t be deleted, but they will stop working.`}
database={database}
onClose={deleteDbModal.close}
onDelete={handleDeleteDatabase}
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
index c776cbda557..be620858a22 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.unit.spec.tsx
@@ -47,6 +47,7 @@ function setup({
dataset: 0,
metric: 0,
segment: 0,
+ transform: 0,
});
const deleteDatabase = jest.fn().mockResolvedValue({});
@@ -140,7 +141,9 @@ describe("DatabaseDangerZoneSection", () => {
database.name,
);
await userEvent.click(
- within(modal).getByRole("button", { name: "Delete" }),
+ within(modal).getByRole("button", {
+ name: "Delete this DB connection",
+ }),
);
await waitFor(() => {
expect(getDiscardFieldValuesConfirmModal()).not.toBeInTheDocument();
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.unit.spec.tsx
index 6fb09581447..64ce3d1e696 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseModelFeaturesSection/DatabaseModelFeaturesSection.unit.spec.tsx
@@ -36,6 +36,7 @@ function setup({
dataset: 0,
metric: 0,
segment: 0,
+ transform: 0,
});
// Using mockResolvedValue since `ActionButton` component
diff --git a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx
index a3f5603b498..aef0828379d 100644
--- a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx
+++ b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx
@@ -102,9 +102,7 @@ export const DeleteDatabaseModal = ({
const canDelete =
(isContentRemovalConfirmed || !hasContent) && isDatabaseNameConfirmed;
- const deleteButtonLabel = hasContent
- ? t`Delete this content and the DB connection`
- : t`Delete`;
+ const deleteButtonLabel = t`Delete this DB connection`;
const errorMessage = getErrorMessage(error);
const hasMoreThanOneEntityType = usageInfo && entityTypesCount(usageInfo) > 1;
diff --git a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
index b433323215c..2804c651334 100644
--- a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.unit.spec.tsx
@@ -16,6 +16,7 @@ const getUsageInfo = (hasContent: boolean) => ({
dataset: hasContent ? 20 : 0,
metric: hasContent ? 30 : 0,
segment: hasContent ? 40 : 0,
+ transform: hasContent ? 50 : 0,
});
const database = { name: "database name", id: 1 } as Database;
@@ -33,7 +34,7 @@ const setup = async ({
opened
title={"Delete the destination database?"}
defaultDatabaseRemovalMessage={
- "Users routed to this database will lose access to every question, model, metric, and segment if you continue."
+ "Users routed to this database will lose access to every question, model, metric, and segment if you continue. Transforms that use this database won’t be deleted, but they will stop working."
}
onClose={jest.fn()}
onDelete={onDelete}
@@ -56,7 +57,9 @@ describe("DeleteDatabaseModal", () => {
it("should allow deleting database without content after confirming its name", async () => {
const { onDelete } = await setup({ hasContent: false });
- const deleteButton = screen.getByRole("button", { name: "Delete" });
+ const deleteButton = screen.getByRole("button", {
+ name: "Delete this DB connection",
+ });
expect(
screen.queryByText("Delete 10 saved questions"),
@@ -80,7 +83,7 @@ describe("DeleteDatabaseModal", () => {
const { onDelete } = await setup({ hasContent: true });
const deleteButton = screen.getByRole("button", {
- name: "Delete this content and the DB connection",
+ name: "Delete this DB connection",
});
expect(deleteButton).toBeDisabled();
@@ -89,6 +92,7 @@ describe("DeleteDatabaseModal", () => {
await userEvent.click(screen.getByText("Delete 20 models"));
await userEvent.click(screen.getByText("Delete 30 metrics"));
await userEvent.click(screen.getByText("Delete 40 segments"));
+ await userEvent.click(screen.getByText("50 transforms will stop working"));
expect(deleteButton).toBeDisabled();
@@ -112,7 +116,9 @@ describe("DeleteDatabaseModal", () => {
},
});
- const deleteButton = screen.getByRole("button", { name: "Delete" });
+ const deleteButton = screen.getByRole("button", {
+ name: "Delete this DB connection",
+ });
await userEvent.type(
screen.getByTestId("database-name-confirmation-input"),
"database name",
diff --git a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.tsx b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.tsx
index 0644241cbe6..b2e2f24aafa 100644
--- a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.tsx
+++ b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.tsx
@@ -1,4 +1,5 @@
import type { ReactNode } from "react";
+import type { WithRouterProps } from "react-router";
import { t } from "ttag";
import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";
@@ -13,12 +14,13 @@ import { getShouldShowTransformsUpsell } from "metabase/transforms/selectors";
import { SectionLayout } from "../../components/SectionLayout";
-type TransformsSectionLayoutProps = {
+type TransformsSectionLayoutProps = WithRouterProps & {
children?: ReactNode;
};
export function TransformsSectionLayout({
children,
+ params,
}: TransformsSectionLayoutProps) {
usePageTitle(t`Transforms`, { titleIndex: 1 });
const shouldShowUpsell = useSelector(getShouldShowTransformsUpsell);
@@ -33,7 +35,16 @@ export function TransformsSectionLayout({
return <EnableTransformsPage />;
}
- if (!isLoadingDatabases && transformsDatabases?.length === 0) {
+ // Transform-detail pages (`/data-studio/transforms/:transformId/...`) must remain reachable
+ // even when no writable database exists, so the analyst can read the SQL/Python body of an
+ // orphaned transform after its source DB has been deleted (GDGT-2447).
+ const isTransformDetailRoute = Boolean(params?.transformId);
+
+ if (
+ !isLoadingDatabases &&
+ transformsDatabases?.length === 0 &&
+ !isTransformDetailRoute
+ ) {
return (
<SectionLayout>
<NoWritableDatabasesEmptyState />
diff --git a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx
index 54aded03920..c7cde117db2 100644
--- a/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx
+++ b/frontend/src/metabase/data-studio/app/pages/TransformsSectionLayout/TransformsSectionLayout.unit.spec.tsx
@@ -92,8 +92,8 @@ const setup = ({
renderWithProviders(
<Route
path={path}
- component={() => (
- <TransformsSectionLayout>
+ component={(props) => (
+ <TransformsSectionLayout {...props}>
<div>List of transforms</div>
</TransformsSectionLayout>
)}
diff --git a/frontend/src/metabase/querying/editor/hooks/use-query-metadata/use-query-metadata.ts b/frontend/src/metabase/querying/editor/hooks/use-query-metadata/use-query-metadata.ts
index 1e1a89512e8..607a4e0bdb8 100644
--- a/frontend/src/metabase/querying/editor/hooks/use-query-metadata/use-query-metadata.ts
+++ b/frontend/src/metabase/querying/editor/hooks/use-query-metadata/use-query-metadata.ts
@@ -1,4 +1,5 @@
import { useEffect, useMemo, useRef } from "react";
+import { t } from "ttag";
import _ from "underscore";
import { useLazyGetAdhocQueryMetadataQuery } from "metabase/api";
@@ -6,7 +7,8 @@ import * as Lib from "metabase-lib";
import type Question from "metabase-lib/v1/Question";
export function useQueryMetadata(question: Question) {
- const [loadMetadata, { error }] = useLazyGetAdhocQueryMetadataQuery();
+ const [loadMetadata, { error, isFetching, isUninitialized }] =
+ useLazyGetAdhocQueryMetadataQuery();
const dependenciesRef = useRef<Lib.DependentItem[]>([]);
const isSourceTableLoaded = useMemo(() => {
@@ -31,8 +33,14 @@ export function useQueryMetadata(question: Question) {
}
}, [question, loadMetadata]);
+ const metadataError =
+ error ??
+ (!isUninitialized && !isFetching && !isSourceTableLoaded
+ ? t`The source database for this query is not available`
+ : undefined);
+
return {
- isLoading: !isSourceTableLoaded,
- error,
+ isLoading: !isSourceTableLoaded && (isFetching || isUninitialized),
+ error: metadataError,
};
}
diff --git a/frontend/src/metabase/transforms/components/TransformDisconnectedDatabaseBanner.tsx b/frontend/src/metabase/transforms/components/TransformDisconnectedDatabaseBanner.tsx
new file mode 100644
index 00000000000..20d5853e302
--- /dev/null
+++ b/frontend/src/metabase/transforms/components/TransformDisconnectedDatabaseBanner.tsx
@@ -0,0 +1,26 @@
+import { t } from "ttag";
+
+import { Alert, Icon, Text } from "metabase/ui";
+import type { Transform } from "metabase-types/api";
+
+import { isMissingSourceDatabase } from "../utils";
+
+export const TransformDisconnectedDatabaseBanner = ({
+ transform,
+}: {
+ transform: Transform;
+}) => {
+ if (!isMissingSourceDatabase(transform)) {
+ return null;
+ }
+
+ return (
+ <Alert
+ color="error"
+ icon={<Icon name="warning" />}
+ data-testid="disconnected-database-banner"
+ >
+ <Text>{t`The database this transform depends on has been disconnected. The transform can't be edited or run.`}</Text>
+ </Alert>
+ );
+};
diff --git a/frontend/src/metabase/transforms/hooks/use-source-state.ts b/frontend/src/metabase/transforms/hooks/use-source-state.ts
index ef67ab22e85..ef958f2efc7 100644
--- a/frontend/src/metabase/transforms/hooks/use-source-state.ts
+++ b/frontend/src/metabase/transforms/hooks/use-source-state.ts
@@ -44,6 +44,12 @@ function normalizeSource(
if (source.type !== "query") {
return source;
}
+ // Orphan: the source database has been deleted (e.g. a serdes-imported
+ // transform whose source database is missing). The body is preserved as a
+ // breadcrumb but cannot be normalized through MLv2 without a database.
+ if (source.query?.database == null) {
+ return source;
+ }
const question = Question.create({ dataset_query: source.query, metadata });
const query = question.query();
diff --git a/frontend/src/metabase/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx b/frontend/src/metabase/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
index 189af1fea97..e4ecc788b48 100644
--- a/frontend/src/metabase/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformDependenciesPage/TransformDependenciesPage.tsx
@@ -8,6 +8,7 @@ import { useTransformPermissions } from "metabase/transforms/hooks/use-transform
import { Card, Center } from "metabase/ui";
import * as Urls from "metabase/urls";
+import { TransformDisconnectedDatabaseBanner } from "../../components/TransformDisconnectedDatabaseBanner";
import { TransformHeader } from "../../components/TransformHeader";
export type TransformDependenciesPageParams = {
@@ -45,6 +46,7 @@ export function TransformDependenciesPage({
return (
<PageContainer data-testid="transforms-dependencies-content">
<TransformHeader transform={transform} readOnly={readOnly} />
+ <TransformDisconnectedDatabaseBanner transform={transform} />
<PLUGIN_DEPENDENCIES.DependencyGraphPageContext.Provider
value={{
baseUrl: Urls.transformDependencies(transform.id),
diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/TransformListPage.tsx b/frontend/src/metabase/transforms/pages/TransformListPage/TransformListPage.tsx
index c00e956c543..aeac5a3cf8a 100644
--- a/frontend/src/metabase/transforms/pages/TransformListPage/TransformListPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformListPage/TransformListPage.tsx
@@ -75,7 +75,7 @@ const countTransforms = (node: TreeNode): number => {
};
const isRowDisabled = (row: Row<TreeNode>) => {
- return row.original.source_readable === false;
+ return row.original.can_read === false;
};
const NODE_ICON_COLORS: Record<TreeNode["nodeType"], ColorName> = {
@@ -161,7 +161,7 @@ export const TransformListPage = ({
url: Urls.transformPythonLibrary({
path: PLUGIN_TRANSFORMS_PYTHON.sharedLibImportPath,
}),
- source_readable: transformsDatabases.length > 0,
+ can_read: transformsDatabases.length > 0,
});
}
return data;
diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/types.ts b/frontend/src/metabase/transforms/pages/TransformListPage/types.ts
index 8fc3df104cc..2a85d4a113e 100644
--- a/frontend/src/metabase/transforms/pages/TransformListPage/types.ts
+++ b/frontend/src/metabase/transforms/pages/TransformListPage/types.ts
@@ -20,7 +20,7 @@ export type TreeNode = {
transformId?: number;
collection?: Collection;
url?: string;
- source_readable?: boolean;
+ can_read?: boolean;
warningTooltip?: string;
};
diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts b/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
index 692ff58edcb..0e0def87350 100644
--- a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
+++ b/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts
@@ -140,7 +140,7 @@ export function buildTreeData(
owner: transform.owner,
owner_email: transform.owner_email,
transformId: transform.id,
- source_readable: transform.source_readable,
+ can_read: transform.can_read,
};
}
diff --git a/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx b/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
index 5320d0a19c7..ddbe63bc99a 100644
--- a/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformQueryPage/TransformQueryPage.tsx
@@ -38,6 +38,7 @@ import {
buildIncrementalTarget,
getInitialValues,
} from "../../components/IncrementalTransform/form";
+import { TransformDisconnectedDatabaseBanner } from "../../components/TransformDisconnectedDatabaseBanner";
import {
TransformEditor,
type TransformEditorProps,
@@ -241,6 +242,7 @@ function TransformQueryPageBody({
isEditMode={isEditMode}
readOnly={readOnly}
/>
+ <TransformDisconnectedDatabaseBanner transform={transform} />
<Box
w="100%"
bg="background-primary"
@@ -251,7 +253,7 @@ function TransformQueryPageBody({
overflow: "hidden",
}}
>
- {!transform.source_readable ? (
+ {transform.can_read === false ? (
<Center h="100%">
<EmptyState
title={t`Sorry, you don't have permission to view this transform.`}
diff --git a/frontend/src/metabase/transforms/pages/TransformRunPage/TransformRunPage.tsx b/frontend/src/metabase/transforms/pages/TransformRunPage/TransformRunPage.tsx
index 8380b70beb1..9cc284177fc 100644
--- a/frontend/src/metabase/transforms/pages/TransformRunPage/TransformRunPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformRunPage/TransformRunPage.tsx
@@ -5,6 +5,7 @@ import { useTransformWithPolling } from "metabase/transforms/hooks/use-transform
import { Center } from "metabase/ui";
import * as Urls from "metabase/urls";
+import { TransformDisconnectedDatabaseBanner } from "../../components/TransformDisconnectedDatabaseBanner";
import { TransformHeader } from "../../components/TransformHeader";
import { RunSection } from "./RunSection";
@@ -40,6 +41,7 @@ export const TransformRunPage = ({ params }: TransformRunPageProps) => {
return (
<PageContainer data-testid="transforms-run-content">
<TransformHeader transform={transform} readOnly={readOnly} />
+ <TransformDisconnectedDatabaseBanner transform={transform} />
<RunSection transform={transform} readOnly={readOnly} />
</PageContainer>
);
diff --git a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
index d1d531cf879..cf6764b0092 100644
--- a/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
+++ b/frontend/src/metabase/transforms/pages/TransformSettingsPage/TransformSettingsPage.tsx
@@ -4,6 +4,7 @@ import { useTransformPermissions } from "metabase/transforms/hooks/use-transform
import { Center } from "metabase/ui";
import * as Urls from "metabase/urls";
+import { TransformDisconnectedDatabaseBanner } from "../../components/TransformDisconnectedDatabaseBanner";
import { TransformHeader } from "../../components/TransformHeader";
import { useTransformWithPolling } from "../../hooks/use-transform-with-polling";
@@ -40,6 +41,7 @@ export const TransformSettingsPage = ({ params }: TransformTargetPageProps) => {
return (
<PageContainer data-testid="transforms-target-content">
<TransformHeader transform={transform} readOnly={readOnly} />
+ <TransformDisconnectedDatabaseBanner transform={transform} />
<TransformSettingsSection transform={transform} readOnly={readOnly} />
</PageContainer>
);
diff --git a/frontend/src/metabase/transforms/utils.ts b/frontend/src/metabase/transforms/utils.ts
index d4091e11cf4..2a284aeb6ed 100644
--- a/frontend/src/metabase/transforms/utils.ts
+++ b/frontend/src/metabase/transforms/utils.ts
@@ -274,6 +274,10 @@ export const getRootCollectionItem = ({
return null;
};
+export function isMissingSourceDatabase(transform: Transform) {
+ return transform.source_database_id == null;
+}
+
/**
* Returns the duration in ms of a transform run, or null when it cannot be
* measured (run still in progress, missing timestamps, unparseable values).
diff --git a/resources/migrations/060/20260522_transform_source_database_id_nullable.yaml b/resources/migrations/060/20260522_transform_source_database_id_nullable.yaml
new file mode 100644
index 00000000000..072f1dbd3ea
--- /dev/null
+++ b/resources/migrations/060/20260522_transform_source_database_id_nullable.yaml
@@ -0,0 +1,44 @@
+## Allow transform.source_database_id to be null so transforms survive source-database deletion.
+## The existing fk_tranform_source_database_id constraint is replaced with one that uses
+## ON DELETE SET NULL, so deleting the source database leaves the transform in place with
+## a null source_database_id rather than blocking the delete or cascading the transform.
+
+databaseChangeLog:
+ - changeSet:
+ id: v60.5vvn7090z6
+ author: bronsa
+ comment: Make transform.source_database_id nullable
+ changes:
+ - dropNotNullConstraint:
+ tableName: transform
+ columnName: source_database_id
+ columnDataType: int
+
+ - changeSet:
+ id: v60.sobugdkwux
+ author: bronsa
+ comment: Drop fk_tranform_source_database_id (recreated next with ON DELETE SET NULL)
+ changes:
+ - dropForeignKeyConstraint:
+ baseTableName: transform
+ constraintName: fk_tranform_source_database_id
+ rollback:
+ - addForeignKeyConstraint:
+ baseTableName: transform
+ baseColumnNames: source_database_id
+ referencedTableName: metabase_database
+ referencedColumnNames: id
+ constraintName: fk_tranform_source_database_id
+
+ - changeSet:
+ id: v60.n6ngozcd0c
+ author: bronsa
+ comment: Recreate fk_tranform_source_database_id with ON DELETE SET NULL
+ changes:
+ - addForeignKeyConstraint:
+ baseTableName: transform
+ baseColumnNames: source_database_id
+ referencedTableName: metabase_database
+ referencedColumnNames: id
+ constraintName: fk_tranform_source_database_id
+ onDelete: SET NULL
diff --git a/src/metabase/lib/schema/validate.cljc b/src/metabase/lib/schema/validate.cljc
index c28468ec735..f6569de8ad1 100644
--- a/src/metabase/lib/schema/validate.cljc
+++ b/src/metabase/lib/schema/validate.cljc
@@ -57,7 +57,7 @@
(mr/def ::source-entity-type
"The type of the source entity causing an error."
- [:enum :table :card])
+ [:enum :table :card :transform])
(mr/def ::source-entity
"Optional source entity tracking fields for dependency analysis."
diff --git a/src/metabase/permissions/models/data_permissions.clj b/src/metabase/permissions/models/data_permissions.clj
index d709537c54a..5e8fba91255 100644
--- a/src/metabase/permissions/models/data_permissions.clj
+++ b/src/metabase/permissions/models/data_permissions.clj
@@ -1238,13 +1238,17 @@
:full)
(defn has-db-transforms-permission?
- "Returns true if the given user has the transforms permission for the given source db."
+ "Returns true if the given user has the transforms permission for the given source db.
+ Superusers always pass. A nil `database-id` (an orphaned transform whose source database
+ was deleted) only grants permission to superusers."
[user-id database-id]
(and (not= database-id audit/audit-db-id)
- (user-has-permission-for-database? user-id
- :perms/transforms
- :yes
- database-id)))
+ (or (is-superuser? user-id)
+ (and (some? database-id)
+ (user-has-permission-for-database? user-id
+ :perms/transforms
+ :yes
+ database-id)))))
(defn has-any-transforms-permission?
"Returns true if the current user has the transforms permission for _any_ source db."
diff --git a/src/metabase/revisions/impl/transform.clj b/src/metabase/revisions/impl/transform.clj
index cebbb0336d3..e44bf604263 100644
--- a/src/metabase/revisions/impl/transform.clj
+++ b/src/metabase/revisions/impl/transform.clj
@@ -3,7 +3,7 @@
[metabase.revisions.models.revision :as revision]))
(def ^:private excluded-columns-for-transform-revision
- #{:id :entity_id :created_at :updated_at :creator :creator_id})
+ #{:id :entity_id :created_at :updated_at :creator :creator_id :can_read :can_write :can_execute})
(defmethod revision/serialize-instance :model/Transform [_model _id instance]
(apply dissoc instance excluded-columns-for-transform-revision))
diff --git a/src/metabase/transforms/crud.clj b/src/metabase/transforms/crud.clj
index 269b27c03c9..1b70402c41b 100644
--- a/src/metabase/transforms/crud.clj
+++ b/src/metabase/transforms/crud.clj
@@ -99,7 +99,7 @@
(when database-id
[[:= :source_database_id database-id]]))
:order-by [[:id :asc]]})]
- (->> (t2/hydrate transforms :last_run :transform_tag_ids :creator :owner)
+ (->> (t2/hydrate transforms :last_run :transform_tag_ids :creator :owner :can_read :can_write :can_execute)
(into []
(comp (transforms-base.u/->date-field-filter-xf [:last_run :start_time] last-run-start-time)
(transforms-base.u/->status-filter-xf [:last_run :status] last-run-statuses)
@@ -113,7 +113,7 @@
(let [{:keys [target] :as transform} (api/read-check :model/Transform id)
target-table (transforms-base.u/target-table (transforms-base.i/target-db-id transform) target :active true)]
(-> transform
- (t2/hydrate :last_run :transform_tag_ids :creator :owner)
+ (t2/hydrate :last_run :transform_tag_ids :creator :owner :can_read :can_write :can_execute)
(u/update-some :last_run transforms-base.u/localize-run-timestamps)
(assoc :table target-table)
transforms.u/add-source-readable)))
@@ -144,7 +144,7 @@
(when (seq tag-ids)
(transform.model/update-transform-tags! (:id transform) tag-ids))
;; Return with hydrated tag_ids
- (t2/hydrate transform :transform_tag_ids :creator :owner)))]
+ (t2/hydrate transform :transform_tag_ids :creator :owner :can_read :can_write :can_execute)))]
(events/publish-event! :event/transform-create {:object transform :user-id creator-id})
transform)))
@@ -180,7 +180,7 @@
;; Update tag associations if provided
(when (contains? body :tag_ids)
(transform.model/update-transform-tags! id (:tag_ids body)))
- (t2/hydrate (t2/select-one :model/Transform id) :transform_tag_ids :creator :owner))]
+ (t2/hydrate (t2/select-one :model/Transform id) :transform_tag_ids :creator :owner :can_read :can_write :can_execute))]
(events/publish-event! :event/transform-update {:object transform :user-id api/*current-user-id*})
(-> transform
transforms.u/add-source-readable)))
diff --git a/src/metabase/transforms/models/transform.clj b/src/metabase/transforms/models/transform.clj
index c969f4c5f6f..70d272a3f2d 100644
--- a/src/metabase/transforms/models/transform.clj
+++ b/src/metabase/transforms/models/transform.clj
@@ -31,20 +31,35 @@
(doseq [trait [:metabase/model :hook/entity-id :hook/timestamped?]]
(derive :model/Transform trait))
+(defn- transform-readable?
+ "Whether the current user can read `instance`. Any extra `args` (an optional `models-cache`) are
+ passed through to `transforms.u/source-tables-readable?`."
+ [instance & args]
+ (and (transforms.u/check-feature-enabled instance)
+ (or api/*is-superuser?*
+ (and (api/is-data-analyst?)
+ (apply transforms.u/source-tables-readable? instance args)))))
+
+(defn- transform-writable?
+ "Whether the current user can write `instance`. Any extra `args` (an optional `models-cache`) are
+ passed through to the source-readability check, as in `transform-readable?`."
+ [instance & args]
+ (and (remote-sync/transforms-editable?)
+ (transforms.u/check-feature-enabled instance)
+ (or api/*is-superuser?*
+ (and (apply transform-readable? instance args)
+ (perms/has-db-transforms-permission? api/*current-user-id* (:source_database_id instance))))))
+
(defmethod mi/can-read? :model/Transform
([instance]
- (and (api/is-data-analyst?)
- (transforms.u/source-tables-readable? instance)
- (transforms.u/check-feature-enabled instance)))
+ (transform-readable? instance))
([_model pk]
(when-let [transform (t2/select-one :model/Transform :id pk)]
(mi/can-read? transform))))
(defmethod mi/can-write? :model/Transform
([instance]
- (and (mi/can-read? instance)
- (perms/has-db-transforms-permission? api/*current-user-id* (:source_database_id instance))
- (remote-sync/transforms-editable?)))
+ (transform-writable? instance))
([_model pk]
(when-let [transform (t2/select-one :model/Transform :id pk)]
(mi/can-write? transform))))
@@ -61,12 +76,22 @@
;; Inline can-write? logic since instance is a plain map without model metadata.
;; can-write? requires: can-read?, has-db-transforms-permission?, and transforms-editable?
;; can-read? requires: is-superuser? OR (is-data-analyst? AND source-tables-readable?)
- (let [source-db-id (or (:source_database_id instance) (transforms-base.i/source-db-id instance))]
- (and (or api/*is-superuser?*
+ (and (remote-sync/transforms-editable?)
+ (transforms.u/check-feature-enabled instance)
+ (or api/*is-superuser?*
+ (let [source-db-id (or (:source_database_id instance) (transforms-base.i/source-db-id instance))]
(and api/*is-data-analyst?*
- (transforms.u/source-tables-readable? instance)))
- (perms/has-db-transforms-permission? api/*current-user-id* source-db-id)
- (remote-sync/transforms-editable?))))
+ (transforms.u/source-tables-readable? instance)
+ (perms/has-db-transforms-permission? api/*current-user-id* source-db-id))))))
+
+(defn- orphan-query?
+ "True when the query map has its `:database` key explicitly set to nil — the
+ signature of a transform body whose source database has been deleted (e.g.
+ imported from a serdes export of an orphan). We preserve such bodies verbatim
+ rather than running them through MBQL normalization, which requires a database."
+ [q]
+ (or (and (contains? q :database) (nil? (:database q)))
+ (and (contains? q "database") (nil? (get q "database")))))
(defn transform-source-out
"Deserialize a transform source map from JSON storage format.
@@ -75,7 +100,7 @@
(-> m
mi/json-out-without-keywordization
(update-keys keyword)
- (m/update-existing :query lib-be/normalize-query)
+ (m/update-existing :query (fn [q] (if (orphan-query? q) q (lib-be/normalize-query q))))
(m/update-existing :source-incremental-strategy #(update-keys % keyword))
(m/update-existing :source-tables (fn [st] (mapv #(update-keys % keyword) st)))
(m/update-existing :type keyword)))
@@ -84,7 +109,10 @@
"Serialize a transform source map for JSON storage."
[m]
(-> m
- (m/update-existing :query (comp lib/prepare-for-serialization lib-be/normalize-query))
+ (m/update-existing :query (fn [q]
+ (if (orphan-query? q)
+ q
+ ((comp lib/prepare-for-serialization lib-be/normalize-query) q))))
mi/json-in))
(t2/deftransforms :model/Transform
@@ -104,7 +132,10 @@
(collection/check-allowed-content :model/Transform collection_id))
(let [target-db-id (transforms-base.i/target-db-id transform)
valid-db-id? (and target-db-id (t2/exists? :model/Database :id target-db-id))]
- (when-not valid-db-id?
+ ;; Don't warn when target-db-id is nil — that's an orphan source (e.g. a
+ ;; serdes-imported transform whose source database is missing), not a
+ ;; misconfiguration. Only warn when an id is supplied but invalid.
+ (when (and target-db-id (not valid-db-id?))
(log/warnf "Invalid target database id (%s) ignored for new transform (%s)" target-db-id (:name transform)))
(-> transform
(assoc-in [:target :database] target-db-id)
@@ -145,6 +176,36 @@
(assoc transform :source_type (transforms-base.u/transform-source-type source))
transform))
+(defn- hydrate-permission
+ "Batched-hydrate helper: attach a permission under `k` to each transform by calling `pred`
+ (`transform-readable?`/`transform-writable?`) with a `models-cache` prefetched once for the whole
+ list, so checking N transforms doesn't issue a query per transform."
+ [k transforms pred]
+ (let [models-cache (transforms.u/prefetch-source-models transforms)]
+ (mi/instances-with-hydrated-data
+ transforms k
+ #(into {}
+ (map (fn [{:keys [id] :as transform}]
+ [id (pred transform models-cache)]))
+ transforms)
+ :id
+ {:default false})))
+
+(methodical/defmethod t2/batched-hydrate [:model/Transform :can_read]
+ "Add can_read to transforms."
+ [_model k transforms]
+ (hydrate-permission k transforms transform-readable?))
+
+(methodical/defmethod t2/batched-hydrate [:model/Transform :can_write]
+ "Add can_write to transforms."
+ [_model k transforms]
+ (hydrate-permission k transforms transform-writable?))
+
+(methodical/defmethod t2/batched-hydrate [:model/Transform :can_execute]
+ "Add can_execute to transforms. Executing a transform requires write permission."
+ [_model k transforms]
+ (hydrate-permission k transforms transform-writable?))
+
(methodical/defmethod t2/batched-hydrate [:model/TransformRun :transform]
"Add transform to a TransformRun. For orphaned runs (where transform was deleted),
returns a map with :name from the denormalized transform_name and :deleted true."
@@ -344,28 +405,41 @@
:owner_user_id (serdes/fk :model/User)
:collection_id (serdes/fk :model/Collection)
:source_database_id (serdes/fk :model/Database)
- :source {:export (fn [source]
- (-> source
- (m/update-existing :query serdes/export-mbql)
- (m/update-existing :source-database serdes/*export-database-fk*)
- (m/update-existing :source-tables
- (fn [entries]
- (->> (transforms-base.u/normalize-source-tables entries)
- (mapv (fn [entry]
- (-> entry
- (m/update-existing :table_id serdes/*export-table-fk*)
- (m/update-existing :database_id serdes/*export-database-fk*)))))))))
- :import (fn [source]
- (-> source
- (m/update-existing :query serdes/import-mbql)
- (m/update-existing :source-database import-maybe-int-database-fk)
- (m/update-existing :source-tables
- (fn [entries]
- (->> (cond-> entries (map? entries) transforms-base.u/source-tables-map->vec)
- (mapv (fn [entry]
- (-> entry
- (m/update-existing :table_id import-maybe-int-table-fk)
- (m/update-existing :database_id import-maybe-int-database-fk)))))))))}
+ :source {:export-with-context
+ (fn [{:keys [source_database_id]} _k source]
+ (if source_database_id
+ (-> source
+ (m/update-existing :query serdes/export-mbql)
+ (m/update-existing :source-database serdes/*export-database-fk*)
+ (m/update-existing :source-tables
+ (fn [entries]
+ (->> (transforms-base.u/normalize-source-tables entries)
+ (mapv #(-> %
+ (m/update-existing :table_id serdes/*export-table-fk*)
+ (m/update-existing :database_id serdes/*export-database-fk*)))))))
+ ;; Orphan: source DB has been deleted, so table/field rows it referenced
+ ;; are gone too. Null the dead numeric refs and flag the body so
+ ;; the importer skips ref resolution.
+ (-> source
+ (assoc :serdes/unresolved true)
+ (m/update-existing :query assoc :database nil)
+ (m/update-existing :source-database (constantly nil))
+ (m/update-existing :source-tables
+ #(mapv (fn [e] (assoc e :table_id nil :database_id nil)) %)))))
+ :import
+ (fn [source]
+ (if (:serdes/unresolved source)
+ (dissoc source :serdes/unresolved)
+ (-> source
+ (m/update-existing :query serdes/import-mbql)
+ (m/update-existing :source-database import-maybe-int-database-fk)
+ (m/update-existing :source-tables
+ (fn [entries]
+ (->> (cond-> entries (map? entries) transforms-base.u/source-tables-map->vec)
+ (mapv (fn [entry]
+ (-> entry
+ (m/update-existing :table_id import-maybe-int-table-fk)
+ (m/update-existing :database_id import-maybe-int-database-fk))))))))))}
:target {:export #(serdes/export-mbql (dissoc % :table_id))
:import serdes/import-mbql}
:tags (serdes/nested :model/TransformTransformTag :transform_id (merge {:sort-by (juxt :position :created_at)} opts))}})
diff --git a/src/metabase/transforms/util.clj b/src/metabase/transforms/util.clj
index bfbc2cfd7e4..bbc49f65278 100644
--- a/src/metabase/transforms/util.clj
+++ b/src/metabase/transforms/util.clj
@@ -50,27 +50,46 @@
(defn source-tables-readable?
"Check if the source tables/database in a transform are readable by the current user.
Returns true if the user can query all source tables (for python transforms) or the
- source database (for query transforms)."
- [transform]
- (let [source (:source transform)]
- (case (keyword (:type source))
- :query
- (if-let [db-id (get-in source [:query :database])]
- (boolean (mi/can-query? (t2/select-one :model/Database db-id)))
- false)
-
- :python
- (let [source-tables (:source-tables source)]
- (if (empty? source-tables)
- true
- (let [table-ids (into [] (keep :table_id) source-tables)]
- (and (seq table-ids)
- (every? (fn [table-id]
- (when-let [table (t2/select-one :model/Table table-id)]
- (mi/can-query? table)))
- table-ids)))))
-
- (throw (ex-info (str "Unknown transform source type: " (:type source)) {})))))
+ source database (for query transforms). Returns false if the referenced source database
+ no longer exists."
+ ([transform] (source-tables-readable? transform nil))
+ ([transform models-cache]
+ (let [resolve* (fn [model id]
+ (if models-cache
+ (get-in models-cache [model id])
+ (t2/select-one model id)))
+ source (:source transform)]
+ (case (keyword (:type source))
+ :query
+ (if-let [db-id (get-in source [:query :database])]
+ (if-let [db (resolve* :model/Database db-id)]
+ (boolean (mi/can-query? db))
+ false)
+ false)
+
+ :python
+ (let [source-tables (:source-tables source)]
+ (if (empty? source-tables)
+ true
+ (let [table-ids (into [] (keep :table_id) source-tables)]
+ (and (seq table-ids)
+ (every? (fn [table-id]
+ (when-let [table (resolve* :model/Table table-id)]
+ (mi/can-query? table)))
+ table-ids)))))
+
+ (throw (ex-info (str "Unknown transform source type: " (:type source)) {}))))))
+
+(defn prefetch-source-models
+ "Bulk-load the source databases and tables referenced by `transforms` into a
+ `{:model/Database {id db} :model/Table {id table}}` map"
+ [transforms]
+ (let [db-ids (into #{} (keep #(get-in % [:source :query :database])) transforms)
+ table-ids (into #{} (mapcat #(keep :table_id (get-in % [:source :source-tables]))) transforms)]
+ {:model/Database (when (seq db-ids)
+ (u/index-by :id (t2/select :model/Database :id [:in db-ids])))
+ :model/Table (when (seq table-ids)
+ (u/index-by :id (t2/select :model/Table :id [:in table-ids])))}))
(defn add-source-readable
"Add :source_readable field to a transform or collection of transforms.
diff --git a/src/metabase/transforms_base/query.clj b/src/metabase/transforms_base/query.clj
index 4c5858cb963..a6dea66bfe6 100644
--- a/src/metabase/transforms_base/query.clj
+++ b/src/metabase/transforms_base/query.clj
@@ -87,7 +87,11 @@
(when (and cancelled? (cancelled?))
(throw (ex-info "Transform cancelled before start" {:status :cancelled})))
(let [db (get-in source [:query :database])
- {driver :engine :as database} (t2/select-one :model/Database db)
+ {driver :engine :as database} (when db (t2/select-one :model/Database db))
+ _ (when-not database
+ (throw (ex-info "Source database for this transform has been deleted."
+ {:transform-id (:id transform)
+ :source-database-id db})))
_ (transforms-base.u/throw-if-db-routing-enabled! transform database)
;; Full incremental runs (no watermark — either the first ever, or one that follows a
;; checkpoint-config reset) drop and recreate the table rather than appending.
diff --git a/src/metabase/transforms_rest/api/transform.clj b/src/metabase/transforms_rest/api/transform.clj
index c53551e457b..06e2af9cb67 100644
--- a/src/metabase/transforms_rest/api/transform.clj
+++ b/src/metabase/transforms_rest/api/transform.clj
@@ -97,7 +97,10 @@
[:owner_user_id {:optional true} [:maybe pos-int?]]
[:owner_email {:optional true} [:maybe :string]]
[:owner {:optional true} [:maybe OwnerResponse]]
- [:last_checkpoint_value {:optional true} [:maybe :string]]])
+ [:last_checkpoint_value {:optional true} [:maybe :string]]
+ [:can_read {:optional true} :boolean]
+ [:can_write {:optional true} :boolean]
+ [:can_execute {:optional true} :boolean]])
(def ^:private TransformRunResponse
[:map {:closed true}
@@ -166,9 +169,9 @@
[:collection_id {:optional true} [:maybe ms/PositiveInt]]
[:owner_user_id {:optional true} [:maybe ms/PositiveInt]]
[:owner_email {:optional true} [:maybe :string]]]]
+ (transforms.core/check-feature-enabled! body)
(api/create-check :model/Transform body)
(transforms.core/check-database-feature body)
- (transforms.core/check-feature-enabled! body)
(transforms.core/validate-incremental-column-type! body)
(api/check (not (transforms-base.u/target-table-exists? body))
403
@@ -191,7 +194,7 @@
{graph :dependencies} (transforms.core/transform-ordering #{id} (vals id->transform))
dep-ids (get graph id)
dependencies (map id->transform dep-ids)]
- (->> (t2/hydrate dependencies :creator :owner)
+ (->> (t2/hydrate dependencies :creator :owner :can_read :can_write :can_execute)
transforms.u/add-source-readable)))
(api.macros/defendpoint :get "/run" :- [:map {:closed true}
diff --git a/src/metabase/warehouses/models/database.clj b/src/metabase/warehouses/models/database.clj
index dd8f81f0491..320b1d02a06 100644
--- a/src/metabase/warehouses/models/database.clj
+++ b/src/metabase/warehouses/models/database.clj
@@ -164,6 +164,16 @@
[_db-id]
nil)
+(defenterprise mark-transforms-stale-on-database-delete!
+ "Hook called from the `:model/Database` before-delete. Transforms whose `source_database_id`
+ is about to be SET NULL by the FK action survive the delete (so the analyst can read the
+ SQL/Python and rebuild against a new DB), but their dependency-analysis findings need to
+ be re-run so they surface on `/data-studio/dependency-diagnostics/broken`. OSS is a no-op
+ (no dependencies module)."
+ metabase-enterprise.dependencies.events
+ [_db-id]
+ nil)
+
(defn- can-write?
[db-id]
(or (some-> db-id db-id->router-db-id can-write?)
@@ -427,6 +437,11 @@
;; Runs before any other cleanup so we don't partially unwind sync tasks / secrets
;; / fields for a Database whose deletion is about to be refused.
(reconcile-workspace-database-refs-before-delete! id)
+ ;; Mark transforms with this DB as source as stale so dependency-diagnostics re-analyzes
+ ;; them after the row's gone. Must run BEFORE the FK SET NULL fires (which happens when
+ ;; the database row is deleted below) so we can still resolve the affected transforms by
+ ;; source_database_id.
+ (mark-transforms-stale-on-database-delete! id)
(unschedule-tasks! database)
(secret/delete-orphaned-secrets! database)
(delete-database-fields! id)
diff --git a/src/metabase/warehouses_rest/api.clj b/src/metabase/warehouses_rest/api.clj
index c0c1be9882e..da647b8fe7b 100644
--- a/src/metabase/warehouses_rest/api.clj
+++ b/src/metabase/warehouses_rest/api.clj
@@ -542,7 +542,7 @@
(def ^:private database-usage-models
"List of models that are used to report usage on a database."
- [:question :dataset :metric :segment]) ; TODO -- rename `:dataset` to `:model`?
+ [:question :dataset :metric :segment :transform]) ; TODO -- rename `:dataset` to `:model`?
(defmulti ^:private database-usage-query
"Query that will returns the number of `model` that use the database with id `database-id`.
@@ -578,6 +578,14 @@
:from [:metabase_table]
:where [:= :db_id db-id]}]})
+(defmethod database-usage-query :transform
+ [_ db-id]
+ {:select [[:%count.* :transform]]
+ :from [:transform]
+ :where [:or
+ [:= :source_database_id db-id]
+ [:= :target_db_id db-id]]})
+
;; TODO (Cam 10/28/25) -- fix this endpoint route to use kebab-case for consistency with the rest of our REST API
;;
;; TODO (Cam 2025-11-25) please add a response schema to this API endpoint, it makes it easier for our customers to
diff --git a/test/metabase/transforms/models/transform_test.clj b/test/metabase/transforms/models/transform_test.clj
index c8f93779faa..36bf058b3f5 100644
--- a/test/metabase/transforms/models/transform_test.clj
+++ b/test/metabase/transforms/models/transform_test.clj
@@ -4,6 +4,7 @@
[metabase.events.core :as events]
[metabase.models.interface :as mi]
[metabase.test :as mt]
+ [metabase.transforms-base.query :as transforms-base.query]
[toucan2.core :as t2]))
(deftest source-database-id-set-test
@@ -15,15 +16,75 @@
:type "native"
:native {:query "SELECT 1"}}}}]
(is (= (mt/id) (:source_database_id transform)))))
- (testing "updating a transform correctly sets the source-database-id column"
+ (testing "A transform with no source database has a nil source_database_id"
(mt/with-temp [:model/Transform transform
{:name "Test Transform"
- :source_database_id (mt/id)
+ :source {:type "python"
+ :body "print(\"hello\")"}}]
+ (is (nil? (:source_database_id transform)))))
+ (testing "updating a transform recomputes the source-database-id column from the source"
+ (mt/with-temp [:model/Transform transform
+ {:name "Test Transform"
+ :source {:type "python"
+ :body "print(\"hello\")"}}]
+ (is (nil? (:source_database_id transform)))
+ (t2/update! :model/Transform (:id transform) {:source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}})
+ (is (= (mt/id) (t2/select-one-fn :source_database_id :model/Transform (:id transform)))))))
+
+(deftest source-database-deletion-sets-null-test
+ (testing "deleting a database referenced by a transform nulls the transform's source_database_id (ON DELETE SET NULL)"
+ (mt/with-temp [:model/Database {db-id :id} {}
+ :model/Transform transform
+ {:name "Test Transform"
:source {:type "query"
- :query {:database (mt/id)
+ :query {:database db-id
:type "native"
:native {:query "SELECT 1"}}}}]
- (is (= (mt/id) (:source_database_id transform))))))
+ (is (= db-id (:source_database_id transform)))
+ (t2/delete! :model/Database db-id)
+ (is (nil? (t2/select-one-fn :source_database_id :model/Transform (:id transform))))
+ ;; transform itself still exists
+ (is (some? (t2/select-one :model/Transform (:id transform)))))))
+
+(deftest can-read-write-on-orphaned-transform-test
+ (testing "superusers can read/write a transform whose source database has been deleted, data analysts cannot"
+ (mt/with-premium-features #{:transforms-basic}
+ (mt/with-temp [:model/Database {db-id :id} {}
+ :model/Transform transform
+ {:name "Orphan Transform"
+ :source {:type "query"
+ :query {:database db-id
+ :type "native"
+ :native {:query "SELECT 1"}}}}]
+ (t2/delete! :model/Database db-id)
+ (let [reloaded (t2/select-one :model/Transform (:id transform))]
+ (is (nil? (:source_database_id reloaded)))
+ (mt/with-current-user (mt/user->id :crowberto)
+ (is (mi/can-read? reloaded))
+ (is (mi/can-write? reloaded)))
+ (mt/with-current-user (mt/user->id :rasta)
+ (is (not (mi/can-read? reloaded)))
+ (is (not (mi/can-write? reloaded)))))))))
+
+(deftest execute-fails-clearly-when-source-db-deleted-test
+ (testing "running a query transform whose source database has been deleted fails with a clear error"
+ (mt/with-premium-features #{:transforms-basic}
+ (mt/with-temp [:model/Database {db-id :id} {}
+ :model/Transform transform
+ {:name "Will be orphaned"
+ :source {:type :query
+ :query {:database db-id
+ :type :native
+ :native {:query "SELECT 1"}}}}]
+ (t2/delete! :model/Database db-id)
+ (let [reloaded (t2/select-one :model/Transform (:id transform))
+ {:keys [status error]} (transforms-base.query/run-query-transform! reloaded nil)]
+ (is (= :failed status))
+ (is (re-find #"Source database for this transform has been deleted"
+ (ex-message error))))))))
(deftest no-events-during-deserialization-test
(testing "Transform lifecycle hooks do not publish events during deserialization"
diff --git a/test/metabase/warehouses_rest/api_test.clj b/test/metabase/warehouses_rest/api_test.clj
index a8e7f6b6d9c..3c0a6a29c45 100644
--- a/test/metabase/warehouses_rest/api_test.clj
+++ b/test/metabase/warehouses_rest/api_test.clj
@@ -274,15 +274,34 @@
:model/Card _ {:database_id db-id
:table_id table-id-2
:type :metric}
- :model/Segment _ {:table_id table-id-2}]
+ :model/Segment _ {:table_id table-id-2}
+ :model/Transform _ {:name "Source DB transform"
+ :source {:type :query
+ :query {:database db-id
+ :type :native
+ :native {:query "select 1"}}}
+ :target {:type "table"
+ :database db-id
+ :schema "PUBLIC"
+ :name "source_db_transform_target"}}
+ :model/Transform _ {:name "Target DB transform"
+ :source {:type :query
+ :query {:database db-id
+ :type :native
+ :native {:query "select 1"}}}
+ :target {:type "table"
+ :database db-id
+ :schema "PUBLIC"
+ :name "target_db_transform_target"}}]
(testing "should require admin"
(is (= "You don't have permissions to do that."
(mt/user-http-request :rasta :get 403 (format "database/%d/usage_info" db-id)))))
(testing "return the correct usage info"
- (is (= {:question 1
- :dataset 2
- :metric 3
- :segment 1}
+ (is (= {:question 1
+ :dataset 2
+ :metric 3
+ :segment 1
+ :transform 2}
(mt/user-http-request :crowberto :get 200 (format "database/%d/usage_info" db-id)))))
(testing "404 if db does not exist"
(let [non-existing-db-id (inc (t2/select-one-pk :model/Database {:order-by [[:id :desc]]}))]
@@ -327,10 +346,11 @@
(mt/with-temp
[:model/Database {db-id :id} {}]
(testing "should work with DB that has no tables"
- (is (= {:question 0
- :dataset 0
- :metric 0
- :segment 0}
+ (is (= {:question 0
+ :dataset 0
+ :metric 0
+ :segment 0
+ :transform 0}
(mt/user-http-request :crowberto :get 200 (format "database/%d/usage_info" db-id)))))))
(defn- create-db-via-api! [& [m]]