Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

add default noop implementation of native-query-deps (#64384)

William062ba25fe85b
diff --git a/src/metabase/driver.clj b/src/metabase/driver.clj
index ff689abe59e..ef553e30a08 100644
--- a/src/metabase/driver.clj
+++ b/src/metabase/driver.clj
@@ -1228,6 +1228,14 @@
dispatch-on-initialized-driver
:hierarchy #'hierarchy)
+(defmethod native-query-deps :default
+ [driver & args]
+ (if (database-supports? driver :dependencies/native nil)
+ (throw (ex-info "Database that supports :dependencies/native does not provide an implementation of driver/native-query-deps"
+ {:driver driver
+ :args args}))
+ #{}))
+
(defmulti native-result-metadata
"Gets the result-metadata for a native query using static analysis (i.e., without actually
going to the database).
diff --git a/test/metabase/driver_test.clj b/test/metabase/driver_test.clj
index fde4af96904..fbbffa1455d 100644
--- a/test/metabase/driver_test.clj
+++ b/test/metabase/driver_test.clj
@@ -404,3 +404,19 @@
(and (get-method driver/type->database-type driver)
(every? #(driver/type->database-type driver %) should-be-supported-by-all))))
(is (get-method driver/insert-from-source! [driver :jsonl-file])))))
+
+(driver/register! ::mock-no-deps-driver, :abstract? true)
+
+(deftest deps-ignores-invalid-drivers-test
+ (is (= #{}
+ (driver/native-query-deps ::mock-no-deps-driver nil nil))))
+
+(driver/register! ::mock-deps-driver, :abstract? true)
+
+(defmethod driver/database-supports? [::mock-deps-driver :dependencies/native]
+ [_driver _feature _database]
+ true)
+
+(deftest deps-flags-when-supported-driver-is-not-covered-test
+ (is (thrown-with-msg? clojure.lang.ExceptionInfo #"Database that supports :dependencies/native does not provide an implementation of driver/native-query-deps"
+ (driver/native-query-deps ::mock-deps-driver nil nil))))