The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move isRecentCollectionItem inline (#73710)
Fraser074b9ceb3e1a
diff --git a/frontend/src/metabase-types/api/activity.ts b/frontend/src/metabase-types/api/activity.tsindex f40079b5c42..ed06918c12b 100644--- a/frontend/src/metabase-types/api/activity.ts+++ b/frontend/src/metabase-types/api/activity.ts@@ -1,5 +1,3 @@-import type { OmniPickerItem } from "metabase/common/components/Pickers";-import type { CollectionId, CollectionType } from "./collection";import type { DashboardId } from "./dashboard";import type { DatabaseId, InitialSyncStatus } from "./database";@@ -80,11 +78,6 @@ export type RecentItem = RecentTableItem | RecentCollectionItem;export const isRecentTableItem = (item: RecentItem): item is RecentTableItem =>item.model === "table";-export const isRecentCollectionItem = (- item: OmniPickerItem,-): item is RecentCollectionItem =>- ["collection", "dashboard", "card", "dataset", "metric"].includes(item.model);-export interface RecentItemsResponse {recent_views: RecentItem[];}diff --git a/frontend/src/metabase/palette/hooks/useCommandPalette.tsx b/frontend/src/metabase/palette/hooks/useCommandPalette.tsxindex 5121cb0b428..d8c8e4ab50c 100644--- a/frontend/src/metabase/palette/hooks/useCommandPalette.tsx+++ b/frontend/src/metabase/palette/hooks/useCommandPalette.tsx@@ -6,6 +6,7 @@ import { jt, t } from "ttag";import { useListRecentsQuery, useSearchQuery } from "metabase/api";import { getCollection } from "metabase/collections/utils";+import type { OmniPickerItem } from "metabase/common/components/Pickers";import { useSetting } from "metabase/common/hooks";import { getIcon } from "metabase/common/utils/icon";import { ROOT_COLLECTION } from "metabase/entities/collections/constants";@@ -25,8 +26,8 @@ import { modelToUrl } from "metabase/urls";import { SEARCH_DEBOUNCE_DURATION } from "metabase/utils/constants";import { getName } from "metabase/utils/name";import {+ type RecentCollectionItem,type RecentItem,- isRecentCollectionItem,isRecentTableItem,} from "metabase-types/api";@@ -402,3 +403,8 @@ const SubtitleText = ({ children }: PropsWithChildren) => ({children}</Text>);++const isRecentCollectionItem = (+ item: OmniPickerItem,+): item is RecentCollectionItem =>+ ["collection", "dashboard", "card", "dataset", "metric"].includes(item.model);