The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
[liquibase] Remove obsolete proxy package hack (#81480)
Oleksandr Yakushev074e967be7ca
diff --git a/src/metabase/app_db/liquibase/h2.clj b/src/metabase/app_db/liquibase/h2.cljindex edaac3eb669..12119e622ab 100644--- a/src/metabase/app_db/liquibase/h2.clj+++ b/src/metabase/app_db/liquibase/h2.clj@@ -24,34 +24,6 @@(let [^H2Database this this](proxy-super correctObjectName (upcase object-name) object-type)))))-;; HACK! Create a [[java.lang.Package]] for the proxy class if one does not already exist. This is needed because:-;;-;; 1. Liquibase will throw an NPE if the package for the class does not exist -- see-;; https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/logging/core/JavaLogService.java#L45-;; and https://github.com/liquibase/liquibase/issues/2633-;;-;; 2. In Java 9+, the JVM will automatically define a package when a class is created; in Java 8, it does not.-;;-;; 3. The Clojure DynamicClassLoader does not create a Package -- see-;; https://clojure.atlassian.net/browse/CLJ-1550?focusedCommentId=13025-;;-;; This only does anything in REPL-based development; in the uberjar the proxy class will be AOT'ed and will have a-;; package defined for it when it's loaded by the normal JVM classloader rather than the Clojure DynamicClassLoader-(let [klass (class (h2-database*))]- (when-not (.getPackage klass)- (let [method (.getDeclaredMethod- ClassLoader- "definePackage"- (into-array Class [String String String String String String String java.net.URL]))- class-name (.getName klass)- ;; e.g. metabase.app-db.liquibase.h2.proxy$liquibase.database.core- package-name (.substring class-name 0 (.lastIndexOf class-name "."))]- (doto method- (.setAccessible true)- (.invoke (.getClassLoader klass) (into-array Object [package-name nil nil nil nil nil nil nil]))- (.setAccessible false))- (assert (.getPackage klass) (format "Failed to create package for proxy class %s." class-name)))))-(defn h2-database"A version of the Liquibase H2 implementation that always converts identifiers to uppercase and then quotes them."^H2Database [^JdbcConnection conn]