Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Additional transform gates (#76630)

Nathan Voxland074f2a6e93d2
diff --git a/src/metabase/permissions_rest/data_permissions/graph.clj b/src/metabase/permissions_rest/data_permissions/graph.clj
index 6f7e31933e7..84a50ad818f 100644
--- a/src/metabase/permissions_rest/data_permissions/graph.clj
+++ b/src/metabase/permissions_rest/data_permissions/graph.clj
@@ -573,6 +573,20 @@
(:name (perms/data-analyst-group)))
{:status-code 400})))))))
+(defn- check-transforms-permissions!
+ [graph current-perms]
+ (doseq [[group-id db-updates] graph
+ [db-id db-changes] db-updates
+ :when (= (:transforms db-changes) :yes)]
+ (let [create-queries (if (contains? db-changes :create-queries)
+ (:create-queries db-changes)
+ (some (fn [{:keys [table_id perm_value]}]
+ (when (nil? table_id) perm_value))
+ (get current-perms [group-id db-id :perms/create-queries])))]
+ (when (not= create-queries :query-builder-and-native)
+ (throw (ex-info (tru "Transforms permission requires \"Query builder and native\" data access for the database.")
+ {:status-code 400}))))))
+
(defn check-audit-db-permissions
"Check that the changes coming in does not attempt to change audit database permission. Admins should
change these permissions implicitly via collection permissions."
@@ -600,6 +614,7 @@
desired-state (compute-desired-state graph tables-by-db-schema)
{:keys [to-delete to-insert]} (compute-diff desired-state current-perms tables-by-db)]
(validate-blocked-permissions! graph)
+ (check-transforms-permissions! graph current-perms)
(when (seq to-delete)
(perms/batch-delete-permissions! to-delete))
(when (seq to-insert)
diff --git a/src/metabase/transforms/models/transform.clj b/src/metabase/transforms/models/transform.clj
index a370d16d106..ce07f857443 100644
--- a/src/metabase/transforms/models/transform.clj
+++ b/src/metabase/transforms/models/transform.clj
@@ -41,6 +41,13 @@
(and (api/is-data-analyst?)
(apply transforms.u/source-tables-readable? instance args)))))
+(defn- native-transform-write-allowed?
+ [instance source-db-id]
+ (or (not (transforms-base.u/native-query-transform? instance))
+ (and source-db-id
+ (= :query-builder-and-native
+ (perms/full-db-permission-for-user api/*current-user-id* :perms/create-queries source-db-id)))))
+
(defn- transform-writable?
"Whether the current user can write `instance`. Any extra `args` (an optional `models-cache`) are
passed through to the source-readability check, as in `transform-readable?`."
@@ -49,7 +56,8 @@
(transforms.u/check-feature-enabled instance)
(or api/*is-superuser?*
(and (apply transform-readable? instance args)
- (perms/has-db-transforms-permission? api/*current-user-id* (:source_database_id instance))))))
+ (perms/has-db-transforms-permission? api/*current-user-id* (:source_database_id instance))
+ (native-transform-write-allowed? instance (:source_database_id instance))))))
(defmethod mi/can-read? :model/Transform
([instance]
@@ -83,7 +91,8 @@
(let [source-db-id (or (:source_database_id instance) (transforms-base.i/source-db-id instance))]
(and api/*is-data-analyst?*
(transforms.u/source-tables-readable? instance)
- (perms/has-db-transforms-permission? api/*current-user-id* source-db-id))))))
+ (perms/has-db-transforms-permission? api/*current-user-id* source-db-id)
+ (native-transform-write-allowed? instance source-db-id))))))
(defn- orphan-query?
"True when the query map has its `:database` key explicitly set to nil — the
diff --git a/test/metabase/permissions_rest/data_permissions/graph_test.clj b/test/metabase/permissions_rest/data_permissions/graph_test.clj
index 63b374ffcaf..3d599cbb845 100644
--- a/test/metabase/permissions_rest/data_permissions/graph_test.clj
+++ b/test/metabase/permissions_rest/data_permissions/graph_test.clj
@@ -614,3 +614,32 @@
{}))))))
(testing "an empty reducible yields an empty graph"
(is (= {} (reduce-into-graph [] identity))))))
+
+(deftest transforms-require-query-builder-and-native-test
+ (testing "Granting transforms permission requires \"Query builder and native\" (create-queries = :query-builder-and-native)"
+ (mt/with-temp [:model/PermissionsGroup {group-id :id} {}
+ :model/Database {db-id :id} {}]
+ ;; Clear default perms for the group
+ (t2/delete! :model/DataPermissions :group_id group-id)
+ (testing "transforms:yes together with create-queries:query-builder-and-native is allowed"
+ (is (nil? (data-perms.graph/update-data-perms-graph!
+ {:groups {group-id {db-id {:view-data :unrestricted
+ :create-queries :query-builder-and-native
+ :transforms :yes}}}})))
+ (is (= :yes (data-perms/database-permission-for-user (mt/user->id :crowberto) :perms/transforms db-id))))
+ (testing "transforms:yes together with create-queries:query-builder is rejected"
+ (is (thrown-with-msg?
+ clojure.lang.ExceptionInfo #"Query builder and native"
+ (data-perms.graph/update-data-perms-graph!
+ {:groups {group-id {db-id {:view-data :unrestricted
+ :create-queries :query-builder
+ :transforms :yes}}}}))))
+ (testing "transforms:yes alone is rejected when existing create-queries is not query-builder-and-native"
+ ;; Downgrade create-queries so the group no longer has native access
+ (data-perms.graph/update-data-perms-graph!
+ {:groups {group-id {db-id {:view-data :unrestricted
+ :create-queries :query-builder}}}})
+ (is (thrown-with-msg?
+ clojure.lang.ExceptionInfo #"Query builder and native"
+ (data-perms.graph/update-data-perms-graph!
+ {:groups {group-id {db-id {:transforms :yes}}}})))))))
diff --git a/test/metabase/transforms/models/transform_test.clj b/test/metabase/transforms/models/transform_test.clj
index 1f239bd3347..af1062b9b52 100644
--- a/test/metabase/transforms/models/transform_test.clj
+++ b/test/metabase/transforms/models/transform_test.clj
@@ -2,7 +2,11 @@
(:require
[clojure.test :refer :all]
[metabase.events.core :as events]
+ [metabase.lib.core :as lib]
+ [metabase.lib.metadata :as lib.metadata]
[metabase.models.interface :as mi]
+ [metabase.permissions.models.data-permissions :as data-perms]
+ [metabase.permissions.models.permissions-group :as perms-group]
[metabase.test :as mt]
[metabase.transforms-base.query :as transforms-base.query]
[metabase.transforms.query-test-util :as query-test-util]
@@ -101,6 +105,46 @@
(is (not (mi/can-read? reloaded)))
(is (not (mi/can-write? reloaded)))))))))
+(deftest native-transform-requires-query-builder-and-native-test
+ (testing "Writing a native-query transform requires \"Query builder and native\" on the source database, even if the
+ group was misconfigured with transforms permission but only query-builder access (no native)."
+ (mt/with-premium-features #{:transforms-basic :hosting}
+ (mt/with-temp [:model/PermissionsGroup {group-id :id} {}
+ :model/PermissionsGroupMembership _ {:user_id (mt/user->id :rasta) :group_id group-id}
+ :model/Transform native-transform
+ {:name "Native Transform"
+ :source {:type "query"
+ :query {:database (mt/id)
+ :type "native"
+ :native {:query "SELECT 1"}}}}
+ :model/Transform mbql-transform
+ {:name "MBQL Transform"
+ :source {:type "query"
+ :query (lib/query (mt/metadata-provider)
+ (lib.metadata/table (mt/metadata-provider) (mt/id :orders)))}}]
+ (let [native (t2/select-one :model/Transform (:id native-transform))
+ mbql (t2/select-one :model/Transform (:id mbql-transform))]
+ (mt/with-data-analyst-role! (mt/user->id :rasta)
+ (mt/with-restored-data-perms!
+ ;; Remove native access granted to All Users by default so the user's only path to native would be
+ ;; the (mis)configured transforms group.
+ (data-perms/set-database-permission! (perms-group/all-users) (mt/id) :perms/view-data :unrestricted)
+ (data-perms/set-database-permission! (perms-group/all-users) (mt/id) :perms/create-queries :query-builder)
+ (testing "transforms granted, but create-queries only query-builder (no native) — preexisting misconfiguration"
+ (data-perms/set-database-permission! group-id (mt/id) :perms/view-data :unrestricted)
+ (data-perms/set-database-permission! group-id (mt/id) :perms/create-queries :query-builder)
+ (data-perms/set-database-permission! group-id (mt/id) :perms/transforms :yes)
+ (mt/with-current-user (mt/user->id :rasta)
+ (testing "native transform cannot be written"
+ (is (not (mi/can-write? native))))
+ (testing "non-native (MBQL) transform is unaffected"
+ (is (mi/can-write? mbql)))))
+ (testing "with query-builder-and-native, native transform can be written"
+ (data-perms/set-database-permission! group-id (mt/id) :perms/create-queries :query-builder-and-native)
+ (data-perms/set-database-permission! group-id (mt/id) :perms/transforms :yes)
+ (mt/with-current-user (mt/user->id :rasta)
+ (is (mi/can-write? native)))))))))))
+
(deftest execute-fails-clearly-when-source-db-deleted-test
(testing "running a query transform whose source database has been deleted fails with a clear error"
(mt/with-premium-features #{:transforms-basic}