The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Lift data_grid.js up to shared (#70755)
Fraser08b84f4b16d9
diff --git a/frontend/src/metabase/dashboard/components/ClickMappings/utils.ts b/frontend/src/metabase/dashboard/components/ClickMappings/utils.tsindex 625ac1750dc..2a074ccfe1e 100644--- a/frontend/src/metabase/dashboard/components/ClickMappings/utils.ts+++ b/frontend/src/metabase/dashboard/components/ClickMappings/utils.ts@@ -1,6 +1,6 @@import { t } from "ttag";-import { isPivotGroupColumn } from "metabase/lib/data_grid";+import { isPivotGroupColumn } from "metabase/visualizations/lib/data_grid";import * as Lib from "metabase-lib";import Question from "metabase-lib/v1/Question";import type { Dashboard, DatasetColumn, Parameter } from "metabase-types/api";diff --git a/frontend/src/metabase/lib/data_grid.js b/frontend/src/metabase/visualizations/lib/data_grid.jssimilarity index 100%rename from frontend/src/metabase/lib/data_grid.jsrename to frontend/src/metabase/visualizations/lib/data_grid.jsdiff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.tsxindex cb750124625..4f572451aff 100644--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.tsx+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.tsx@@ -20,15 +20,15 @@ import { ExplicitSize } from "metabase/common/components/ExplicitSize";import CS from "metabase/css/core/index.css";import { useTranslateContent } from "metabase/i18n/hooks";import { sumArray } from "metabase/lib/arrays";-import {- COLUMN_SHOW_TOTALS,- isPivotGroupColumn,- multiLevelPivot,-} from "metabase/lib/data_grid";import { getScrollBarSize } from "metabase/lib/dom";import { connect } from "metabase/lib/redux";import { getSetting } from "metabase/selectors/settings";import { useMantineTheme } from "metabase/ui";+import {+ COLUMN_SHOW_TOTALS,+ isPivotGroupColumn,+ multiLevelPivot,+} from "metabase/visualizations/lib/data_grid";import {getDefaultSize,getMinSize,diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx b/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsxindex 28278cfcea4..f3de3dc2d0a 100644--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/RowToggleIcon.tsx@@ -1,8 +1,8 @@import { updateIn } from "icepick";import _ from "underscore";-import { COLLAPSED_ROWS_SETTING } from "metabase/lib/data_grid";import { Icon } from "metabase/ui";+import { COLLAPSED_ROWS_SETTING } from "metabase/visualizations/lib/data_grid";import type {PivotTableCollapsedRowsSetting,VisualizationSettings,diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/settings.ts b/frontend/src/metabase/visualizations/visualizations/PivotTable/settings.tsindex 0e13a074a46..589199dfc58 100644--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/settings.ts+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/settings.ts@@ -2,6 +2,9 @@ import { getIn } from "icepick";import { t } from "ttag";import _ from "underscore";+import { displayNameForColumn } from "metabase/lib/formatting";+import { ChartSettingIconRadio } from "metabase/visualizations/components/settings/ChartSettingIconRadio";+import { ChartSettingsTableFormatting } from "metabase/visualizations/components/settings/ChartSettingsTableFormatting";import {COLLAPSED_ROWS_SETTING,COLUMN_FORMATTING_SETTING,@@ -11,10 +14,7 @@ import {COLUMN_SORT_ORDER_DESC,COLUMN_SPLIT_SETTING,isPivotGroupColumn,-} from "metabase/lib/data_grid";-import { displayNameForColumn } from "metabase/lib/formatting";-import { ChartSettingIconRadio } from "metabase/visualizations/components/settings/ChartSettingIconRadio";-import { ChartSettingsTableFormatting } from "metabase/visualizations/components/settings/ChartSettingsTableFormatting";+} from "metabase/visualizations/lib/data_grid";import { columnSettings } from "metabase/visualizations/lib/settings/column";import type { ComputedVisualizationSettings } from "metabase/visualizations/types";import { migratePivotColumnSplitSetting } from "metabase-lib/v1/queries/utils/pivot";diff --git a/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.ts b/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.tsindex 490bfba5495..af6b77aafe4 100644--- a/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.ts+++ b/frontend/src/metabase/visualizations/visualizations/PivotTable/utils.ts@@ -3,8 +3,8 @@ import _ from "underscore";import { DEFAULT_METABASE_COMPONENT_THEME } from "metabase/embedding-sdk/theme";import { sumArray } from "metabase/lib/arrays";-import { isPivotGroupColumn } from "metabase/lib/data_grid";import { measureText } from "metabase/lib/measure-text";+import { isPivotGroupColumn } from "metabase/visualizations/lib/data_grid";import type NativeQuery from "metabase-lib/v1/queries/NativeQuery";import { migratePivotColumnSplitSetting } from "metabase-lib/v1/queries/utils/pivot";import type {diff --git a/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx b/frontend/src/metabase/visualizations/visualizations/Table/Table.tsxindex 54f3e58a9da..21f042f4aa0 100644--- a/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Table/Table.tsx@@ -4,7 +4,6 @@ import { t } from "ttag";import _ from "underscore";import CS from "metabase/css/core/index.css";-import * as DataGrid from "metabase/lib/data_grid";import { displayNameForColumn } from "metabase/lib/formatting";import type { OptionsType } from "metabase/lib/formatting/types";import { getSubpathSafeUrl } from "metabase/lib/urls";@@ -13,6 +12,7 @@ import {ChartSettingsTableFormatting,isFormattable,} from "metabase/visualizations/components/settings/ChartSettingsTableFormatting";+import * as DataGrid from "metabase/visualizations/lib/data_grid";import {isPivoted as _isPivoted,columnSettings,diff --git a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsList.tsx b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsList.tsxindex f6b9838de90..464fc0053cf 100644--- a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsList.tsx+++ b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsList.tsx@@ -3,9 +3,9 @@ import { t } from "ttag";import { ToolbarButton } from "metabase/common/components/ToolbarButton";import { trackSimpleEvent } from "metabase/lib/analytics";-import { isPivotGroupColumn } from "metabase/lib/data_grid";import { useDispatch, useSelector } from "metabase/lib/redux";import { Box, Flex, Icon, Loader, Menu, Text } from "metabase/ui";+import { isPivotGroupColumn } from "metabase/visualizations/lib/data_grid";import { DRAGGABLE_ID } from "metabase/visualizer/constants";import { useIsCardPristine } from "metabase/visualizer/hooks/use-is-card-pristine";import {diff --git a/frontend/src/metabase/visualizer/utils/column.ts b/frontend/src/metabase/visualizer/utils/column.tsindex 99413131259..7c017bbe991 100644--- a/frontend/src/metabase/visualizer/utils/column.ts+++ b/frontend/src/metabase/visualizer/utils/column.ts@@ -1,6 +1,6 @@import _ from "underscore";-import { isPivotGroupColumn } from "metabase/lib/data_grid";+import { isPivotGroupColumn } from "metabase/visualizations/lib/data_grid";import { isDate, isDimension, isMetric } from "metabase-lib/v1/types/utils/isa";import type {DatasetColumn,diff --git a/frontend/src/metabase/visualizer/utils/get-initial-state-for-card-data-source.ts b/frontend/src/metabase/visualizer/utils/get-initial-state-for-card-data-source.tsindex 1c558d27c4a..33ae8353841 100644--- a/frontend/src/metabase/visualizer/utils/get-initial-state-for-card-data-source.ts+++ b/frontend/src/metabase/visualizer/utils/get-initial-state-for-card-data-source.ts@@ -1,6 +1,6 @@-import { isPivotGroupColumn } from "metabase/lib/data_grid";import { isNotNull } from "metabase/lib/types";import { isCartesianChart } from "metabase/visualizations";+import { isPivotGroupColumn } from "metabase/visualizations/lib/data_grid";import { getComputedSettingsForSeries } from "metabase/visualizations/lib/settings/visualization";import {getDefaultDimensionFilter,diff --git a/frontend/test/metabase/lib/data_grid.unit.spec.js b/frontend/test/metabase/lib/data_grid.unit.spec.jsindex 1fec713d465..5e780a7dd2b 100644--- a/frontend/test/metabase/lib/data_grid.unit.spec.js+++ b/frontend/test/metabase/lib/data_grid.unit.spec.js@@ -7,7 +7,7 @@ import {COLUMN_SPLIT_SETTING,multiLevelPivot,pivot,-} from "metabase/lib/data_grid";+} from "metabase/visualizations/lib/data_grid";import { TYPE } from "metabase-lib/v1/types/constants";const dimension = (i) => ({