Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Give the admin section its own chunks (#79643)

Romeo Van Snick08beefc835ad
diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
index 2928b12f660..5de0cee4990 100644
--- a/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/tenants/index.tsx
@@ -35,9 +35,6 @@ import { EditUserStrategyModal } from "./EditUserStrategyModal";
import { EditUserStrategySettingsButton } from "./EditUserStrategySettingsButton";
import { CanAccessTenantSpecificRoute } from "./components/CanAccessTenantSpecificRoute";
import { CreateTenantsOnboardingStep } from "./components/CreateTenantsOnboardingStep";
-import { ExternalGroupDetailApp } from "./components/ExternalGroupDetailApp/ExternalGroupDetailApp";
-import { ExternalGroupsListingApp } from "./components/ExternalGroupsListingApp/ExternalGroupsListingApp";
-import { ExternalPeopleListingApp } from "./components/ExternalPeopleListingApp/ExternalPeopleListingApp";
import { MainNavSharedCollections } from "./components/MainNavSharedCollections";
import { ReactivateExternalUserButton } from "./components/ReactivateExternalUserButton";
import { TenantCollectionItemList } from "./components/TenantCollectionItemList";
@@ -69,6 +66,34 @@ import {
isTenantGroup,
} from "./utils/utils";
+/**
+ * The tenant people and group pages wrap the admin pages of the same name, so
+ * importing them here would hold those admin pages in the initial bundle. They
+ * get a chunk of their own rather than the `admin` one: naming an `import()`
+ * into a chunk another site already names merges the two module sets, which
+ * copies whatever they shared into every other chunk that needs it.
+ */
+const externalPeopleListing = () =>
+ import(
+ /* webpackChunkName: "tenants" */ "./components/ExternalPeopleListingApp/ExternalPeopleListingApp"
+ ).then(({ ExternalPeopleListingApp }) => ({
+ Component: ExternalPeopleListingApp,
+ }));
+
+const externalGroupsListing = () =>
+ import(
+ /* webpackChunkName: "tenants" */ "./components/ExternalGroupsListingApp/ExternalGroupsListingApp"
+ ).then(({ ExternalGroupsListingApp }) => ({
+ Component: ExternalGroupsListingApp,
+ }));
+
+const externalGroupDetail = () =>
+ import(
+ /* webpackChunkName: "tenants" */ "./components/ExternalGroupDetailApp/ExternalGroupDetailApp"
+ ).then(({ ExternalGroupDetailApp }) => ({
+ Component: ExternalGroupDetailApp,
+ }));
+
export function initializePlugin() {
if (hasPremiumFeature("tenants")) {
PLUGIN_TENANTS.isEnabled = true;
@@ -126,10 +151,10 @@ export function initializePlugin() {
{modalRoute("user-strategy", EditUserStrategyModal, { noWrap: true })}
</Route>
<Route path="groups">
- <Route index element={<ExternalGroupsListingApp />} />
- <Route path=":groupId" element={<ExternalGroupDetailApp />} />
+ <Route index lazy={externalGroupsListing} />
+ <Route path=":groupId" lazy={externalGroupDetail} />
</Route>
- <Route path="people" element={<ExternalPeopleListingApp />}>
+ <Route path="people" lazy={externalPeopleListing}>
{modalRoute(
"new",
(props) => (
diff --git a/frontend/src/metabase/admin/app/components/AdminApp/AdminApp.tsx b/frontend/src/metabase/admin/app/components/AdminApp/AdminApp.tsx
index 51872bbe8f9..539e515faf7 100644
--- a/frontend/src/metabase/admin/app/components/AdminApp/AdminApp.tsx
+++ b/frontend/src/metabase/admin/app/components/AdminApp/AdminApp.tsx
@@ -3,7 +3,7 @@ import { Box, Flex } from "metabase/ui";
import DeprecationNotice from "../../containers/DeprecationNotice";
-const AdminApp = (): JSX.Element => {
+export const AdminApp = (): JSX.Element => {
return (
<Flex direction="column" h="100%">
<DeprecationNotice />
@@ -13,6 +13,3 @@ const AdminApp = (): JSX.Element => {
</Flex>
);
};
-
-// eslint-disable-next-line import/no-default-export -- deprecated usage
-export default AdminApp;
diff --git a/frontend/src/metabase/admin/app/components/AdminApp/index.ts b/frontend/src/metabase/admin/app/components/AdminApp/index.ts
index 7171cfb9881..7e8d988f353 100644
--- a/frontend/src/metabase/admin/app/components/AdminApp/index.ts
+++ b/frontend/src/metabase/admin/app/components/AdminApp/index.ts
@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-default-export -- deprecated usage
-export { default } from "./AdminApp";
+export { AdminApp } from "./AdminApp";
diff --git a/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage.tsx b/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage.tsx
index e50d7526417..72f9a054f90 100644
--- a/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage.tsx
+++ b/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage.tsx
@@ -26,7 +26,7 @@ import { getDiff, getIsDirty } from "../../selectors/data-permissions/diff";
const EMPTY_GROUP_LIST: GroupInfo[] = [];
const EMPTY_DATABASE_LIST: Database[] = [];
-function DataPermissionsPage() {
+export function DataPermissionsPage() {
const params = useParams<{ databaseId: string }>();
const { isLoading: isLoadingDatabases } = useListDatabasesQuery();
const databases = useSelector(
@@ -99,6 +99,3 @@ function DataPermissionsPage() {
</PermissionsPageLayout>
);
}
-
-// eslint-disable-next-line import/no-default-export -- deprecated usage
-export default DataPermissionsPage;
diff --git a/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/index.ts b/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/index.ts
index c34f02db3f3..71d12b398f1 100644
--- a/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/index.ts
+++ b/frontend/src/metabase/admin/permissions/pages/DataPermissionsPage/index.ts
@@ -1,2 +1 @@
-// eslint-disable-next-line import/no-default-export -- deprecated usage
-export { default } from "./DataPermissionsPage";
+export { DataPermissionsPage } from "./DataPermissionsPage";
diff --git a/frontend/src/metabase/admin/permissions/routes.tsx b/frontend/src/metabase/admin/permissions/routes.tsx
index 0418d759563..8ce8b016152 100644
--- a/frontend/src/metabase/admin/permissions/routes.tsx
+++ b/frontend/src/metabase/admin/permissions/routes.tsx
@@ -8,10 +8,37 @@ import {
} from "metabase/plugins";
import { Route, redirect } from "metabase/router";
-import { CollectionPermissionsPage } from "./pages/CollectionPermissionsPage/CollectionPermissionsPage";
-import DataPermissionsPage from "./pages/DataPermissionsPage";
-import { DatabasesPermissionsPage } from "./pages/DatabasePermissionsPage/DatabasesPermissionsPage";
-import { GroupsPermissionsPage } from "./pages/GroupDataPermissionsPage/GroupsPermissionsPage";
+/**
+ * The permissions pages, in one chunk of their own.
+ *
+ * They are only ever reached from these routes and are always used together, so
+ * they share a chunk. It is theirs rather than the admin one: naming an
+ * `import()` into a chunk another site already names merges the two module sets,
+ * which copies whatever they shared into every other chunk that needs it.
+ */
+const dataPermissions = () =>
+ import(
+ /* webpackChunkName: "admin-permissions" */ "./pages/DataPermissionsPage"
+ ).then(({ DataPermissionsPage }) => ({ Component: DataPermissionsPage }));
+
+const databasesPermissions = () =>
+ import(
+ /* webpackChunkName: "admin-permissions" */ "./pages/DatabasePermissionsPage/DatabasesPermissionsPage"
+ ).then(({ DatabasesPermissionsPage }) => ({
+ Component: DatabasesPermissionsPage,
+ }));
+
+const groupsPermissions = () =>
+ import(
+ /* webpackChunkName: "admin-permissions" */ "./pages/GroupDataPermissionsPage/GroupsPermissionsPage"
+ ).then(({ GroupsPermissionsPage }) => ({ Component: GroupsPermissionsPage }));
+
+const collectionPermissions = () =>
+ import(
+ /* webpackChunkName: "admin-permissions" */ "./pages/CollectionPermissionsPage/CollectionPermissionsPage"
+ ).then(({ CollectionPermissionsPage }) => ({
+ Component: CollectionPermissionsPage,
+ }));
// The permissions page renders at each drill-down depth with progressively more
// params. v3 expressed this with sequential optional groups
@@ -36,25 +63,25 @@ const getRoutes = () => (
<Route>
<Route index element={redirect("data")} />
- <Route path="data" element={<DataPermissionsPage />}>
+ <Route path="data" lazy={dataPermissions}>
<Route index element={redirect("group")} />
{DATABASES_PERMISSIONS_PATHS.map((path) => (
- <Route key={path} path={path} element={<DatabasesPermissionsPage />}>
+ <Route key={path} path={path} lazy={databasesPermissions}>
{PLUGIN_ADMIN_PERMISSIONS_DATABASE_ROUTES}
{PLUGIN_ADMIN_PERMISSIONS_TABLE_GROUP_ROUTES}
</Route>
))}
{GROUPS_PERMISSIONS_PATHS.map((path) => (
- <Route key={path} path={path} element={<GroupsPermissionsPage />}>
+ <Route key={path} path={path} lazy={groupsPermissions}>
{PLUGIN_ADMIN_PERMISSIONS_DATABASE_GROUP_ROUTES}
{PLUGIN_ADMIN_PERMISSIONS_TABLE_ROUTES}
</Route>
))}
</Route>
- <Route path="collections" element={<CollectionPermissionsPage />}>
+ <Route path="collections" lazy={collectionPermissions}>
<Route path=":collectionId" />
</Route>
diff --git a/frontend/src/metabase/admin/permissions/test/DatabasesPermissionsPage/DatabasesPermissionsPage.unit.spec.tsx b/frontend/src/metabase/admin/permissions/test/DatabasesPermissionsPage/DatabasesPermissionsPage.unit.spec.tsx
index 37b9e2b9d56..d827e11d4de 100644
--- a/frontend/src/metabase/admin/permissions/test/DatabasesPermissionsPage/DatabasesPermissionsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/test/DatabasesPermissionsPage/DatabasesPermissionsPage.unit.spec.tsx
@@ -14,7 +14,7 @@ import {
within,
} from "__support__/ui";
import { delay } from "__support__/utils";
-import DataPermissionsPage from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
+import { DataPermissionsPage } from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
import { DatabasesPermissionsPage } from "metabase/admin/permissions/pages/DatabasePermissionsPage/DatabasesPermissionsPage";
import { BEFORE_UNLOAD_UNSAVED_MESSAGE } from "metabase/common/hooks/use-before-unload";
import { PLUGIN_ADMIN_PERMISSIONS_TABLE_GROUP_ROUTES } from "metabase/plugins";
diff --git a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
index b0b2b6376c4..743541d12da 100644
--- a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPage.unit.spec.tsx
@@ -13,7 +13,7 @@ import {
waitForLoaderToBeRemoved,
} from "__support__/ui";
import { delay } from "__support__/utils";
-import DataPermissionsPage from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
+import { DataPermissionsPage } from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
import { GroupsPermissionsPage } from "metabase/admin/permissions/pages/GroupDataPermissionsPage/GroupsPermissionsPage";
import { BEFORE_UNLOAD_UNSAVED_MESSAGE } from "metabase/common/hooks/use-before-unload";
import { PLUGIN_ADMIN_PERMISSIONS_TABLE_ROUTES } from "metabase/plugins";
diff --git a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPageDrilldown.unit.spec.tsx b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPageDrilldown.unit.spec.tsx
index 441d767f445..1b35e526d9e 100644
--- a/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPageDrilldown.unit.spec.tsx
+++ b/frontend/src/metabase/admin/permissions/test/GroupsPermissionsPage/GroupsPermissionsPageDrilldown.unit.spec.tsx
@@ -12,7 +12,7 @@ import {
waitForLoaderToBeRemoved,
within,
} from "__support__/ui";
-import DataPermissionsPage from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
+import { DataPermissionsPage } from "metabase/admin/permissions/pages/DataPermissionsPage/DataPermissionsPage";
import { GroupsPermissionsPage } from "metabase/admin/permissions/pages/GroupDataPermissionsPage/GroupsPermissionsPage";
import { Route } from "metabase/router";
import { createMockGroup } from "metabase-types/api/mocks/group";
diff --git a/frontend/src/metabase/admin/routes.tsx b/frontend/src/metabase/admin/routes.tsx
index 6b1bb20a601..ad7bf575244 100644
--- a/frontend/src/metabase/admin/routes.tsx
+++ b/frontend/src/metabase/admin/routes.tsx
@@ -1,40 +1,13 @@
import type { Store } from "@reduxjs/toolkit";
-import { Fragment, createElement } from "react";
-
-import AdminApp from "metabase/admin/app/components/AdminApp";
-import { DatabaseEditApp } from "metabase/admin/databases/containers/DatabaseEditApp";
-import { DatabaseListApp } from "metabase/admin/databases/containers/DatabaseListApp";
-import { DatabasePage } from "metabase/admin/databases/containers/DatabasePage";
-import { RevisionHistoryApp } from "metabase/admin/datamodel/containers/RevisionHistoryApp";
-import { SegmentApp } from "metabase/admin/datamodel/containers/SegmentApp";
-import { SegmentListApp } from "metabase/admin/datamodel/containers/SegmentListApp";
-import { EmbeddingThemeEditorApp } from "metabase/admin/embedding/components/ThemeEditor";
-import { EmbeddingThemeListingApp } from "metabase/admin/embedding/components/ThemeListing";
-import { AdminEmbeddingApp } from "metabase/admin/embedding/containers/AdminEmbeddingApp";
-import { EmbeddingHubAdminSettingsPage } from "metabase/admin/embedding/embedding-hub";
-import { Help } from "metabase/admin/help";
-import { AdminPeopleApp } from "metabase/admin/people/containers/AdminPeopleApp";
+import { type ComponentProps, Fragment, createElement } from "react";
+
import { EditUserModal } from "metabase/admin/people/containers/EditUserModal";
-import { GroupDetailApp } from "metabase/admin/people/containers/GroupDetailApp";
-import { GroupsListingApp } from "metabase/admin/people/containers/GroupsListingApp";
import { NewUserModal } from "metabase/admin/people/containers/NewUserModal";
-import { PeopleListingApp } from "metabase/admin/people/containers/PeopleListingApp";
import { UserActivationModal } from "metabase/admin/people/containers/UserActivationModal";
import { UserPasswordResetModal } from "metabase/admin/people/containers/UserPasswordResetModal";
import { UserSuccessModal } from "metabase/admin/people/containers/UserSuccessModal";
-import { PerformanceApp } from "metabase/admin/performance/components/PerformanceApp";
import { getRoutes as getAdminPermissionsRoutes } from "metabase/admin/permissions/routes";
-import {
- EmbeddingSecuritySettings,
- EmbeddingSettings,
- GuestEmbedsSettings,
-} from "metabase/admin/settings/components/EmbeddingSettings";
import { modalRoute } from "metabase/common/components/ModalRoute";
-import {
- SetupPermissionsAndTenantsPage,
- SetupSsoPage,
-} from "metabase/embedding/embedding-hub";
-import { DataModelV1 } from "metabase/metadata/pages/DataModelV1";
import {
PLUGIN_ADMIN_USER_MENU_ROUTES,
PLUGIN_AI_CONTROLS,
@@ -50,19 +23,204 @@ import type { State } from "metabase/redux/store";
import { Route, type RouteComponent, redirect } from "metabase/router";
import { getTokenFeature } from "metabase/settings";
-import { AISettingsPage, McpSettingsPage } from "./ai/AISettingsPage";
-import { MetabotAdminLayout } from "./ai/MetabotAdminLayout";
-import { OAuthAuthorizationsPage } from "./ai/OAuthAuthorizationsPage";
-import { ModelPersistenceConfiguration } from "./performance/components/ModelPersistenceConfiguration";
-import { StrategyEditorForDatabases } from "./performance/components/StrategyEditorForDatabases";
+import type { MetabotAdminLayout } from "./ai/MetabotAdminLayout";
import { getSettingsRoutes } from "./settingsRoutes";
-import { UpsellTenants } from "./upsells/UpsellTenants";
import {
RedirectToAllowedSettings,
createAdminRouteGuard,
createTenantsRouteGuard,
} from "./utils";
+/**
+ * The admin pages, in one chunk. Every loader names it, so the section arrives
+ * in a single request rather than one per page.
+ *
+ * Route guards, the redirects and the modal routes stay eager: they are small,
+ * and a guard has to decide before there is anything to show. The pages behind
+ * them are fetched the first time one of these routes is matched.
+ */
+const adminApp = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/app/components/AdminApp"
+ ).then(({ AdminApp }) => ({ Component: AdminApp }));
+
+const databaseList = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/databases/containers/DatabaseListApp"
+ ).then(({ DatabaseListApp }) => ({ Component: DatabaseListApp }));
+
+const databasePage = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/databases/containers/DatabasePage"
+ ).then(({ DatabasePage }) => ({ Component: DatabasePage }));
+
+const databaseEdit = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/databases/containers/DatabaseEditApp"
+ ).then(({ DatabaseEditApp }) => ({ Component: DatabaseEditApp }));
+
+const dataModel = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/metadata/pages/DataModelV1"
+ ).then(({ DataModelV1 }) => ({
+ Component: DataModelV1,
+ }));
+
+const segmentList = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/datamodel/containers/SegmentListApp"
+ ).then(({ SegmentListApp }) => ({ Component: SegmentListApp }));
+
+const segmentEdit = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/datamodel/containers/SegmentApp"
+ ).then(({ SegmentApp }) => ({ Component: SegmentApp }));
+
+const segmentRevisions = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/datamodel/containers/RevisionHistoryApp"
+ ).then(({ RevisionHistoryApp }) => ({ Component: RevisionHistoryApp }));
+
+const peopleApp = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/people/containers/AdminPeopleApp"
+ ).then(({ AdminPeopleApp }) => ({ Component: AdminPeopleApp }));
+
+const peopleListing = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/people/containers/PeopleListingApp"
+ ).then(({ PeopleListingApp }) => ({ Component: PeopleListingApp }));
+
+const groupsListing = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/people/containers/GroupsListingApp"
+ ).then(({ GroupsListingApp }) => ({ Component: GroupsListingApp }));
+
+const groupDetail = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/people/containers/GroupDetailApp"
+ ).then(({ GroupDetailApp }) => ({ Component: GroupDetailApp }));
+
+const upsellTenants = () =>
+ import(/* webpackChunkName: "admin" */ "./upsells/UpsellTenants").then(
+ ({ UpsellTenants }) => ({
+ Component: UpsellTenants,
+ }),
+ );
+
+const embeddingApp = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/embedding/containers/AdminEmbeddingApp"
+ ).then(({ AdminEmbeddingApp }) => ({ Component: AdminEmbeddingApp }));
+
+const embeddingSettings = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/settings/components/EmbeddingSettings"
+ ).then(({ EmbeddingSettings }) => ({ Component: EmbeddingSettings }));
+
+const embeddingSecuritySettings = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/settings/components/EmbeddingSettings"
+ ).then(({ EmbeddingSecuritySettings }) => ({
+ Component: EmbeddingSecuritySettings,
+ }));
+
+const guestEmbedsSettings = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/settings/components/EmbeddingSettings"
+ ).then(({ GuestEmbedsSettings }) => ({ Component: GuestEmbedsSettings }));
+
+const embeddingHub = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/embedding/embedding-hub"
+ ).then(({ EmbeddingHubAdminSettingsPage }) => ({
+ Component: EmbeddingHubAdminSettingsPage,
+ }));
+
+const setupPermissions = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/embedding/embedding-hub"
+ ).then(({ SetupPermissionsAndTenantsPage }) => ({
+ Component: SetupPermissionsAndTenantsPage,
+ }));
+
+const setupSso = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/embedding/embedding-hub"
+ ).then(({ SetupSsoPage }) => ({
+ Component: SetupSsoPage,
+ }));
+
+const themeListing = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/embedding/components/ThemeListing"
+ ).then(({ EmbeddingThemeListingApp }) => ({
+ Component: EmbeddingThemeListingApp,
+ }));
+
+const themeEditor = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/embedding/components/ThemeEditor"
+ ).then(({ EmbeddingThemeEditorApp }) => ({
+ Component: EmbeddingThemeEditorApp,
+ }));
+
+const performanceApp = () =>
+ import(
+ /* webpackChunkName: "admin" */ "metabase/admin/performance/components/PerformanceApp"
+ ).then(({ PerformanceApp }) => ({ Component: PerformanceApp }));
+
+const strategyEditorForDatabases = () =>
+ import(
+ /* webpackChunkName: "admin" */ "./performance/components/StrategyEditorForDatabases"
+ ).then(({ StrategyEditorForDatabases }) => ({
+ Component: StrategyEditorForDatabases,
+ }));
+
+const modelPersistence = () =>
+ import(
+ /* webpackChunkName: "admin" */ "./performance/components/ModelPersistenceConfiguration"
+ ).then(({ ModelPersistenceConfiguration }) => ({
+ Component: ModelPersistenceConfiguration,
+ }));
+
+// `route.lazy` supplies a component and no props, so the three routes that
+// share this layout bind theirs here.
+const metabotLayout =
+ (props: ComponentProps<typeof MetabotAdminLayout> = {}) =>
+ () =>
+ import(/* webpackChunkName: "admin" */ "./ai/MetabotAdminLayout").then(
+ ({ MetabotAdminLayout }) => ({
+ Component: function MetabotAdminLayoutRoute() {
+ return <MetabotAdminLayout {...props} />;
+ },
+ }),
+ );
+
+const aiSettings = () =>
+ import(/* webpackChunkName: "admin" */ "./ai/AISettingsPage").then(
+ ({ AISettingsPage }) => ({
+ Component: AISettingsPage,
+ }),
+ );
+
+const mcpSettings = () =>
+ import(/* webpackChunkName: "admin" */ "./ai/AISettingsPage").then(
+ ({ McpSettingsPage }) => ({
+ Component: McpSettingsPage,
+ }),
+ );
+
+const oauthAuthorizations = () =>
+ import(/* webpackChunkName: "admin" */ "./ai/OAuthAuthorizationsPage").then(
+ ({ OAuthAuthorizationsPage }) => ({ Component: OAuthAuthorizationsPage }),
+ );
+
+const help = () =>
+ import(/* webpackChunkName: "admin" */ "metabase/admin/help").then(
+ ({ Help }) => ({ Component: Help }),
+ );
+
export const getRoutes = (
store: Store<State>,
CanAccessSettings: RouteComponent,
@@ -73,19 +231,19 @@ export const getRoutes = (
return (
<Route path="/admin" element={<CanAccessSettings />}>
- <Route element={<AdminApp />}>
+ <Route lazy={adminApp}>
<Route index element={<RedirectToAllowedSettings />} />
<Route
path="databases"
element={createElement(createAdminRouteGuard("databases"))}
>
- <Route index element={<DatabaseListApp />} />
+ <Route index lazy={databaseList} />
<Route element={<IsAdmin />}>
- <Route path="create" element={<DatabasePage />} />
+ <Route path="create" lazy={databasePage} />
</Route>
- <Route path=":databaseId/edit" element={<DatabasePage />} />
+ <Route path=":databaseId/edit" lazy={databasePage} />
{PLUGIN_WRITABLE_CONNECTION.getWritableConnectionInfoRoutes(IsAdmin)}
- <Route path=":databaseId" element={<DatabaseEditApp />}>
+ <Route path=":databaseId" lazy={databaseEdit}>
{PLUGIN_DB_ROUTING.getDestinationDatabaseRoutes(IsAdmin)}
</Route>
</Route>
@@ -95,32 +253,29 @@ export const getRoutes = (
>
<Route>
<Route index element={redirect("database")} />
- <Route path="database" element={<DataModelV1 />} />
- <Route path="database/:databaseId" element={<DataModelV1 />} />
+ <Route path="database" lazy={dataModel} />
+ <Route path="database/:databaseId" lazy={dataModel} />
<Route
path="database/:databaseId/schema/:schemaId"
- element={<DataModelV1 />}
+ lazy={dataModel}
/>
<Route
path="database/:databaseId/schema/:schemaId/table/:tableId"
- element={<DataModelV1 />}
+ lazy={dataModel}
/>
<Route
path="database/:databaseId/schema/:schemaId/table/:tableId/field/:fieldId"
- element={<DataModelV1 />}
+ lazy={dataModel}
/>
- <Route element={<DataModelV1 />}>
- <Route path="segments" element={<SegmentListApp />} />
+ <Route lazy={dataModel}>
+ <Route path="segments" lazy={segmentList} />
<Route path="segment/create" element={<IsAdmin />}>
- <Route index element={<SegmentApp />} />
+ <Route index lazy={segmentEdit} />
</Route>
<Route path="segment/:id" element={<IsAdmin />}>
- <Route index element={<SegmentApp />} />
+ <Route index lazy={segmentEdit} />
</Route>
- <Route
- path="segment/:id/revisions"
- element={<RevisionHistoryApp />}
- />
+ <Route path="segment/:id/revisions" lazy={segmentRevisions} />
</Route>
<Route
path="database/:databaseId/schema/:schemaId/table/:tableId/settings"
@@ -141,13 +296,13 @@ export const getRoutes = (
path="people"
element={createElement(createAdminRouteGuard("people"))}
>
- <Route element={<AdminPeopleApp />}>
- <Route index element={<PeopleListingApp />} />
+ <Route lazy={peopleApp}>
+ <Route index lazy={peopleListing} />
{/*NOTE: this must come before the other routes otherwise it will be masked by them*/}
<Route path="groups">
- <Route index element={<GroupsListingApp />} />
- <Route path=":groupId" element={<GroupDetailApp />} />
+ <Route index lazy={groupsListing} />
+ <Route path=":groupId" lazy={groupDetail} />
</Route>
{/* Tenants */}
@@ -157,19 +312,19 @@ export const getRoutes = (
>
{PLUGIN_TENANTS.tenantsRoutes ?? (
<>
- <Route index element={<UpsellTenants />} />
- <Route path="groups" element={<UpsellTenants />} />
- <Route path="people" element={<UpsellTenants />} />
+ <Route index lazy={upsellTenants} />
+ <Route path="groups" lazy={upsellTenants} />
+ <Route path="people" lazy={upsellTenants} />
</>
)}
</Route>
- <Route path="" element={<PeopleListingApp />}>
+ <Route path="" lazy={peopleListing}>
{modalRoute("new", NewUserModal, { noWrap: true })}
{PLUGIN_TENANTS.userStrategyRoute}
</Route>
- <Route path=":userId" element={<PeopleListingApp />}>
+ <Route path=":userId" lazy={peopleListing}>
<Route index element={redirect("/admin/people")} />
{modalRoute("edit", EditUserModal, { noWrap: true })}
{modalRoute("success", UserSuccessModal, { noWrap: true })}
@@ -188,31 +343,25 @@ export const getRoutes = (
path="embedding"
element={createElement(createAdminRouteGuard("embedding"))}
>
- <Route element={<AdminEmbeddingApp />}>
- <Route index element={<EmbeddingSettings />} />
+ <Route lazy={embeddingApp}>
+ <Route index lazy={embeddingSettings} />
<Route path="setup-guide">
- <Route index element={<EmbeddingHubAdminSettingsPage />} />
+ <Route index lazy={embeddingHub} />
- <Route
- path="permissions"
- element={<SetupPermissionsAndTenantsPage />}
- />
+ <Route path="permissions" lazy={setupPermissions} />
- <Route path="sso" element={<SetupSsoPage />} />
+ <Route path="sso" lazy={setupSso} />
</Route>
{/* EE with non-starter plan has embedding settings on different pages */}
{hasSimpleEmbedding && (
- <Route path="guest" element={<GuestEmbedsSettings />} />
+ <Route path="guest" lazy={guestEmbedsSettings} />
)}
- <Route path="security" element={<EmbeddingSecuritySettings />} />
- <Route path="themes" element={<EmbeddingThemeListingApp />} />
- <Route
- path="themes/:themeId"
- element={<EmbeddingThemeEditorApp />}
- />
+ <Route path="security" lazy={embeddingSecuritySettings} />
+ <Route path="themes" lazy={themeListing} />
+ <Route path="themes/:themeId" lazy={themeEditor} />
</Route>
</Route>
@@ -267,10 +416,10 @@ export const getRoutes = (
path="performance"
element={createElement(createAdminRouteGuard("performance"))}
>
- <Route element={<PerformanceApp />}>
+ <Route lazy={performanceApp}>
<Route index element={redirect(PerformanceTabId.Databases)} />
- <Route path="databases" element={<StrategyEditorForDatabases />} />
- <Route path="models" element={<ModelPersistenceConfiguration />} />
+ <Route path="databases" lazy={strategyEditorForDatabases} />
+ <Route path="models" lazy={modelPersistence} />
<Route
path="dashboards-and-questions"
element={
@@ -285,35 +434,28 @@ export const getRoutes = (
path="metabot"
element={createElement(createAdminRouteGuard("metabot"))}
>
- <Route key="index-layout" element={<MetabotAdminLayout />}>
- <Route index key="index" element={<AISettingsPage />} />
- <Route key="mcp" path="mcp" element={<McpSettingsPage />} />
+ <Route key="index-layout" lazy={metabotLayout()}>
+ <Route index key="index" lazy={aiSettings} />
+ <Route key="mcp" path="mcp" lazy={mcpSettings} />
</Route>
<Route
key="mcp-authorizations-layout"
- element={
- <MetabotAdminLayout
- fullWidth
- innerContentProps={{ fullWidth: true, fullHeight: true }}
- />
- }
+ lazy={metabotLayout({
+ fullWidth: true,
+ innerContentProps: { fullWidth: true, fullHeight: true },
+ })}
>
- <Route
- path="mcp/authorizations"
- element={<OAuthAuthorizationsPage />}
- />
+ <Route path="mcp/authorizations" lazy={oauthAuthorizations} />
</Route>
<Route
key="layout"
- element={
- <MetabotAdminLayout
- fullWidth={!PLUGIN_AI_CONTROLS.isEnabled}
- innerContentProps={{
- fullWidth: !PLUGIN_AI_CONTROLS.isEnabled,
- fullHeight: !PLUGIN_AI_CONTROLS.isEnabled,
- }}
- />
- }
+ lazy={metabotLayout({
+ fullWidth: !PLUGIN_AI_CONTROLS.isEnabled,
+ innerContentProps: {
+ fullWidth: !PLUGIN_AI_CONTROLS.isEnabled,
+ fullHeight: !PLUGIN_AI_CONTROLS.isEnabled,
+ },
+ })}
>
{PLUGIN_AI_CONTROLS.getAiControlsRoutes()}
</Route>
@@ -327,7 +469,7 @@ export const getRoutes = (
)}
<Route element={createElement(createAdminRouteGuard("help"))}>
- <Route path="help" element={<Help />}>
+ <Route path="help" lazy={help}>
{PLUGIN_SUPPORT.isEnabled &&
modalRoute("grant-access", PLUGIN_SUPPORT.GrantAccessModal)}
</Route>
diff --git a/frontend/src/metabase/admin/routes.unit.spec.tsx b/frontend/src/metabase/admin/routes.unit.spec.tsx
new file mode 100644
index 00000000000..2c59e9c09a2
--- /dev/null
+++ b/frontend/src/metabase/admin/routes.unit.spec.tsx
@@ -0,0 +1,64 @@
+import type { ReactNode } from "react";
+
+import { getStore, mainReducers } from "__support__/entities-store";
+import { createMockSettingsState } from "metabase/redux/store/mocks";
+import { type RouteObject, toRouteObjects } from "metabase/router";
+
+import { getRoutes } from "./routes";
+import { getSettingsRoutes } from "./settingsRoutes";
+
+/**
+ * These routes name their page in an `import()` rather than importing it, so
+ * nothing type-checks the path or the export any more, and nothing renders the
+ * admin tree in a test. A typo would first show up as a blank admin page.
+ * Resolving every loader is the cheap guard against that.
+ */
+function lazyLoaders(tree: ReactNode) {
+ const loaders: (() => Promise<{ Component?: unknown }>)[] = [];
+
+ const collect = (routes: RouteObject[]) => {
+ for (const route of routes) {
+ if (typeof route.lazy === "function") {
+ loaders.push(route.lazy);
+ }
+ collect(route.children ?? []);
+ }
+ };
+
+ collect(toRouteObjects(tree));
+ return loaders;
+}
+
+const Guard = () => null;
+
+// A real store: `getRoutes` reads a setting off it to decide whether the custom
+// visualisation development route exists at all.
+function createStore() {
+ return getStore(mainReducers, {
+ settings: createMockSettingsState({
+ "custom-viz-plugin-dev-mode-enabled": true,
+ }),
+ });
+}
+
+describe("admin routes", () => {
+ it("resolves every page in the admin tree", async () => {
+ const loaders = lazyLoaders(getRoutes(createStore(), Guard, Guard));
+
+ expect(loaders.length).toBeGreaterThan(30);
+
+ for (const load of loaders) {
+ expect((await load()).Component).toBeDefined();
+ }
+ });
+
+ it("resolves every page in the settings tree", async () => {
+ const loaders = lazyLoaders(getSettingsRoutes(createStore(), Guard));
+
+ expect(loaders.length).toBeGreaterThan(20);
+
+ for (const load of loaders) {
+ expect((await load()).Component).toBeDefined();
+ }
+ });
+});
diff --git a/frontend/src/metabase/admin/settingsRoutes.tsx b/frontend/src/metabase/admin/settingsRoutes.tsx
index 7c2a2b967e7..1e1ae242582 100644
--- a/frontend/src/metabase/admin/settingsRoutes.tsx
+++ b/frontend/src/metabase/admin/settingsRoutes.tsx
@@ -1,6 +1,5 @@
import type { Store } from "@reduxjs/toolkit";
-import { AdminSettingsLayout } from "metabase/admin/components/AdminLayout/AdminSettingsLayout";
import { NotFound } from "metabase/common/components/ErrorPages";
import {
PLUGIN_AUTH_PROVIDERS,
@@ -13,29 +12,159 @@ import { Outlet, Route, type RouteComponent, redirect } from "metabase/router";
import { getSetting } from "metabase/settings";
import * as Urls from "metabase/urls";
-import { GoogleAuthForm } from "./settings/auth/components/GoogleAuthForm";
-import { SettingsLdapForm } from "./settings/components/SettingsLdapForm";
-import { SettingsNav } from "./settings/components/SettingsNav";
-import { AppearanceSettingsPage } from "./settings/components/SettingsPages/AppearanceSettingsPage";
-import { AuthenticationSettingsPage } from "./settings/components/SettingsPages/AuthenticationSettingsPage";
-import { CloudSettingsPage } from "./settings/components/SettingsPages/CloudSettingsPage";
-import {
- CustomVisualizationsDevelopmentPage,
- CustomVisualizationsFormPage,
- CustomVisualizationsManagePage,
-} from "./settings/components/SettingsPages/CustomVisualizationsSettingsPage";
-import { DataAppsManagePage } from "./settings/components/SettingsPages/DataAppsSettingsPage";
-import { EmailSettingsPage } from "./settings/components/SettingsPages/EmailSettingsPage";
-import { GeneralSettingsPage } from "./settings/components/SettingsPages/GeneralSettingsPage";
-import { LicenseSettingsPage } from "./settings/components/SettingsPages/LicenseSettingsPage";
-import { LocalizationSettingsPage } from "./settings/components/SettingsPages/LocalizationSettingsPage";
-import { MapsSettingsPage } from "./settings/components/SettingsPages/MapsSettingsPage";
-import { PublicSharingSettingsPage } from "./settings/components/SettingsPages/PublicSharingSettingsPage";
-import { RemoteSyncSettingsPage } from "./settings/components/SettingsPages/RemoteSyncSettingsPage";
-import { SlackSettingsPage } from "./settings/components/SettingsPages/SlackSettingsPage";
-import { UpdatesSettingsPage } from "./settings/components/SettingsPages/UpdatesSettingsPage";
-import { UploadSettingsPage } from "./settings/components/SettingsPages/UploadSettingsPage";
-import { WebhooksSettingsPage } from "./settings/components/SettingsPages/WebhooksSettingsPage";
+/**
+ * The admin settings pages, in one chunk. Every loader names it, so the section
+ * arrives in a single request rather than one per page.
+ *
+ * This module holds paths and `import()` calls, so the admin route tree can name
+ * it eagerly while none of the pages are in the initial bundle. They are fetched
+ * the first time one of these routes is matched.
+ *
+ * The nav and the layout load together with the first page rather than ahead of
+ * it: they are only ever seen inside this section, so there is nothing to gain
+ * from splitting them apart.
+ */
+const settingsLayout = () =>
+ Promise.all([
+ import(
+ /* webpackChunkName: "admin-settings" */ "metabase/admin/components/AdminLayout/AdminSettingsLayout"
+ ),
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsNav"
+ ),
+ ]).then(([{ AdminSettingsLayout }, { SettingsNav }]) => ({
+ Component: function AdminSettingsLayoutRoute() {
+ return (
+ <AdminSettingsLayout sidebar={<SettingsNav />}>
+ <Outlet />
+ </AdminSettingsLayout>
+ );
+ },
+ }));
+
+const generalSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/GeneralSettingsPage"
+ ).then(({ GeneralSettingsPage }) => ({ Component: GeneralSettingsPage }));
+
+const updatesSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/UpdatesSettingsPage"
+ ).then(({ UpdatesSettingsPage }) => ({ Component: UpdatesSettingsPage }));
+
+const emailSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/EmailSettingsPage"
+ ).then(({ EmailSettingsPage }) => ({ Component: EmailSettingsPage }));
+
+const slackSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/SlackSettingsPage"
+ ).then(({ SlackSettingsPage }) => ({ Component: SlackSettingsPage }));
+
+const webhooksSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/WebhooksSettingsPage"
+ ).then(({ WebhooksSettingsPage }) => ({ Component: WebhooksSettingsPage }));
+
+// `route.lazy` supplies a component and no props, so the routes that share this
+// page bind their tab here.
+const authenticationSettings =
+ (tab: "authentication" | "user-provisioning" | "api-keys") => () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/AuthenticationSettingsPage"
+ ).then(({ AuthenticationSettingsPage }) => ({
+ Component: function AuthenticationSettingsRoute() {
+ return <AuthenticationSettingsPage tab={tab} />;
+ },
+ }));
+
+const googleAuth = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/auth/components/GoogleAuthForm"
+ ).then(({ GoogleAuthForm }) => ({ Component: GoogleAuthForm }));
+
+const ldapAuth = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsLdapForm"
+ ).then(({ SettingsLdapForm }) => ({ Component: SettingsLdapForm }));
+
+const remoteSyncSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/RemoteSyncSettingsPage"
+ ).then(({ RemoteSyncSettingsPage }) => ({
+ Component: RemoteSyncSettingsPage,
+ }));
+
+const mapsSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/MapsSettingsPage"
+ ).then(({ MapsSettingsPage }) => ({ Component: MapsSettingsPage }));
+
+const localizationSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/LocalizationSettingsPage"
+ ).then(({ LocalizationSettingsPage }) => ({
+ Component: LocalizationSettingsPage,
+ }));
+
+const customVisualizationsManage = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/CustomVisualizationsSettingsPage"
+ ).then(({ CustomVisualizationsManagePage }) => ({
+ Component: CustomVisualizationsManagePage,
+ }));
+
+const customVisualizationsForm = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/CustomVisualizationsSettingsPage"
+ ).then(({ CustomVisualizationsFormPage }) => ({
+ Component: CustomVisualizationsFormPage,
+ }));
+
+const customVisualizationsDevelopment = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/CustomVisualizationsSettingsPage"
+ ).then(({ CustomVisualizationsDevelopmentPage }) => ({
+ Component: CustomVisualizationsDevelopmentPage,
+ }));
+
+const dataAppsManage = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/DataAppsSettingsPage"
+ ).then(({ DataAppsManagePage }) => ({ Component: DataAppsManagePage }));
+
+const uploadSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/UploadSettingsPage"
+ ).then(({ UploadSettingsPage }) => ({ Component: UploadSettingsPage }));
+
+const publicSharingSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/PublicSharingSettingsPage"
+ ).then(({ PublicSharingSettingsPage }) => ({
+ Component: PublicSharingSettingsPage,
+ }));
+
+const licenseSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/LicenseSettingsPage"
+ ).then(({ LicenseSettingsPage }) => ({ Component: LicenseSettingsPage }));
+
+/** The `appearance` page, opened on one of its tabs. */
+const appearanceSettings = (tab?: "branding" | "conceal-metabase") => () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/AppearanceSettingsPage"
+ ).then(({ AppearanceSettingsPage }) => ({
+ Component: function AppearanceSettingsRoute() {
+ return <AppearanceSettingsPage tab={tab} />;
+ },
+ }));
+
+const cloudSettings = () =>
+ import(
+ /* webpackChunkName: "admin-settings" */ "./settings/components/SettingsPages/CloudSettingsPage"
+ ).then(({ CloudSettingsPage }) => ({ Component: CloudSettingsPage }));
export const getSettingsRoutes = (
store: Store<State>,
@@ -47,30 +176,24 @@ export const getSettingsRoutes = (
);
return (
- <Route
- element={
- <AdminSettingsLayout sidebar={<SettingsNav />}>
- <Outlet />
- </AdminSettingsLayout>
- }
- >
+ <Route lazy={settingsLayout}>
<Route index element={redirect("general")} />
- <Route path="general" element={<GeneralSettingsPage />} />
- <Route path="updates" element={<UpdatesSettingsPage />} />
- <Route path="email" element={<EmailSettingsPage />} />
- <Route path="slack" element={<SlackSettingsPage />} />
- <Route path="webhooks" element={<WebhooksSettingsPage />} />
+ <Route path="general" lazy={generalSettings} />
+ <Route path="updates" lazy={updatesSettings} />
+ <Route path="email" lazy={emailSettings} />
+ <Route path="slack" lazy={slackSettings} />
+ <Route path="webhooks" lazy={webhooksSettings} />
<Route
path="authentication"
- element={<AuthenticationSettingsPage tab="authentication" />}
+ lazy={authenticationSettings("authentication")}
/>
<Route
path="authentication/user-provisioning"
- element={<AuthenticationSettingsPage tab="user-provisioning" />}
+ lazy={authenticationSettings("user-provisioning")}
/>
<Route
path="authentication/api-keys"
- element={<AuthenticationSettingsPage tab="api-keys" />}
+ lazy={authenticationSettings("api-keys")}
/>
<Route path="authentication/2fa" element={<IsAdmin />}>
<Route
@@ -82,8 +205,8 @@ export const getSettingsRoutes = (
element={<PLUGIN_MULTI_FACTOR_AUTH.UnenrolledUsersPage />}
/>
</Route>
- <Route path="authentication/google" element={<GoogleAuthForm />} />
- <Route path="authentication/ldap" element={<SettingsLdapForm />} />
+ <Route path="authentication/google" lazy={googleAuth} />
+ <Route path="authentication/ldap" lazy={ldapAuth} />
<Route
path="authentication/saml"
element={<PLUGIN_AUTH_PROVIDERS.SettingsSAMLForm />}
@@ -96,22 +219,19 @@ export const getSettingsRoutes = (
path="authentication/oidc"
element={<PLUGIN_AUTH_PROVIDERS.SettingsOIDCForm />}
/>
- <Route path="remote-sync" element={<RemoteSyncSettingsPage />} />
- <Route path="maps" element={<MapsSettingsPage />} />
- <Route path="localization" element={<LocalizationSettingsPage />} />
+ <Route path="remote-sync" lazy={remoteSyncSettings} />
+ <Route path="maps" lazy={mapsSettings} />
+ <Route path="localization" lazy={localizationSettings} />
<Route
path="custom-visualizations"
/* do not allow users with "Settings access" permissions to access custom viz pages */
element={<IsAdmin />}
>
- <Route index element={<CustomVisualizationsManagePage />} />
- <Route path="new" element={<CustomVisualizationsFormPage />} />
- <Route path="edit/:id" element={<CustomVisualizationsFormPage />} />
+ <Route index lazy={customVisualizationsManage} />
+ <Route path="new" lazy={customVisualizationsForm} />
+ <Route path="edit/:id" lazy={customVisualizationsForm} />
{devModeEnabled && (
- <Route
- path="development"
- element={<CustomVisualizationsDevelopmentPage />}
- />
+ <Route path="development" lazy={customVisualizationsDevelopment} />
)}
</Route>
{/* TODO(v65): data apps launch in v65 — drop the isEnabled gate then so the
@@ -123,30 +243,24 @@ export const getSettingsRoutes = (
} /* do not allow users with "Settings access" permissions to access data apps pages */
element={<IsAdmin />}
>
- <Route index element={<DataAppsManagePage />} />
+ <Route index lazy={dataAppsManage} />
</Route>
)}
- <Route path="uploads" element={<UploadSettingsPage />} />
+ <Route path="uploads" lazy={uploadSettings} />
<Route
path="python-runner"
element={<PLUGIN_TRANSFORMS_PYTHON.PythonRunnerSettingsPage />}
/>
- <Route path="public-sharing" element={<PublicSharingSettingsPage />} />
- <Route path="license" element={<LicenseSettingsPage />} />
- <Route path="appearance" element={<AppearanceSettingsPage />} />
- <Route
- path="whitelabel"
- element={<AppearanceSettingsPage tab="branding" />}
- />
- <Route
- path="whitelabel/branding"
- element={<AppearanceSettingsPage tab="branding" />}
- />
+ <Route path="public-sharing" lazy={publicSharingSettings} />
+ <Route path="license" lazy={licenseSettings} />
+ <Route path="appearance" lazy={appearanceSettings()} />
+ <Route path="whitelabel" lazy={appearanceSettings("branding")} />
+ <Route path="whitelabel/branding" lazy={appearanceSettings("branding")} />
<Route
path="whitelabel/conceal-metabase"
- element={<AppearanceSettingsPage tab="conceal-metabase" />}
+ lazy={appearanceSettings("conceal-metabase")}
/>
- <Route path="cloud" element={<CloudSettingsPage />} />
+ <Route path="cloud" lazy={cloudSettings} />
<Route path="*" element={<NotFound />} />
</Route>
);