The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Drive the delayed loader test with fake timers (#84808)
Romeo Van Snick0a2ee27b764a
diff --git a/frontend/src/metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper.unit.spec.tsx b/frontend/src/metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper.unit.spec.tsxindex 4d35d72d6d0..3bc3a381d3b 100644--- a/frontend/src/metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper.unit.spec.tsx+++ b/frontend/src/metabase/common/components/LoadingAndErrorWrapper/DelayedLoadingAndErrorWrapper.unit.spec.tsx@@ -1,4 +1,4 @@-import { render, screen } from "__support__/ui";+import { act, render, screen } from "__support__/ui";import { DelayedLoadingAndErrorWrapper } from "./DelayedLoadingAndErrorWrapper";@@ -10,18 +10,37 @@ describe("DelayedLoadingAndErrorWrapper", () => {expect(screen.getByTestId("loading-indicator")).toBeInTheDocument();});- it("should display a delayed loader if given a true loading prop", async () => {- render(- <DelayedLoadingAndErrorWrapper- loader={<div data-testid="loader"></div>}- delay={100}- error={false}- loading={true}- />,- );+ describe("with a delay", () => {+ beforeEach(() => {+ jest.useFakeTimers();+ });- expect(screen.getByTestId("loading-indicator")).toBeInTheDocument();- await screen.findByTestId("loader", undefined, { timeout: 150 });+ afterEach(() => {+ jest.useRealTimers();+ });++ it("should display a delayed loader only once the delay has passed", () => {+ render(+ <DelayedLoadingAndErrorWrapper+ loader={<div data-testid="loader"></div>}+ delay={100}+ error={false}+ loading={true}+ />,+ );++ expect(screen.getByTestId("loading-indicator")).toBeInTheDocument();+ expect(screen.queryByTestId("loader")).not.toBeInTheDocument();++ act(() => {+ jest.advanceTimersByTime(100);+ });++ expect(screen.getByTestId("loader")).toBeInTheDocument();+ expect(+ screen.queryByTestId("loading-indicator"),+ ).not.toBeInTheDocument();+ });});it("should display a given child if loading is false", () => {