Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix a very foolish mistake around percentages for health inspector. (#75890)

technomancy0a858152c136
diff --git a/src/metabase/health_inspector/core.clj b/src/metabase/health_inspector/core.clj
index cd73c632ba6..dc7e8dd66fd 100644
--- a/src/metabase/health_inspector/core.clj
+++ b/src/metabase/health_inspector/core.clj
@@ -24,9 +24,11 @@
(inc valid)
valid)}))
-(defn- percent [n] (* 100 (int n)))
+(defn- percent [n] (int (* 100 n)))
-(defn- validate-queries []
+(defn ^:internal validate-queries
+ "Determine how many saved queries are valid according to the malli schema."
+ []
(let [queries (t2/reducible-select :report_card {:where [:= :archived false]})
{:keys [total valid]} (reduce validate-query {:total 0 :valid 0} queries)
ratio (if (zero? total)
diff --git a/test/metabase/health_inspector/core_test.clj b/test/metabase/health_inspector/core_test.clj
index b2c03126eb2..bac1fce2bc9 100644
--- a/test/metabase/health_inspector/core_test.clj
+++ b/test/metabase/health_inspector/core_test.clj
@@ -2,6 +2,7 @@
(:require
[clojure.test :refer :all]
[metabase.health-inspector.core :as hi]
+ [metabase.util.json :as json]
[toucan2.core :as t2]))
(defn- test-check []
@@ -18,6 +19,21 @@
(testing "validate-queries works"
(is (= 100 (-> report :validate-queries :health))))))
+(deftest validate-queries*-works
+ (let [bad-query {"database" 1
+ "query" {"expressions" "extremely invalid"
+ "source-table" 2}
+ "type" "query"}
+ bad-card (assoc (dissoc (t2/select-one :report_card) :id :entity_id)
+ :dataset_query (json/encode bad-query)
+ :description "bad query")
+ bad (t2/insert! :report_card bad-card)]
+ (try
+ (let [{:keys [health message]} (hi/validate-queries)]
+ (is (< 0 health 100))
+ (is (= "Some queries are invalid." message)))
+ (finally (t2/delete! :report_card bad)))))
+
(deftest report-db-test
(t2/delete! :health_inspector_runs)
(hi/save-report)