Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-2459: Update Tooltip component (#79994)

Stas Gavrylov0c5d3b3a5962
diff --git a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png
index ff3d2b370cd..655ca584b64 100644
Binary files a/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png and b/.loki/reference/chrome_laptop_App_Embed_PublicOrEmbeddedDashboardView_Component_Compatibility.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Long_Content_With_Fixed_Width.png b/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Long_Content_With_Fixed_Width.png
index 9eaddf77b3b..f94abba2c10 100644
Binary files a/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Long_Content_With_Fixed_Width.png and b/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Long_Content_With_Fixed_Width.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Overview.png b/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Overview.png
new file mode 100644
index 00000000000..cf312a1e19e
Binary files /dev/null and b/.loki/reference/chrome_laptop_Components_Overlays_Tooltip_Overview.png differ
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png b/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png
index cd59c9bfc4e..0b2f3b2869d 100644
Binary files a/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png and b/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png differ
diff --git a/.loki/reference/chrome_laptop_viz_Scalar_With_Formatting_And_Hover.png b/.loki/reference/chrome_laptop_viz_Scalar_With_Formatting_And_Hover.png
index 91f6d299bb9..47af6d2e25b 100644
Binary files a/.loki/reference/chrome_laptop_viz_Scalar_With_Formatting_And_Hover.png and b/.loki/reference/chrome_laptop_viz_Scalar_With_Formatting_And_Hover.png differ
diff --git a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.config.tsx b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.config.tsx
index 0fb70481f4a..3b29166aa6d 100644
--- a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.config.tsx
+++ b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.config.tsx
@@ -8,10 +8,17 @@ import { PORTAL_CONTAINER_ID } from "../PortalContainer/constants";
import TooltipStyles from "./Tooltip.module.css";
+const ARROW_WIDTH = 9;
+const ARROW_SIZE = ARROW_WIDTH / Math.SQRT2;
+const ARROW_TO_TARGET_GAP = 8;
+
export const tooltipOverrides: MantineThemeOverride["components"] = {
Tooltip: Tooltip.extend({
defaultProps: {
- arrowSize: 10,
+ // `arrowSize` is the side of the square that renders the 9px-wide arrow.
+ arrowSize: ARROW_SIZE,
+ offset: ARROW_TO_TARGET_GAP + (ARROW_WIDTH - ARROW_SIZE) / 2,
+ radius: "md",
withArrow: true,
withinPortal: true,
// Mantine puts Tooltip, Popover and Menu on the same "popover" tier, so a
diff --git a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.mdx b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.mdx
index 7d6c0269061..8fcdf2e17de 100644
--- a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.mdx
+++ b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.mdx
@@ -7,11 +7,11 @@ import * as TooltipStories from "./Tooltip.stories";
# Tooltip
-Our themed wrapper around [Mantine Tooltip](https://v6.mantine.dev/core/tooltip/).
+Our themed wrapper around [Mantine Tooltip](https://mantine.dev/core/tooltip/).
## Docs
-- [Mantine Tooltip Docs](https://v6.mantine.dev/core/tooltip/)
+- [Mantine Tooltip Docs](https://mantine.dev/core/tooltip/)
## Examples
diff --git a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.module.css b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.module.css
index 4845cd042dc..58d1d78c5ce 100644
--- a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.module.css
+++ b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.module.css
@@ -1,8 +1,11 @@
.tooltip {
+ box-shadow: var(--mantine-shadow-sm);
color: var(--mb-color-tooltip-text);
font-size: var(--mantine-font-size-sm);
- font-weight: bold;
- padding: 0.6rem 0.75rem;
+ font-weight: normal;
+ line-height: var(--mantine-line-height-sm);
+ /* The 6px vertical padding from Figma has no matching spacing token. */
+ padding: 6px var(--mantine-spacing-sm);
white-space: unset;
max-width: 320px;
/* Break long unbreakable strings so the tooltip can't overflow its max-width (metabase#74433). */
diff --git a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.stories.tsx b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.stories.tsx
index b3fda9beff9..40f7710ebaf 100644
--- a/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.stories.tsx
+++ b/frontend/src/metabase/ui/components/overlays/Tooltip/Tooltip.stories.tsx
@@ -1,4 +1,9 @@
-import { Button, Flex, Tooltip, type TooltipProps } from "metabase/ui";
+import type { StoryFn } from "@storybook/react";
+
+import { Box, Button, Flex, Tooltip, type TooltipProps } from "metabase/ui";
+import { StoryJsx, StoryShowcase } from "metabase/ui/stories/showcase";
+
+const POSITIONS = ["top", "bottom", "left", "right"] as const;
const args = {
label: "Tooltip",
@@ -39,6 +44,37 @@ const DefaultTemplate = (args: TooltipProps) => (
</Flex>
);
+const OverviewTemplate: StoryFn<TooltipProps> = ({ label }) => (
+ <StoryShowcase title="Tooltip">
+ <Box
+ style={{
+ display: "grid",
+ gridTemplateColumns: `repeat(${POSITIONS.length}, max-content)`,
+ columnGap: "2rem",
+ rowGap: "1rem",
+ }}
+ >
+ {POSITIONS.map((position) => (
+ <StoryJsx key={position}>
+ {`<Tooltip position="${position}" />`}
+ </StoryJsx>
+ ))}
+ {POSITIONS.map((position) => (
+ <Flex key={position} align="center" justify="center" w={140} h={100}>
+ <Tooltip
+ label={label}
+ opened
+ position={position}
+ withinPortal={false}
+ >
+ <Button variant="filled">Target</Button>
+ </Tooltip>
+ </Flex>
+ ))}
+ </Box>
+ </StoryShowcase>
+);
+
export default {
title: "Components/Overlays/Tooltip",
component: Tooltip,
@@ -51,6 +87,13 @@ export const Default = {
parameters: { loki: { skip: true } },
};
+export const Overview = {
+ render: OverviewTemplate,
+ parameters: {
+ controls: { include: ["label", "theme"] },
+ },
+};
+
export const LongContentWithFixedWidth = {
render: DefaultTemplate,
args: {