Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Exclude netty from main uberjar; split 4.1/4.2 netty pins by driver (#72787)

Edward Paget0dfe41db2aee
diff --git a/deps.edn b/deps.edn
index b18da8d181a..ffc94981636 100644
--- a/deps.edn
+++ b/deps.edn
@@ -90,8 +90,6 @@
:git/sha "ffc4edc482c057cd9412c62f018a41e9140c618b"
:git/url "https://github.com/eerohele/pp"}
io.github.metabase/macaw {:mvn/version "0.2.36"} ; Parse native SQL queries
- io.netty/netty-codec-http {:mvn/version "4.2.12.Final"} ; override of transitive dep from aws s3
- io.netty/netty-codec-http2 {:mvn/version "4.2.12.Final"} ; override of transitive dep from aws s3
io.prometheus/simpleclient_hotspot {:mvn/version "0.16.0"} ; prometheus jvm collector
junegunn/grouper {:mvn/version "0.1.1"} ; Batch processing helper
kixi/stats {:mvn/version "0.5.7" ; Various statistic measures implemented as transducers
@@ -202,8 +200,13 @@
org.eclipse.jetty.ee9.websocket/jetty-ee9-websocket-jetty-server]}
selmer/selmer {:mvn/version "1.12.70"} ; Jinja-like templates for Clojure
slingshot/slingshot {:mvn/version "0.12.2"} ; enhanced throw/catch, used by other deps
- software.amazon.awssdk/s3 {:mvn/version "2.40.13"} ; AWS SDK v2 for S3
- software.amazon.awssdk/sts {:mvn/version "2.36.2"} ; Required for S3 client to use service account
+ software.amazon.awssdk/s3 {:mvn/version "2.40.13" ; AWS SDK v2 for S3
+ ;; Metabase uses only sync S3Client (Apache HttpClient) + S3Presigner;
+ ;; excluding the async Netty HTTP client removes all transitive netty
+ ;; from the main uberjar and avoids version conflicts with driver-bundled netty.
+ :exclusions [software.amazon.awssdk/netty-nio-client]}
+ software.amazon.awssdk/sts {:mvn/version "2.36.2" ; Required for S3 client to use service account
+ :exclusions [software.amazon.awssdk/netty-nio-client]}
software.amazon.jdbc/aws-advanced-jdbc-wrapper {:mvn/version "2.6.5"} ; AWS JDBC wrapper for IAM authentication
stencil/stencil {:mvn/version "0.5.0"} ; Mustache templates for Clojure
techascent/tech.ml.dataset {:mvn/version "8.003"} ; Tabular data processing for chart statistics
diff --git a/modules/drivers/athena/deps.edn b/modules/drivers/athena/deps.edn
index 32ddd1b3c62..d28a74ee404 100644
--- a/modules/drivers/athena/deps.edn
+++ b/modules/drivers/athena/deps.edn
@@ -13,8 +13,17 @@
:exclusions [software.amazon.awssdk/athena-streaming]}
;; not on Maven Central; published to our private maven by the athena workflow
com.metabase/athena-streaming {:mvn/version "2.0"}
- ;; override transitive deps from netty-nio-client to fix CVE-2025-67735 (CRLF Injection)
- ;; the root deps.edn already overrides these, but Snyk scans this module in isolation
- ;; version should match the override in the root deps.edn
- io.netty/netty-codec-http {:mvn/version "4.2.12.Final"}
- io.netty/netty-codec-http2 {:mvn/version "4.2.12.Final"}}}
+
+ ;; Netty — pinned at latest 4.1.x patched release. The Athena JDBC driver's
+ ;; async AWS SDK path requires the 4.1 API; 4.2.x is not binary-compatible
+ ;; with classes the driver calls. 4.1.132 patches CVE-2026-33870 et al.
+ io.netty/netty-common {:mvn/version "4.1.132.Final"}
+ io.netty/netty-handler {:mvn/version "4.1.132.Final"}
+ io.netty/netty-transport {:mvn/version "4.1.132.Final"}
+ io.netty/netty-buffer {:mvn/version "4.1.132.Final"}
+ io.netty/netty-codec {:mvn/version "4.1.132.Final"}
+ io.netty/netty-codec-http {:mvn/version "4.1.132.Final"}
+ io.netty/netty-codec-http2 {:mvn/version "4.1.132.Final"}
+ io.netty/netty-resolver {:mvn/version "4.1.132.Final"}
+ io.netty/netty-transport-native-unix-common {:mvn/version "4.1.132.Final"}
+ io.netty/netty-transport-native-epoll {:mvn/version "4.1.132.Final"}}}
diff --git a/modules/drivers/bigquery-cloud-sdk/deps.edn b/modules/drivers/bigquery-cloud-sdk/deps.edn
index e23f979c5df..7a27c93b671 100644
--- a/modules/drivers/bigquery-cloud-sdk/deps.edn
+++ b/modules/drivers/bigquery-cloud-sdk/deps.edn
@@ -24,7 +24,9 @@
org.apache.arrow/arrow-vector {:mvn/version "18.3.0"}
;; was 1.71.0. bumping to 77
io.grpc/grpc-netty-shaded {:mvn/version "1.77.0"}
- ;; matches those in athena
+ ;; Netty 4.2.x — latest patched release. grpc-netty-shaded bundles its own
+ ;; shaded netty, but these modules are still pulled through arrow-memory-netty
+ ;; and must be pinned for security scanning.
io.netty/netty-common {:mvn/version "4.2.12.Final"}
io.netty/netty-buffer {:mvn/version "4.2.12.Final"}
;; pinned: google-cloud-bigquery pulls 2.18.2 which has resource exhaustion vulns