The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Enforce single-statement impersonated queries on all sql-jdbc drivers (#81653)
Riley Thompson0e0e6ac82b13
diff --git a/docs/developers-guide/driver-changelog.md b/docs/developers-guide/driver-changelog.mdindex 34a9d618713..6b0a37a3766 100644--- a/docs/developers-guide/driver-changelog.md+++ b/docs/developers-guide/driver-changelog.md@@ -6,6 +6,9 @@ title: Driver interface changelog## Metabase 0.64.0+- `metabase.driver/validate-impersonated-query` `[driver query]` now has a `:sql-jdbc` implementation that+ enforces, for every JDBC driver, that a connection-impersonated native query is a single statement.+- `metabase.driver/workspace-isolation-details` `[driver database workspace]` -- new workspace-isolationmultimethod. Computes the isolation identifiers (`:schema`, and driver-specific `:database_details` such asuser/password) for a workspace *before* any warehouse work happens; `init-workspace-isolation!`,diff --git a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.cljindex feefdccae42..676d22be23f 100644--- a/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj+++ b/enterprise/backend/test/metabase_enterprise/impersonation/driver_test.clj@@ -1245,3 +1245,16 @@(binding [driver.settings/*impersonation-allow-write?* true](is (= :ok (outcome (query write))))(is (= :rejected (outcome (query select)))))))))++(deftest validate-impersonated-query-is-enforced-for-all-impersonation-drivers-test+ (testing "every driver that supports connection-impersonation enforces the single-statement guard (SEC-1189)"+ (mt/test-drivers (mt/normal-drivers-with-feature :connection-impersonation)+ (let [query (fn [sql] {:stages [{:lib/type :mbql.stage/native :native sql}]})]+ (testing "a multi-statement native query is rejected"+ (is (thrown-with-msg?+ clojure.lang.ExceptionInfo #"single select statement"+ (driver/validate-impersonated-query driver/*driver* (query "SELECT 1; SELECT 2")))))+ (testing "a single select statement is still allowed"+ (let [result (driver/validate-impersonated-query :mysql (query "SELECT 1"))]+ (is (map? result))+ (is (string? (get-in result [:stages 0 :native])))))))))diff --git a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.cljindex 7a224d1da97..5815ee22670 100644--- a/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj+++ b/modules/drivers/sqlserver/src/metabase/driver/sqlserver.clj@@ -1325,10 +1325,6 @@(defmethod driver/llm-sql-dialect-resource :sqlserver [_]"metabot/prompts/dialects/sqlserver.md")-(defmethod driver/validate-impersonated-query :sqlserver- [driver query]- (driver.sql/validate-impersonated-query* driver query))-(defmethod sql-jdbc.sync/current-user-table-privileges :sqlserver[_driver conn-spec & {:as _options}];; role is NULL because HAS_PERMS_BY_NAME checks the current user's effectivediff --git a/src/metabase/driver/postgres.clj b/src/metabase/driver/postgres.cljindex 682a50c7187..feb13e0c55d 100644--- a/src/metabase/driver/postgres.clj+++ b/src/metabase/driver/postgres.clj@@ -1521,7 +1521,3 @@(defmethod driver/llm-sql-dialect-resource :postgres [_]"metabot/prompts/dialects/postgresql.md")--(defmethod driver/validate-impersonated-query :postgres- [driver query]- (driver.sql/validate-impersonated-query* driver query))diff --git a/src/metabase/driver/sql_jdbc.clj b/src/metabase/driver/sql_jdbc.cljindex 6174b0103e6..09f12bd5340 100644--- a/src/metabase/driver/sql_jdbc.clj+++ b/src/metabase/driver/sql_jdbc.clj@@ -68,6 +68,10 @@(driver/validate-db-details! driver details)(sql-jdbc.conn/can-connect? driver details))+(defmethod driver/validate-impersonated-query :sql-jdbc+ [driver query]+ (driver.sql/validate-impersonated-query* driver query))+(defmethod driver/table-rows-seq :sql-jdbc[driver database table](query driver database table {:select [:*]}))