Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Simplify failed backend artifact name (#79441)

Nemanja Glumac0ec5c4ea198d
diff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.yml
index f0703159c0f..417e5decf7c 100644
--- a/.github/actions/test-driver/action.yml
+++ b/.github/actions/test-driver/action.yml
@@ -72,25 +72,30 @@ runs:
# Workflow expressions have no arithmetic, so the shell computes it.
#
# run-tests.yml calls app-db.yml, backend.yml, drivers.yml and semantic-search.yml
- # into ONE run, so all four share an artifact namespace. Neither `github.job`
- # (`be-tests-postgres` exists in app-db.yml and drivers.yml) nor `junit-name`
- # (both derive `be-tests-postgres-ee`) is unique there on its own; together with
- # `artifact-suffix` they are.
+ # as part of ONE run, so all four share an artifact namespace. `junit-name` alone is not
+ # unique there — app-db.yml and drivers.yml both derive `be-tests-postgres-ee` — so
+ # `artifact-suffix` carries the rest of the discriminator.
- name: Resolve rerun artifact names
if: ${{ inputs.granular-rerun == 'true' }}
shell: bash
env:
- RERUN_ARTIFACT_BASE: ${{ format('failed-tests-{0}-{1}{2}', github.job, inputs.junit-name, inputs.artifact-suffix && format('-{0}', inputs.artifact-suffix) || '') }}
+ RERUN_ARTIFACT_BASE: ${{ format('failed-tests-{0}{1}', inputs.junit-name, inputs.artifact-suffix && format('-{0}', inputs.artifact-suffix) || '') }}
run: |
echo "RERUN_ARTIFACT=$RERUN_ARTIFACT_BASE-attempt-$GITHUB_RUN_ATTEMPT" >> "$GITHUB_ENV"
echo "RERUN_PREV_ARTIFACT=$RERUN_ARTIFACT_BASE-attempt-$((GITHUB_RUN_ATTEMPT - 1))" >> "$GITHUB_ENV"
+ # `pattern` (not `name`) because the artifact is legitimately absent whenever the
+ # previous attempt recorded nothing: `name` treats that as an error, `pattern`
+ # downloads nothing and moves on. The value is a literal — no glob metacharacters —
+ # so it matches exactly one artifact, which lands at `target/failed-tests`. A pattern
+ # that ever matched two would nest them under their artifact names instead, leaving
+ # the file absent and falling back to the full suite.
- name: Restore previously-failed tests
if: ${{ inputs.granular-rerun == 'true' && github.run_attempt != '1' }}
continue-on-error: true
uses: actions/download-artifact@v8
with:
- name: ${{ env.RERUN_PREV_ARTIFACT }}
+ pattern: ${{ env.RERUN_PREV_ARTIFACT }}
path: target
- name: Test database driver
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
index ca7965a8408..04763f14106 100644
--- a/.github/workflows/backend.yml
+++ b/.github/workflows/backend.yml
@@ -207,12 +207,18 @@ jobs:
if: ${{ github.run_attempt != '1' }}
run: echo "RERUN_PREV_ATTEMPT=$((GITHUB_RUN_ATTEMPT - 1))" >> "$GITHUB_ENV"
+ # `pattern` (not `name`) because the artifact is legitimately absent whenever the
+ # previous attempt recorded nothing: `name` treats that as an error, `pattern`
+ # downloads nothing and moves on. The value is a literal — no glob metacharacters —
+ # so it matches exactly one artifact, which lands at `target/failed-tests`. A pattern
+ # that ever matched two would nest them under their artifact names instead, leaving
+ # the file absent and falling back to the full partition.
- name: Restore previously-failed tests
if: ${{ github.run_attempt != '1' }}
continue-on-error: true
uses: actions/download-artifact@v8
with:
- name: failed-tests-be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}-attempt-${{ env.RERUN_PREV_ATTEMPT }}
+ pattern: failed-tests-be-tests-java-${{ matrix.java-version }}-${{ matrix.job.test-group-name }}-attempt-${{ env.RERUN_PREV_ATTEMPT }}
path: target
- name: "Test Java ${{ matrix.java-version }} ${{ matrix.job.name }}"