The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix public pivot table downloads (#76023)
Anderson11de545b4bad
diff --git a/frontend/src/metabase/redux/downloads.ts b/frontend/src/metabase/redux/downloads.tsindex ea8ad617f8c..92ddd132802 100644--- a/frontend/src/metabase/redux/downloads.ts+++ b/frontend/src/metabase/redux/downloads.ts@@ -307,6 +307,7 @@ const getPublicQuestionParams = (uuid: string,type: string,result: Dataset,+ exportParams: ExportParams,): DownloadQueryResultsParams => {const parameters = (result?.json_query?.parameters ?? []).map((param) => ({id: param.id,@@ -318,6 +319,7 @@ const getPublicQuestionParams = (url: Urls.publicQuestion({ uuid, type, includeSiteUrl: false }),params: new URLSearchParams({parameters: JSON.stringify(parameters),+ ..._.mapObject(exportParams, (value) => String(value)),}),};};@@ -493,7 +495,7 @@ export const getDatasetParams = ({);}if (resourceType === "question" && uuid) {- return getPublicQuestionParams(uuid, type, result);+ return getPublicQuestionParams(uuid, type, result, exportParams);}}diff --git a/frontend/src/metabase/redux/downloads.unit.spec.ts b/frontend/src/metabase/redux/downloads.unit.spec.tsindex 73428e45bc5..70d3e2f4dca 100644--- a/frontend/src/metabase/redux/downloads.unit.spec.ts+++ b/frontend/src/metabase/redux/downloads.unit.spec.ts@@ -129,6 +129,27 @@ describe("getDatasetParams - embed question (token-based)", () => {});});+describe("getDatasetParams - public question (uuid-based)", () => {+ const PUBLIC_UUID = "11111111-2222-3333-4444-555555555555";+ const question = new Question(createMockCard({ id: 1 }), undefined);+ const result = createMockDataset();++ it("forwards format_rows and pivot_results to the public question endpoint (#75545)", () => {+ const downloadParams = getDatasetParams({+ type: "xlsx",+ question,+ result,+ uuid: PUBLIC_UUID,+ enableFormatting: true,+ enablePivot: true,+ });++ const url = new URLSearchParams(downloadParams.params);+ expect(url.get("format_rows")).toBe("true");+ expect(url.get("pivot_results")).toBe("true");+ });+});+describe("getChartFileName", () => {beforeEach(() => {jest.useFakeTimers();