Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-2666 Row chart tooltip doesn't reflect column rename (#68137)

Gabriel Moreno11e96da48b2e
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.ts b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.ts
index f15bbd6de60..023d1ba4b88 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.ts
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.ts
@@ -91,9 +91,13 @@ const getColumnsData = (
datasetColumns: DatasetColumn[],
visualizationSettings: VisualizationSettings,
) => {
+ const columnTitle =
+ visualizationSettings["graph.x_axis.title_text"] ??
+ chartColumns.dimension.column.display_name;
+
const data = [
{
- key: chartColumns.dimension.column.display_name,
+ key: columnTitle,
value: formatNullable(datum.dimensionValue),
col: chartColumns.dimension.column,
},
diff --git a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
index 3fbc748b766..0e479ca293e 100644
--- a/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
+++ b/frontend/src/metabase/visualizations/visualizations/RowChart/utils/events.unit.spec.ts
@@ -89,6 +89,24 @@ const barData: BarData<GroupedDatum> = {
describe("events utils", () => {
describe("getHoverData", () => {
+ it("returns dimension key based on axis title setting when set", () => {
+ const keyValueData = getHoverData(
+ barData,
+ {
+ "graph.x_axis.title_text": "My Custom Dimension Label",
+ },
+ {
+ dimension: chartColumns.dimension,
+ metrics: [chartColumns.metrics[0]],
+ },
+ datasetColumns,
+ [series1],
+ seriesColors,
+ ).data;
+
+ expect(keyValueData?.[0].key).toBe("My Custom Dimension Label");
+ });
+
it("returns key-value pairs based on series_settings for charts without a breakout", () => {
const keyValueData = getHoverData(
barData,