Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

[Metabot] Prevent OSS SQL gen UI from showing in cloud migrated instances (#69649)

Sloan Sparger126eb6b1b183
diff --git a/src/metabase/llm/settings.clj b/src/metabase/llm/settings.clj
index abc9efaa113..a260a5714e2 100644
--- a/src/metabase/llm/settings.clj
+++ b/src/metabase/llm/settings.clj
@@ -90,5 +90,8 @@
:type :boolean
:setter :none
:export? false
- :getter (fn [] (or (some? (llm-anthropic-api-key))
- (premium-features/enable-metabot-v3?))))
+ :getter (fn [] (or
+ (premium-features/enable-metabot-v3?)
+ (and
+ (not (premium-features/is-hosted?))
+ (some? (llm-anthropic-api-key))))))
diff --git a/test/metabase/llm/settings_test.clj b/test/metabase/llm/settings_test.clj
index a4d460a979b..cc84678b9ab 100644
--- a/test/metabase/llm/settings_test.clj
+++ b/test/metabase/llm/settings_test.clj
@@ -2,6 +2,7 @@
(:require
[clojure.test :refer :all]
[metabase.llm.settings :as llm.settings]
+ [metabase.premium-features.core :as premium-features]
[metabase.test :as mt]))
(set! *warn-on-reflection* true)
@@ -29,14 +30,21 @@
;;; ------------------------------------------- llm-sql-generation-enabled Tests -------------------------------------------
(deftest llm-sql-generation-enabled-test
- (testing "returns true when Anthropic API key is set"
- (mt/with-temporary-setting-values [llm-anthropic-api-key "sk-ant-test"]
- (is (true? (llm.settings/llm-sql-generation-enabled)))))
+ (testing "returns true when Anthropic API key is set (self-hosted)"
+ (with-redefs [premium-features/is-hosted? (constantly false)]
+ (mt/with-temporary-setting-values [llm-anthropic-api-key "sk-ant-test"]
+ (is (true? (llm.settings/llm-sql-generation-enabled))))))
(testing "returns false when no API key and metabot not enabled"
(mt/with-premium-features #{}
(mt/with-temporary-setting-values [llm-anthropic-api-key nil]
- (is (false? (llm.settings/llm-sql-generation-enabled)))))))
+ (is (false? (llm.settings/llm-sql-generation-enabled))))))
+
+ (testing "returns false when hosted without metabot enabled, even with API key"
+ (with-redefs [premium-features/is-hosted? (constantly true)]
+ (mt/with-premium-features #{}
+ (mt/with-temporary-setting-values [llm-anthropic-api-key "sk-ant-test"]
+ (is (false? (llm.settings/llm-sql-generation-enabled))))))))
;;; ------------------------------------------- Settings Defaults Tests -------------------------------------------