Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Remove unused `metabase/utils/click-behavior` module (#72975)

Romeo Van Snick12d2583cfa8c
diff --git a/frontend/src/metabase/utils/click-behavior.ts b/frontend/src/metabase/utils/click-behavior.ts
deleted file mode 100644
index f76bb73948e..00000000000
--- a/frontend/src/metabase/utils/click-behavior.ts
+++ /dev/null
@@ -1,112 +0,0 @@
-import { msgid, ngettext, t } from "ttag";
-
-import { Dashboards } from "metabase/entities/dashboards";
-import { Questions } from "metabase/entities/questions";
-import Question from "metabase-lib/v1/Question";
-import type {
- ClickBehavior,
- ColumnSettings,
- DashboardCard,
- DatasetQuery,
-} from "metabase-types/api";
-
-type LinkTargetClickBehavior = {
- type: "link";
- linkType: "question" | "dashboard";
- targetId?: number;
-};
-
-export function getClickBehaviorDescription(dashcard: DashboardCard): string {
- const noBehaviorMessage = hasActionsMenu(dashcard)
- ? t`Open the drill-through menu`
- : t`Do nothing`;
- if (isTableDisplay(dashcard)) {
- const columnSettings =
- dashcard.visualization_settings?.column_settings ?? {};
- const count = Object.values(columnSettings).filter(
- (settings) => settings.click_behavior != null,
- ).length;
- if (count === 0) {
- return noBehaviorMessage;
- }
- return ngettext(
- msgid`${count} column has custom behavior`,
- `${count} columns have custom behavior`,
- count,
- );
- }
- const clickBehavior = dashcard.visualization_settings?.click_behavior as
- | ClickBehavior
- | undefined;
- if (clickBehavior == null) {
- return noBehaviorMessage;
- }
- if (clickBehavior.type === "link") {
- const { linkType } = clickBehavior;
- return linkType == null
- ? t`Go to...`
- : linkType === "dashboard"
- ? t`Go to dashboard`
- : linkType === "question"
- ? t`Go to question`
- : t`Go to url`;
- }
-
- return t`Filter this dashboard`;
-}
-
-export function hasActionsMenu(dashcard: DashboardCard): boolean {
- const datasetQuery = dashcard.card.dataset_query;
- if (!datasetQuery) {
- return false;
- }
- // This seems to work, but it isn't the right logic.
- // The right thing to do would be to check for any drills. However, we'd need a "clicked" object for that.
- const question = Question.create({
- dataset_query: datasetQuery as DatasetQuery,
- });
- return !question.isNative();
-}
-
-export function isTableDisplay(dashcard: DashboardCard): boolean {
- return dashcard?.card?.display === "table";
-}
-
-export function getLinkTargets(
- settings:
- | {
- click_behavior?: ClickBehavior;
- column_settings?: Record<string, ColumnSettings>;
- }
- | null
- | undefined,
-) {
- const { click_behavior, column_settings = {} } = settings ?? {};
- return [
- click_behavior,
- ...Object.values(column_settings).map(
- (colSettings) => colSettings.click_behavior,
- ),
- ]
- .filter(hasLinkedQuestionOrDashboard)
- .map(mapLinkedEntityToEntityQuery);
-}
-
-function hasLinkedQuestionOrDashboard(
- behavior: ClickBehavior | null | undefined,
-): behavior is LinkTargetClickBehavior {
- if (behavior?.type === "link") {
- return (
- behavior.linkType === "question" || behavior.linkType === "dashboard"
- );
- }
- return false;
-}
-
-function mapLinkedEntityToEntityQuery(behavior: LinkTargetClickBehavior) {
- return {
- entity: behavior.linkType === "question" ? Questions : Dashboards,
- entityType: behavior.linkType,
- entityId: behavior.targetId,
- };
-}