Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Convert ViewSidebar to TypeScript (#69070)

Fraser13a641e649ad
diff --git a/frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.jsx b/frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.tsx
similarity index 76%
rename from frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.jsx
rename to frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.tsx
index bc8f3202477..cf4ac3a27ac 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.jsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewSidebar/ViewSidebar.tsx
@@ -1,16 +1,23 @@
import cx from "classnames";
-import PropTypes from "prop-types";
+import type { ReactNode } from "react";
import { Box } from "metabase/ui";
import ViewSidebarS from "./ViewSidebar.module.css";
+interface ViewSidebarProps {
+ side: "left" | "right";
+ width?: number;
+ isOpen?: boolean;
+ children?: ReactNode;
+}
+
export const ViewSidebar = ({
side = "right",
width = 400,
isOpen,
children,
-}) => (
+}: ViewSidebarProps) => (
// If we passed `width` as prop, it would end up in the final HTML elements.
// This would ruin the animation, so we pass it as `widthProp`.
<Box
@@ -30,12 +37,3 @@ export const ViewSidebar = ({
</Box>
</Box>
);
-
-ViewSidebar.propTypes = {
- left: PropTypes.bool,
- right: PropTypes.bool,
- width: PropTypes.number,
- isOpen: PropTypes.bool,
- side: PropTypes.oneOf(["left", "right"]),
- children: PropTypes.node,
-};